public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree
Date: Mon, 18 Jun 2018 21:50:31 +0200	[thread overview]
Message-ID: <CAKv+Gu9-HqjN9tDLeS-SAZu_-Tm2nTRYCf3qCzt0RKtvkrTh9g@mail.gmail.com> (raw)
In-Reply-To: <20180618194200.t2umfeewglsx4adg@bivouac.eciton.net>

On 18 June 2018 at 21:42, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Jun 18, 2018 at 08:16:03PM +0200, Ard Biesheuvel wrote:
>> Align the prototype of ArmMtlLib's MtlWaitUntilChannelFree () with the
>> one in the ArmMtlNullLib implementation (rather than the other way around,
>> since edk2-platforms has a conflicting implementation as well)
>
> Eew.
> But yeah, this looks like the practical fix.
>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks

Pushed as 1f739a851ce8ea8c9c4d9c4c7a5862fd44ab6ab4

>> ---
>>  ArmPkg/Include/Library/ArmMtlLib.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/Include/Library/ArmMtlLib.h b/ArmPkg/Include/Library/ArmMtlLib.h
>> index 4218a741e5eb..48641258ba68 100644
>> --- a/ArmPkg/Include/Library/ArmMtlLib.h
>> +++ b/ArmPkg/Include/Library/ArmMtlLib.h
>> @@ -68,7 +68,7 @@ typedef struct {
>>  EFI_STATUS
>>  MtlWaitUntilChannelFree (
>>    IN MTL_CHANNEL  *Channel,
>> -  IN UINT64       TimeOutInMicroSeconds
>> +  IN UINTN        TimeOutInMicroSeconds
>>    );
>>
>>  /** Return the address of the message payload.
>> --
>> 2.17.1
>>


      reply	other threads:[~2018-06-18 19:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 18:16 [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree Ard Biesheuvel
2018-06-18 19:42 ` Leif Lindholm
2018-06-18 19:50   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9-HqjN9tDLeS-SAZu_-Tm2nTRYCf3qCzt0RKtvkrTh9g@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox