From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC852210F52BC for ; Mon, 18 Jun 2018 12:50:33 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id e15-v6so17966076iog.1 for ; Mon, 18 Jun 2018 12:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WyySdK3vPditfDCPHnKcQVpOl2hscShzvyF/EnVrC54=; b=fm8K28iL2VbODrKV+KGfFthzD6NUfo2J5ztOFmGtS828Paj9myx18ATgVHpE/SYqDf e1S7xW6i/rre1F4ceRFvhp8VR6OKba6lBrE9Mfui9v33ndjRnkbNav7v+M/vqIitpdC6 MSc3PXsn5xg9SYjQXhFIfep94kjbgyGVuscAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WyySdK3vPditfDCPHnKcQVpOl2hscShzvyF/EnVrC54=; b=cEzsg7iccs+EQH645wM6LTW8dKBe9aBTurhRl8fGlxZqTcLamOUMk+I1N3Odw3oluU cg/nFbIRz1kTcGCgcWHJv0eOWpXUo1RcPrHFMzBJp7+jVxFb9hcjO1dSa+Z6+9N90EFp pqUyHd6+lwHLZZfgvD+Qm7Sx7rZXMT/ctIwYg8e2130ptjOZHyNsKaQxnrd3FmV+1B7C rImdQP0cI0v06e6oodQYPI8BsUpF3v9S1MT2EMyQhuECHth7/XIEt3asl+53IiYMwbl4 55dQBOZLEYtK5b584PJJXNw9EL9MOpzPFUwhK1xwShmXOUYe874VL5cRo4GylLY5HP5G RuVw== X-Gm-Message-State: APt69E0LdjWDMur/sQHH5KaGO/jb9mtkDYhtPNVDsC1AL/eq7ZEdhF1Z JxQqXA8m2ttKSufmmwsoEZujhAw4rPYe1M00tnuTXGfarEI= X-Google-Smtp-Source: ADUXVKLh0s6UOmBO+MknC6TT9JLODG/ZlQWYFQin+dUsVVC+2PPGDUSARdKQ7qvRkY2kphzJGKLx7q1VBEB0fV/DdRM= X-Received: by 2002:a6b:dd0b:: with SMTP id f11-v6mr11075972ioc.173.1529351432470; Mon, 18 Jun 2018 12:50:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 12:50:31 -0700 (PDT) In-Reply-To: <20180618194200.t2umfeewglsx4adg@bivouac.eciton.net> References: <20180618181603.26242-1-ard.biesheuvel@linaro.org> <20180618194200.t2umfeewglsx4adg@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 18 Jun 2018 21:50:31 +0200 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 19:50:34 -0000 Content-Type: text/plain; charset="UTF-8" On 18 June 2018 at 21:42, Leif Lindholm wrote: > On Mon, Jun 18, 2018 at 08:16:03PM +0200, Ard Biesheuvel wrote: >> Align the prototype of ArmMtlLib's MtlWaitUntilChannelFree () with the >> one in the ArmMtlNullLib implementation (rather than the other way around, >> since edk2-platforms has a conflicting implementation as well) > > Eew. > But yeah, this looks like the practical fix. > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as 1f739a851ce8ea8c9c4d9c4c7a5862fd44ab6ab4 >> --- >> ArmPkg/Include/Library/ArmMtlLib.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPkg/Include/Library/ArmMtlLib.h b/ArmPkg/Include/Library/ArmMtlLib.h >> index 4218a741e5eb..48641258ba68 100644 >> --- a/ArmPkg/Include/Library/ArmMtlLib.h >> +++ b/ArmPkg/Include/Library/ArmMtlLib.h >> @@ -68,7 +68,7 @@ typedef struct { >> EFI_STATUS >> MtlWaitUntilChannelFree ( >> IN MTL_CHANNEL *Channel, >> - IN UINT64 TimeOutInMicroSeconds >> + IN UINTN TimeOutInMicroSeconds >> ); >> >> /** Return the address of the message payload. >> -- >> 2.17.1 >>