Re: [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 25 November 2017 at 13:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Nov 20, 2017 at 11:45:03AM +0000, Ard Biesheuvel wrote:
>> Remove two pieces of legacy that are only used by platforms residing under
>> Platform/ARM in edk2-platforms, and really shouldn't serve as examples for
>> new contributions. So after migrating the code to edk2-platforms, remove it
>> from EDK2.
>
> 1/2 should also delete
> ---
>   # FDT installation
>   EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf {
>     <LibraryClasses>
>       # It depends on BdsLib that depends on TimerLib
>       TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
>   }
> ---
> from EmbeddedPkg/EmbeddedPkg.dsc
>
> and 2/2 should delete the
> ---
>   BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
> ---
> resolution from the same file.
>
> 2/2 should also delete the BdsLib references from ArmPkg/ArmPkg.dsc:
> ---
> [LibraryClasses.common]
>   BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
> ---
> and
> ---
> [Components.common]
>   ArmPkg/Library/BdsLib/BdsLib.inf
> ---
>
> And both should be ordered after the Android*Boot patches I just sent out.
> If you do that, and fold in the above comments:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed as

34b17101ef91 EmbeddedPkg: remove FdtPlatformDxe
fc82cfc24c15 ArmPkg: remove BdsLib and remaining ARM BDS related PCDs

with the requested changes folded in.