From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::234; helo=mail-io0-x234.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E6A921A10985 for ; Sun, 26 Nov 2017 03:24:38 -0800 (PST) Received: by mail-io0-x234.google.com with SMTP id 79so25878764ioi.3 for ; Sun, 26 Nov 2017 03:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+jgwEkt8V8E9Kj5QXTUSpoOMHVn/A1q3RWoUZ4cKi5M=; b=AzWLVIt21KmcwKZkNXrLPpted0PgFqXqvLuCI/J1Zg0LqZHi7gOblotZtvuP91ZZcr Q3HNZmEsA4VOwfJeoBV1qCi2TVkKv/urpuEQz+A/qb9AR5O3U9Z7CbvkFzPhSo1ZWXiV wLRdEf8LtO5ypFn55FQnBxcU53Kd2Dtkm6A/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+jgwEkt8V8E9Kj5QXTUSpoOMHVn/A1q3RWoUZ4cKi5M=; b=IRXZlRxQ19KpeIQFyWFUxYaApFLlzXZZxpCSvEMI1tI0ODymtVNZjC/HbaVZ+YC0EI XWdlsSBkO02WsF/tzDfrCcKOCguM++09vs/9MgD1032YqCSQDMPaQnqJBuyjXBDljVBR X3Wu9nTzhiEY9o+A7y+MP1BSC5yvFW/7ZskwlXGl8aOX0LFyTAVywvMjcR35G6untrQi /00evDaszHdYLKTWVwIvGKwWj3jvpQHiWzNgIESmGPM1xFdvzrrIzuRR3p8OV8v1HWd8 gIgAiMSwSGfJ8ruvKH6TPwFNffiJZe7/Ek57FKnHtu17cKDaMquCxtSNMO6zDGmObCAw EDjg== X-Gm-Message-State: AJaThX6ryYxauSIR2sk62652RyX4C5VzmGtSAl0C0ZWjmz09414xgMFT SJBiZg8775EkYp9n59ORLKubJ6iuRtpYg91U8HRwhQ== X-Google-Smtp-Source: AGs4zMafeQCBpTGqpGKeujbJijDPrCioW71hbb9dC7bl1ditTs8IxC21aL9mFXT73IkMPkeNU5tsU3SlE2b7hCMUtGc= X-Received: by 10.107.178.145 with SMTP id b139mr38236821iof.52.1511695738292; Sun, 26 Nov 2017 03:28:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Sun, 26 Nov 2017 03:28:57 -0800 (PST) In-Reply-To: <20171125133801.ctcnwquugi3dpbjt@bivouac.eciton.net> References: <20171120114505.22344-1-ard.biesheuvel@linaro.org> <20171125133801.ctcnwquugi3dpbjt@bivouac.eciton.net> From: Ard Biesheuvel Date: Sun, 26 Nov 2017 11:28:57 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Nov 2017 11:24:38 -0000 Content-Type: text/plain; charset="UTF-8" On 25 November 2017 at 13:38, Leif Lindholm wrote: > On Mon, Nov 20, 2017 at 11:45:03AM +0000, Ard Biesheuvel wrote: >> Remove two pieces of legacy that are only used by platforms residing under >> Platform/ARM in edk2-platforms, and really shouldn't serve as examples for >> new contributions. So after migrating the code to edk2-platforms, remove it >> from EDK2. > > 1/2 should also delete > --- > # FDT installation > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf { > > # It depends on BdsLib that depends on TimerLib > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf > } > --- > from EmbeddedPkg/EmbeddedPkg.dsc > > and 2/2 should delete the > --- > BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf > --- > resolution from the same file. > > 2/2 should also delete the BdsLib references from ArmPkg/ArmPkg.dsc: > --- > [LibraryClasses.common] > BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf > --- > and > --- > [Components.common] > ArmPkg/Library/BdsLib/BdsLib.inf > --- > > And both should be ordered after the Android*Boot patches I just sent out. > If you do that, and fold in the above comments: > Reviewed-by: Leif Lindholm > Thanks. Pushed as 34b17101ef91 EmbeddedPkg: remove FdtPlatformDxe fc82cfc24c15 ArmPkg: remove BdsLib and remaining ARM BDS related PCDs with the requested changes folded in.