public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: tien.hock.loh@intel.com
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	thloh85@gmail.com
Subject: Re: [PATCH 1/1] SD : Continue setting up sd even if SD_HIGH_SPEED is not supported
Date: Fri, 15 Mar 2019 12:27:34 +0100	[thread overview]
Message-ID: <CAKv+Gu90msoWN=egKyXYmUjOz62PMjx3MUvxYtv++_rz_YZ2=Q@mail.gmail.com> (raw)
In-Reply-To: <1550822283-26255-1-git-send-email-tien.hock.loh@intel.com>

On Fri, 22 Feb 2019 at 08:58, <tien.hock.loh@intel.com> wrote:
>
> From: "Loh, Tien Hock" <tien.hock.loh@intel.com>
>
> If SD doesn't support SD_HIGH_SPEED, function should still continue to
> setup SD to go into 4 bits more if it is supported.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Loh Tien Hock <tien.hock.loh@intel.com>

Thanks Tien Hock

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

I tweaked your patch slightly, to fix some whitespace errors, and
downgrade the severity of the 'high speed not supported' message to
DEBUG_INFO

Pushed as b0189eac00a5..c49f298d28cb


  parent reply	other threads:[~2019-03-15 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  7:58 [PATCH 1/1] SD : Continue setting up sd even if SD_HIGH_SPEED is not supported tien.hock.loh
2019-03-15  3:27 ` Loh, Tien Hock
2019-03-15 11:27 ` Ard Biesheuvel [this message]
2019-03-18  1:53   ` Loh, Tien Hock
  -- strict thread matches above, loose matches on Subject: below --
2018-10-25  6:56 tien.hock.loh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu90msoWN=egKyXYmUjOz62PMjx3MUvxYtv++_rz_YZ2=Q@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox