From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E0703211D9174 for ; Fri, 15 Mar 2019 04:27:45 -0700 (PDT) Received: by mail-it1-x144.google.com with SMTP id l15so10225990iti.4 for ; Fri, 15 Mar 2019 04:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LjRIVEYG3lm/2IEyyxSc/1QntOwMQb+NFNJW+mBEZKM=; b=f4eleIf5RbwbKSO/BfUAQMz8sMQllmTV+I0BStub3XuoqtJNRjpixEtjdAMAwMqVC5 U151FwsP3/OnyA2FFVkmGwMewURH7fcb6u4nCY/98K207y7ZD3pKhjoqAnRw4Gj3HLmI 7AG4fQlP8qe4MY5MLGZx2CekvdWHEpCgjuYU/Gwt5lv42t2fnZh0ZluWn4TWgcj/4qKX 4KwP4jG8H4C94xkAzEfXrFFMGsHkXtpmQbG5S1fUoFxvWVf7UaM0oMIYlZ5yMmr4aIza XL3NXrDcKp/QKh7lIpDBBKC+xSruQeyuAmhYeTDd7tWh3nY6x2oDee6sOCzgFLZWxJal SL+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LjRIVEYG3lm/2IEyyxSc/1QntOwMQb+NFNJW+mBEZKM=; b=Fd0cqHdeLBMREoa+QbmFPpzHM6AptcEfdJKMqxZCEQjRP1w1UAqGwr+IZIZMApHmOJ iGM/d1ImtiJQgw1o94haaRnErZGcbfjZADzEQI7nJh6WxRosnY2Mp6mqaAkMAATfrO4Z SCR6xgkWnA607t6rBZJ5rsSF+cT2k/j9pGmXVBBX/yYPLyIgXNsRnFBU8aSotQ4wHm75 rPRDAxRczFVLzrWiirMn5jXS+fW1FK2mGdmVjVVtWc7mzJ5HbY6scVjQeNhZxkqHERq2 TEGe10UMG5g0Netvt8vq898R/NfwuhcY+EVwB8WmK6baKVumpNi6u5HbLYpMMRu1K8Dl XNag== X-Gm-Message-State: APjAAAWJ74ep9xprJQEySPoLjquEmZSDEsn+aaDddwoAGLCLgsHldBtX G7hYhPYJGUwBBdinFijJ4tOyr4sWEotOjB+CRVUQHQ== X-Google-Smtp-Source: APXvYqw6ZmhWulTme3fgNRh9vYaR9bPsWvcLW4p4X5/xQZ6QuHMpURaJuWZFvg8bJNNgXK8sbosHiVzO/kAb/0tJj2w= X-Received: by 2002:a24:1947:: with SMTP id b68mr1475422itb.121.1552649265093; Fri, 15 Mar 2019 04:27:45 -0700 (PDT) MIME-Version: 1.0 References: <1550822283-26255-1-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1550822283-26255-1-git-send-email-tien.hock.loh@intel.com> From: Ard Biesheuvel Date: Fri, 15 Mar 2019 12:27:34 +0100 Message-ID: To: tien.hock.loh@intel.com Cc: "edk2-devel@lists.01.org" , Leif Lindholm , thloh85@gmail.com Subject: Re: [PATCH 1/1] SD : Continue setting up sd even if SD_HIGH_SPEED is not supported X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 11:27:46 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 22 Feb 2019 at 08:58, wrote: > > From: "Loh, Tien Hock" > > If SD doesn't support SD_HIGH_SPEED, function should still continue to > setup SD to go into 4 bits more if it is supported. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Loh Tien Hock Thanks Tien Hock Reviewed-by: Ard Biesheuvel I tweaked your patch slightly, to fix some whitespace errors, and downgrade the severity of the 'high speed not supported' message to DEBUG_INFO Pushed as b0189eac00a5..c49f298d28cb