From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Marcin Wojtas <mw@semihalf.com>,
Pipat Methavanitpong <methavanitpong.pipat@socionext.com>
Subject: Re: [PATCH] EmbeddedPkg: add mx66u1g45g nor flash info
Date: Thu, 16 Nov 2017 16:29:45 +0000 [thread overview]
Message-ID: <CAKv+Gu90nqGiWeT+fRdHWSZvAuW_H2GP+Xpend3D1Y2Pt6z9wg@mail.gmail.com> (raw)
In-Reply-To: <20171116162412.uupodh3m2msjvm5l@bivouac.eciton.net>
On 16 November 2017 at 16:24, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Nov 15, 2017 at 11:19:32AM +0000, Ard Biesheuvel wrote:
>> From: Pipat Methavanitpong <methavanitpong.pipat@socionext.com>
>>
>> Add Macronix MX66U1G45G definition to NorFlashInfoLib
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Pipat Methavanitpong <methavanitpong.pipat@socionext.com>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>> index 750f37a0e8..fb26b4f9bc 100644
>> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c
>> @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = {
>> {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0},
>> {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0},
>> {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0},
>> + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0},
>> {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0},
>
> Hmm, I'm beginning to think we should have figured out a sorting
> strategy for this table ... oh well.
>
> The values match what QEMU uses, so:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Pushed as ca094756267e
prev parent reply other threads:[~2017-11-16 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 11:19 [PATCH] EmbeddedPkg: add mx66u1g45g nor flash info Ard Biesheuvel
2017-11-15 11:27 ` Marcin Wojtas
2017-11-16 16:24 ` Leif Lindholm
2017-11-16 16:29 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu90nqGiWeT+fRdHWSZvAuW_H2GP+Xpend3D1Y2Pt6z9wg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox