From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 015FC2035A7AD for ; Thu, 16 Nov 2017 08:25:36 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id u132so687793ita.0 for ; Thu, 16 Nov 2017 08:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6gpVrYdcItVVzxu3YHHwiimTZ08FWATBsGheFcZ+oNg=; b=XM2fJ2lz5s+ChmQEhtGldsreqf2VV3nsJyYjBI1wyP2HEPVOcG5cEslYenUNOHcv61 XPhM17s74zcvZhvnQKn5Mulm9MGceVymNuotRaaME692HXWLzC3hJi3V6y63OOmZ8JK8 UH1OFn3DelKGeTH/eZlJJy8NCDn6BSupdrDnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6gpVrYdcItVVzxu3YHHwiimTZ08FWATBsGheFcZ+oNg=; b=m63RL0nekkudBG4VeanPPqK9os4Otqqz6nj7cgmSkRbTe67KEQjxXC6d4JppjXQYJ8 5fTaCcbzm7o9xv3/dPF4Sn9GMvcHnwFbeNRZOQqttsP05fAoSvrwmAi2r/8hXOpM3rAF QnOqp7TeQ7ILbtnAzGVxWSyuaBrdcKLRsMOtbrLPl4BIztIYhUnUcAl/CZiJK9LlqdIE XAbVS12mka0vT+1pavvaNcdSg3EVV9zcaarYDur+aoR5bQjeOamwCggIp0J3OARYZM8/ 5ZV/zzkaLZQTa8CEk9vh7KLabiKaDA93//IUduqtdj8rNuXXrN/FHsXBwIzDrUmf3jPd UOBw== X-Gm-Message-State: AJaThX5c3uhjLEBvmNnza/M0h7k6LtmH+vgnXU0ScfF7IKjY4532iGIv QziU4luiPcBhC9uszwYcTPMC2Dhi9m9QYHzf0dxITw== X-Google-Smtp-Source: AGs4zMZzeWMFoO1PD/fKKAWZkbSUIMq5lQBRGURRWFZf14udnXd2FvXJwrM7O2Zu+mWZj2uPDgCOr/urdPhuHaHxFZM= X-Received: by 10.36.141.70 with SMTP id w67mr2908070itd.58.1510849786124; Thu, 16 Nov 2017 08:29:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.3 with HTTP; Thu, 16 Nov 2017 08:29:45 -0800 (PST) In-Reply-To: <20171116162412.uupodh3m2msjvm5l@bivouac.eciton.net> References: <20171115111932.22507-1-ard.biesheuvel@linaro.org> <20171116162412.uupodh3m2msjvm5l@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 16 Nov 2017 16:29:45 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Marcin Wojtas , Pipat Methavanitpong Subject: Re: [PATCH] EmbeddedPkg: add mx66u1g45g nor flash info X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 16:25:37 -0000 Content-Type: text/plain; charset="UTF-8" On 16 November 2017 at 16:24, Leif Lindholm wrote: > On Wed, Nov 15, 2017 at 11:19:32AM +0000, Ard Biesheuvel wrote: >> From: Pipat Methavanitpong >> >> Add Macronix MX66U1G45G definition to NorFlashInfoLib >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Pipat Methavanitpong >> Signed-off-by: Ard Biesheuvel >> --- >> EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> index 750f37a0e8..fb26b4f9bc 100644 >> --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c >> @@ -57,6 +57,7 @@ STATIC CONST NOR_FLASH_INFO NorFlashIds[] = { >> {L"mx25l51235f", {0xc2, 0x20, 0x1a}, 3, 256, 64 * 1024, 1024, 0}, >> {L"mx25l12855e", {0xc2, 0x26, 0x18}, 3, 256, 64 * 1024, 256, 0}, >> {L"mx66u51235f", {0xc2, 0x25, 0x3a}, 3, 256, 64 * 1024, 1024, 0}, >> + {L"mx66u1g45g", {0xc2, 0x25, 0x3b}, 3, 256, 64 * 1024, 2048, 0}, >> {L"mx66l1g45g", {0xc2, 0x20, 0x1b}, 3, 256, 64 * 1024, 2048, 0}, > > Hmm, I'm beginning to think we should have figured out a sorting > strategy for this table ... oh well. > > The values match what QEMU uses, so: > Reviewed-by: Leif Lindholm > Pushed as ca094756267e