From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79AD8803B1 for ; Wed, 22 Mar 2017 07:13:16 -0700 (PDT) Received: by mail-io0-x22f.google.com with SMTP id b140so66233845iof.1 for ; Wed, 22 Mar 2017 07:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QxtejKsE0GK9cJAgvYMA+MuNQIZ/0oX+SxNKAOzoMHo=; b=Wxg/i9ItPtUGHZXehvETZmlw3bsEbrYt+Ve9HkH7v9uwI4PJt3groDonumDusizIFJ 2GZIXqHrznx1Yi0gYoNGViorxmV5OaVXVzhOr7ar1AwQAJ/9CHlVak/JfDlwrssEOdbm YKPop3bs9hZA6v1YOQnyAGMvm6YNn+CGgo+kc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QxtejKsE0GK9cJAgvYMA+MuNQIZ/0oX+SxNKAOzoMHo=; b=oOGT7fCNdbdqH1bSd38iPlONUdbNd6ZcAjxyLFwqIgbTnFcITKrxV+P7Yhys8lOwXG spXLYJwxcftnKhfBj5zQZuGkyXjAN/0+lmotcl/neFbrD9KyZ1IfWyVJ4jcVv9rvyNB4 9idZCbFgWnIAI7T6L4Ebf506klUvjXdCq7roH3CMLTOYl+vEW4FviSt48R8bYh4hWs22 ZI9Uv4YGWKU1SbFZ2HwnEpdiLHinG90NxL07j0d/uDfyJ44a0oaPRbuQq+3X2Rz8GLhz pQ//jFSgpBl7uilMdw2F72sjqWB+q4L0H6MCIUGECRwSkmiUiRTbFOeKMSukVW4WhOBu TqxQ== X-Gm-Message-State: AFeK/H0nsdoKM0nd6SkY7boUjanw4ExIc4xu3mizpo1hhrSwvrZwlgPA+EwiaBM8aZAqtLQCQ1UbqtLIwfUKPZNn X-Received: by 10.107.168.21 with SMTP id r21mr34663143ioe.45.1490191995804; Wed, 22 Mar 2017 07:13:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 22 Mar 2017 07:13:15 -0700 (PDT) In-Reply-To: <20170317204731.31488-5-lersek@redhat.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-5-lersek@redhat.com> From: Ard Biesheuvel Date: Wed, 22 Mar 2017 14:13:15 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v2 04/12] ArmVirtPkg/XenAcpiPlatformDxe: don't cast UINT64 to pointer directly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 14:13:16 -0000 Content-Type: text/plain; charset=UTF-8 On 17 March 2017 at 20:47, Laszlo Ersek wrote: > Because that breaks the (upcoming) ARM (32-bit) build of the driver. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c b/ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c > index 203946f97bf8..49f9b5d2822a 100644 > --- a/ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c > +++ b/ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.c > @@ -73,7 +73,8 @@ GetXenArmAcpiRsdp ( > ASSERT (RegSize == 2 * sizeof (UINT64)); > > RegBase = SwapBytes64(Reg[0]); > - RsdpStructurePtr = (EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *)RegBase; > + RsdpStructurePtr = > + (EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *)(UINTN)RegBase; > > if (RsdpStructurePtr && RsdpStructurePtr->Revision >= 2) { > Sum = CalculateSum8 ((CONST UINT8 *)RsdpStructurePtr, > -- > 2.9.3 > >