public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>,
	Jagadeesh Ujja <jagadeesh.ujja@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	 Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Subject: Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver
Date: Thu, 2 May 2019 10:48:59 +0200	[thread overview]
Message-ID: <CAKv+Gu91QAMU0aqHDL9fb3tTyp2b+v-NXwChY3DvfVC8QRT2uQ@mail.gmail.com> (raw)
In-Reply-To: <CADpYukbr-D6GY7g30izQFc39Hbcnp51Nc-YreVosLNT3KUMS-g@mail.gmail.com>

On Mon, 29 Apr 2019 at 14:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> hi Ard/Leif
>
> On Mon, Apr 29, 2019 at 2:22 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > On Mon, Apr 29, 2019 at 10:17:17AM +0200, Ard Biesheuvel wrote:
> > > > I mean, the actually relevant bit is basically
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mtd/afs.c,
> > > > isn't it?
> > > >
> > > > +Thomas.
> > >
> > > AIUI, these things are entirely separate. Exposing NOR flash via block
> > > I/O and disk I/O permits the standard partition driver and FAT
> > > filesystem driver to bind to it, so that you can have a standard FAT
> > > ESP on NOR flash. I don't this is related at all to the BootMonFs
> > > stuff
> >
> > If so, that's even sillier. If it has any business remaining
> > supported, that should be a separate driver consuming NorFlashDxe.
> >
> > And if ARM feels their platforms need it, they can write that driver.
> >
> > So how about we don't move it and just nuke the BlockIo/DiskIo bits?
> >
> > /
> >     Leif
> >
> I am little bit confused here, please confirm
> I have to copy “ArmPlatformPkg/Drivers/NorFlashDxe” to
> edk2-platforms/Platform/ARM/Drivers first and then rip out the block
> i/o
> and disk i/o parts to get StandaloneNorFlash driver? And retain
> “ArmPlatformPkg/Drivers/NorFlashDxe” as it is ?
>

No. The idea is to remove block i/o and disk i/o from the NOR flash
driver altogether, unless anyone has a compelling use case for them.

      reply	other threads:[~2019-05-02  8:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02 13:10 [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver Jagadeesh Ujja
     [not found] ` <CADpYukZHE6NY-U=EycJBVGbQ-XcxXpeT9w6svzWMePjvQXFciQ@mail.gmail.com>
2019-04-24  9:05   ` [edk2] " jagadeesh.ujja
2019-04-24 13:06     ` [edk2-devel] " Ard Biesheuvel
2019-04-29  5:59       ` Jagadeesh Ujja
2019-04-29  6:52         ` Ard Biesheuvel
2019-04-29  7:58           ` Leif Lindholm
2019-04-29  8:17             ` Ard Biesheuvel
2019-04-29  8:52               ` Leif Lindholm
2019-04-29 12:21                 ` Jagadeesh Ujja
2019-05-02  8:48                   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu91QAMU0aqHDL9fb3tTyp2b+v-NXwChY3DvfVC8QRT2uQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox