From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=PGYB0QlV;
 spf=pass (domain: linaro.org, ip: 209.85.166.195, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195])
 by groups.io with SMTP; Thu, 02 May 2019 01:49:12 -0700
Received: by mail-it1-f195.google.com with SMTP id q14so1970139itk.0
        for <devel@edk2.groups.io>; Thu, 02 May 2019 01:49:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=l61hMjb3n37p+NnFFFXgPU4InA7yE+O8ko3TIYYKkUg=;
        b=PGYB0QlVX5N+/BeGrvbXbytVzxF9fMagvZkk2HTIST7NdGWvsv0O7ByzT38Ee+Pc4I
         /vWzRAMUmQcaOCdxH7jiDuvLJZUo+iLH3k4x4U3s0oQ67ze6bw+lpAn/2urCU+ZgUAp8
         It8UUNc8qTTVnkJWcA9EFbT05BVOKUUwUXT4+4M1SYYcH2jG6qhF4OKbSMJSptecLe7u
         Hm2FjoSLXtwRvf1a8lvWs/4ZE66f1YQXQReKOhGqq+v5whcKC9V+Sopx8nug3nBUKL2P
         8j+L9RBIB6Lq+OMBvqLb20Y8rX1PZ0gZDzRGxBJ0thBaVjkCKGwJRAZdQZPQ+pqPukgz
         1A/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=l61hMjb3n37p+NnFFFXgPU4InA7yE+O8ko3TIYYKkUg=;
        b=TtNmMn+imYjK58snCih4h4d67NGtzuJDgt2fV96/JbMU0iER8GWiClcMiTzM39l0NX
         CXOlskmpzABeKvRRsMtdArRfHrQp2fsXJuQnTZ3t2gmw/Y8ej7rZtYdhWFdUgMyhyUop
         h9UcqDT1naxeQx77SqiRssluGx/LQVvRQbaKk3g6g4RUVk74r8oBasyrf4B3lVfuuQ9Z
         AipqzRVM/t/O4bypwthqzw1GqzUsEa2r+z8tKlgLIkKMdXEMExmKpIo+e18ChD0sm3+z
         72UDf9HuOWMDH74SRgeCSJb+3mbxokuQP2IbskB3pePVwNweKWOM1h9OwbTnvcI9tv//
         ZIsA==
X-Gm-Message-State: APjAAAWejNmb1zNsoDBdhbc1VkDRGPZaDnWVffr6PTV36LgiUox41GAd
	2rx+FQyUhjHxsTqshkI6ILT2CQRTlyn6LcBi72c3K7cOswM=
X-Google-Smtp-Source: APXvYqxdyJjpfunss4MYax1ETQV6HZRHATYzeU2bF6RObFgMwxgNPlsREC8gFiIlbaAVIY4Iqg2H7S+m4ZcklBL54xg=
X-Received: by 2002:a05:6638:94:: with SMTP id v20mr1597620jao.2.1556786950783;
 Thu, 02 May 2019 01:49:10 -0700 (PDT)
MIME-Version: 1.0
References: <1554210602-2957-1-git-send-email-jagadeesh.ujja@arm.com>
 <CADpYukZHE6NY-U=EycJBVGbQ-XcxXpeT9w6svzWMePjvQXFciQ@mail.gmail.com>
 <CADpYukb5xECL2j02usxeORS-pmxO64O8R9HZoZGK3RGYB3gcDA@mail.gmail.com>
 <CAKv+Gu-K5SWY6XUSANWPBRsFGz=YEo0B-CDc_AbzQZEO-VuNkA@mail.gmail.com>
 <CADpYukYbf=eW6hHiez5uBMRrbRH5Zm+UD6y_eEsm8n-HMUx_CQ@mail.gmail.com>
 <CAKv+Gu93L7=n+8b_t5p88+TLGkur=Pnn3NSY+7WRcCgxR+kfEQ@mail.gmail.com>
 <20190429075816.y4gyeyqt4kp7lffk@bivouac.eciton.net> <CAKv+Gu-kFo7DH+n=KR-CJR8ibbZ3wdmS=Z+RZw=wJhgCpYd9eA@mail.gmail.com>
 <20190429085207.tmt3wr36vepu7d5p@bivouac.eciton.net> <CADpYukbr-D6GY7g30izQFc39Hbcnp51Nc-YreVosLNT3KUMS-g@mail.gmail.com>
In-Reply-To: <CADpYukbr-D6GY7g30izQFc39Hbcnp51Nc-YreVosLNT3KUMS-g@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 2 May 2019 10:48:59 +0200
Message-ID: <CAKv+Gu91QAMU0aqHDL9fb3tTyp2b+v-NXwChY3DvfVC8QRT2uQ@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver
To: edk2-devel-groups-io <devel@edk2.groups.io>, Jagadeesh Ujja <jagadeesh.ujja@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>, 
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 29 Apr 2019 at 14:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote=
:
>
> hi Ard/Leif
>
> On Mon, Apr 29, 2019 at 2:22 PM Leif Lindholm <leif.lindholm@linaro.org> =
wrote:
> >
> > On Mon, Apr 29, 2019 at 10:17:17AM +0200, Ard Biesheuvel wrote:
> > > > I mean, the actually relevant bit is basically
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/=
tree/drivers/mtd/afs.c,
> > > > isn't it?
> > > >
> > > > +Thomas.
> > >
> > > AIUI, these things are entirely separate. Exposing NOR flash via bloc=
k
> > > I/O and disk I/O permits the standard partition driver and FAT
> > > filesystem driver to bind to it, so that you can have a standard FAT
> > > ESP on NOR flash. I don't this is related at all to the BootMonFs
> > > stuff
> >
> > If so, that's even sillier. If it has any business remaining
> > supported, that should be a separate driver consuming NorFlashDxe.
> >
> > And if ARM feels their platforms need it, they can write that driver.
> >
> > So how about we don't move it and just nuke the BlockIo/DiskIo bits?
> >
> > /
> >     Leif
> >
> I am little bit confused here, please confirm
> I have to copy =E2=80=9CArmPlatformPkg/Drivers/NorFlashDxe=E2=80=9D to
> edk2-platforms/Platform/ARM/Drivers first and then rip out the block
> i/o
> and disk i/o parts to get StandaloneNorFlash driver? And retain
> =E2=80=9CArmPlatformPkg/Drivers/NorFlashDxe=E2=80=9D as it is ?
>

No. The idea is to remove block i/o and disk i/o from the NOR flash
driver altogether, unless anyone has a compelling use case for them.