From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.2793.1581151850270129988 for ; Sat, 08 Feb 2020 00:50:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=v/wbUJrI; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id c9so1573687wrw.8 for ; Sat, 08 Feb 2020 00:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2B4++UN++kNpaj0YI1DETw5QOsB52FPKdecerGwhYfU=; b=v/wbUJrItT1XV1v/ZQVNy6iUirLwuQ7CHquRdx+BKGA+OwLI6MllmYHFQElIOLHihv AlrCE+vaUAkYSVW7l0zjfvygIo1X4IwBtH86+cOPcu00iqGO8eX3IvMA5fAbyUjXToUm waVUPMtxKhOlGIbTmVnq40+qVOCsrKT0zsMsS/B3Ava2pHsCZWulACHikxOT/B0keVHg 38QwsFX+JEZBzm9jmE+inEuqf4225AG1yYyu3O49CjBKp62f+40xAVfEW9jhNTCFPt5B 9KS1ae/BjtUpF8amFvrlVGYhCGLjQlIBT1/uVKmq8WJ2jFykLDtrs866eHmXrITFLLa1 T/NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2B4++UN++kNpaj0YI1DETw5QOsB52FPKdecerGwhYfU=; b=MAeGXeKPMqDtFGzeFS3pFl08D6748923vCEivqOHZ+fJr3blcyTY1PsCRqe9CHOjc7 FprkFUD8/YkBShzvv1zPhoKieNyS/LUT4scEvnvkapRCWwWBQN2JcJodd/PD82QAXw+X JXSdBmVFrkfpE1ZZyMj+4H3dMROX9yT8hniKnkVnTgCF3nuaYI0PiBpvrSOK+nHSiiC3 WGbXJWtyZQlSzn47T1PAHzgNFacvdByJUyyxocNUPKhXaMVQ/YVtH1hEpk322TaTTcdL pm8R2vCka+hgQ6KAkHQiMKRXmFMcEkKaQ1CIASAqMdzDSX5eTqpzLzvM+Bp6daVPNkiv YuAw== X-Gm-Message-State: APjAAAXT+hlGh6BYhI5DvQ0NbnG963fPTCkxakxSxI39Oh9KczMUfUIT dq4XVlYUoVmRvUNyxJFKBidhgfOKyAC6d62dhhM1Lw== X-Google-Smtp-Source: APXvYqw+kk+jSoOF8r02Q+vGXpuvPoHey4WlujseaCeFfCtcgULhAcTU8p1IvzCIIP85slYpIZPpWWz7S5ngu1dDk2A= X-Received: by 2002:a5d:6a4b:: with SMTP id t11mr4291484wrw.262.1581151848677; Sat, 08 Feb 2020 00:50:48 -0800 (PST) MIME-Version: 1.0 References: <20200203131358.16796-1-pete@akeo.ie> In-Reply-To: <20200203131358.16796-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Sat, 8 Feb 2020 08:50:37 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Jeremy Linton Content-Type: text/plain; charset="UTF-8" On Mon, 3 Feb 2020 at 13:14, Pete Batard wrote: > > Changes from v2: > * Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check > > Jeremy Linton (2): > Silicon/Broadcom/Net: Add Genet stub driver to setup MAC > Platform/RPi4: Enable Broadcom Genet stub driver > > Pete Batard (1): > Platform/RPi: Add PlatformPcdLib to set the Genet MAC address > For the series, Reviewed-by: Ard Biesheuvel Pushed as 2253a252a61b..3f0d14bb1358 > Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c | 45 ++++++++ > Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf | 43 ++++++++ > Platform/RaspberryPi/RPi4/RPi4.dsc | 5 + > Platform/RaspberryPi/RPi4/RPi4.fdf | 1 + > Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 40 +++++++ > Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c | 114 ++++++++++++++++++++ > Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h | 20 ++++ > Silicon/Broadcom/Drivers/Net/BcmNet.dec | 22 ++++ > 8 files changed, 290 insertions(+) > create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c > create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h > create mode 100644 Silicon/Broadcom/Drivers/Net/BcmNet.dec > > -- > 2.21.0.windows.1 >