From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.3662.1576136069988707939 for ; Wed, 11 Dec 2019 23:34:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=NYyCSlMt; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id d16so1518684wre.10 for ; Wed, 11 Dec 2019 23:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=o028ix89kCgxef6LIkVk9RqOOD9eV6vF+A1WEu8G0b8=; b=NYyCSlMtgIKPP8uXnSy66KKeqkBKFUjvCX3/dssIZlckSh1I0G1SoFV3TsIkfFnr6e UFvQmYwehDLbiXG558TkWZg4Pbvuk/rTNlKWAAztzBUkTTDObzmwasGpW/ICYvovKaV4 HD7I3cgR91+jshVP7LHOR+2p6pPe8l1+VSCkJlyKYTmV6IcBS/Hf2voHlGspc2YA1wiY JLY5q19OrzN89whHGd2KyOD6k9jAkv6wnTOZYcFea9PqooAYUv+lIzCsquB6lVlBgfo1 hqU4/Ctw8H5nvIIifcYQ6jWqSSxzUWiMQnJncbItZLiCkwkwDbmJCC+lH2cAdYY4OGGQ GmbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o028ix89kCgxef6LIkVk9RqOOD9eV6vF+A1WEu8G0b8=; b=es6dXPwS1hpVfFkwvcZRtjQhhpbyXDBnC9ywtTqctT1NjKoOUoxBabuPW9Oo5dAVo2 DawNMnCPxYcs6iD779EXkUQEJwsZviGlQUX4Mp3i49pFhRhR+0yxbNrCHLuYmRXysj2o N2C/KvwIw10Wo0T2nX2h8GdtD/Nvl42IfJtAojO2v9J04f830wHx52ZcnL+p8ANgfHVc sVFtQUubae9jc+SA8uZ7ZoRP0ZbzZUc7GbrtWjTRdOpTPzYDMPJ1FPhhuncTC5B1OuRM NLmCo5ycRhpHTaaC66TQGgiihQ+1HG6I8/iJsBjAMFOphkduM6yPqVDbr5Jxrw/wii6o 45Nw== X-Gm-Message-State: APjAAAX12Zf4vNsA6Zs4C83MHi1d4VsVhjakp3seBvSymh4HA5740Lck 8kgSgt5bL3r1UHpBLY2FeEH3iz93AVv4ZOXyuUl9rQ== X-Google-Smtp-Source: APXvYqykVQWvXi9PB00isALcJtPuFg5wCq9jQIZivI60kAnxnYTL+wNdZS13GFhlJ9IotujH74HggCKYnztACgC+ap4= X-Received: by 2002:a5d:46c1:: with SMTP id g1mr4458030wrs.200.1576136068464; Wed, 11 Dec 2019 23:34:28 -0800 (PST) MIME-Version: 1.0 References: <20191210182304.13540-1-pete@akeo.ie> <4A89E2EF3DFEDB4C8BFDE51014F606A14E5649C1@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5649C1@SHSMSX104.ccr.corp.intel.com> From: "Ard Biesheuvel" Date: Thu, 12 Dec 2019 07:34:26 +0000 Message-ID: Subject: Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types To: "Gao, Liming" Cc: Pete Batard , "Kinney, Michael D" , edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 12 Dec 2019 at 01:26, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Thanks Pushed as bfb141cf19dd6f9b8df8b9d0914a5b3b15e1a798 > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Wednesday, December 11, 2019 6:01 PM > > To: Pete Batard ; Kinney, Michael D ; Gao, Liming > > Cc: edk2-devel-groups-io ; Leif Lindholm ; Philippe Mathieu-Daud=C3=A9 > > > > Subject: Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR= UART types > > > > (add MdePkg maintainers) > > > > On Tue, 10 Dec 2019 at 19:23, Pete Batard wrote: > > > > > > As per the Microsoft Debug Port Table 2 (DBG2) documentation, that > > > can be found online, we are missing 2 serial interface types for > > > Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi). > > > > > > These same types are present in DebugPort2Table.h so add them to > > > SerialPortConsoleRedirectionTable.h too. > > > > > > Note that we followed the same idiosyncrasies as DebugPort2Table > > > for naming these new macros. > > > > > > Signed-off-by: Pete Batard > > > > Acked-by: Ard Biesheuvel > > > > > --- > > > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h = | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirec= tionTable.h > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > > > index b069fb2be97f..2066c7895e59 100644 > > > --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTab= le.h > > > +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTab= le.h > > > @@ -90,6 +90,16 @@ typedef struct { > > > /// > > > #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYP= E_ARM_SBSA_GENERIC_UART 0x0e > > > > > > +/// > > > +/// ARM DCC > > > +/// > > > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYP= E_DCC 0x0f > > > + > > > +/// > > > +/// BCM2835 UART > > > +/// > > > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYP= E_BCM2835_UART 0x10 > > > + > > > // > > > // Interrupt Type > > > // > > > -- > > > 2.21.0.windows.1 > > >