From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0EABF203525EE for ; Thu, 26 Oct 2017 07:53:53 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id m81so5965732ioi.13 for ; Thu, 26 Oct 2017 07:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NnM2mCQRDl6o4O5mdzvHYFj8YSh74aRcuFsWMiFCg44=; b=I8d5dSuF0y6k6yvERSTntcwEo/+Wr+CvcnrjlrQYwO7+byD1GSk9kjPfzO3HZLj5p7 7BO/vF/zh9U8GduutPyYQqFSOoqWafhy/h7SFFA1JWfvz6edVhU8PsCbUfF7qf48qoq8 ctHBoWBo5FQwIvmAgISuTWIA08ItSx1m2cXZs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NnM2mCQRDl6o4O5mdzvHYFj8YSh74aRcuFsWMiFCg44=; b=GI6svYSUnwj7eiGS27fUHq3nlg54ZGXaXbHP033Z8m/4/VdhBNDhrmaPHgptq84/ZK VxIv9wzSdE8cpPinMr9DzDPuBloRMcGOxyyulMbW96qMQUYCG/+QBWt/BMvNh1J9MbY5 5oMCd7xTSVzxCydggSxq4zC4x+6tRdFAgwODIdK6H6sfCUTGTnodwtNI8mK/pVZ4q88c h8TnhWVkecHD+PdNWKQk/xhEFkOI5e8qxXaira8ZuMiEmZ0gcTGZM6vFRFWMVxtn/fRj H3ZLVw9sWIDqrL/Vas7eP2QQ8tDE6Mo9eVAGbie3GHZgKDSlvwv1/rkuMWdRTH2/xb8i 9Osg== X-Gm-Message-State: AMCzsaXfmPV4UzZJPfqCXpMZu3IMKyYJjQxll4rSUO+JtMXlxsCnUou8 YRYkPPrlFwRtEhkI1SSS6ifvob8MURJ3ptQp7Ri8Lg== X-Google-Smtp-Source: ABhQp+Sn73+IVPg50addl0qd3nk4OPTcmwUyP2gHCTuS4rnPKdUaphRmpMXwR13xm52+/okmnz9twdehwflKcZSTOSk= X-Received: by 10.107.82.6 with SMTP id g6mr28981850iob.253.1509029858679; Thu, 26 Oct 2017 07:57:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Thu, 26 Oct 2017 07:57:38 -0700 (PDT) In-Reply-To: <20171026145643.q5e5rdvnza6twhpg@bivouac.eciton.net> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> <20171025175947.22798-4-ard.biesheuvel@linaro.org> <20171026145643.q5e5rdvnza6twhpg@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 26 Oct 2017 15:57:38 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Masami Hiramatsu Subject: Re: [PATCH edk2-platforms v2 03/23] Silicon/SynQuacer: add MemoryInitPeiLib implementation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 14:53:53 -0000 Content-Type: text/plain; charset="UTF-8" On 26 October 2017 at 15:56, Leif Lindholm wrote: > On Wed, Oct 25, 2017 at 06:59:27PM +0100, Ard Biesheuvel wrote: >> Replace the common MemoryInitPeiLib implementation with one that does >> not remove the primary FV from the memory map. This is a waste of >> memory and TLB entries, given that the OS can no longer use a 1 GB >> block mapping to map this memory. >> >> Since we have our own implementation now, there is no point in using >> ArmPlatformLib's GetVirtualMemoryMap() implementation, and we can >> simply declare and map the regions directly. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > This one still has commented-out bits of code. > I don't really want to have that in master. > Are we holding off on pushing until we get the dynamic detection > support ove SCMI, and are we expecting to drop the commented-out bits > when we do? > Yes.