From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=yLedzxLZ; spf=pass (domain: linaro.org, ip: 209.85.166.66, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by groups.io with SMTP; Wed, 10 Apr 2019 11:32:10 -0700 Received: by mail-io1-f66.google.com with SMTP id x7so3063467ioh.4 for ; Wed, 10 Apr 2019 11:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wter0K21tzzxAVKBDj+yKoV30JxFE0PTdpY+ygOtWBM=; b=yLedzxLZKlMAZKn54It04FmVSpU4SrU/evOcH9IxiUpgPA+vtB5CHy5gJMO6lRqmP1 8Gl4JkIozHvycNUw8vzZy4VWU/LLoCh1Ep4jb1bOdGHtt6u5uqm+F0vTuD+B3DWi8LGB Kkcs5cuhU3YbKim1fmhn32oLq4TLf9EQx+dm703PBpmaMAdL3n7B2C9FlC8KWERan0d6 ZnUvH+dH+r6xACO3uHcMDGDipJQSwLzrE5iXbMWejqIbMdgUlKZcxaTrShKrQq/y0mQo VOBkjPdjPTM8p+gJRr1RAmhTiTpMqDhexUK1FVJcWy+j69kdHrey2CLHxnds8jNa2CHH vlgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wter0K21tzzxAVKBDj+yKoV30JxFE0PTdpY+ygOtWBM=; b=aB8/Tc0kGY79pkPyl+64gDtexuug3U4/UZmxF30NJpIritnB5rbS9w8DHRQIOQLKwR WEwoeH+BF7kJ1GYa4Do7g8TXrQ+zB8VMOTcy4ItmOACkNl9oV7BSDptLVvx5MvE8d7E8 IpmufbiTk/5jg4Oafr+jKq+WbXZXO5OYtGmSeOR9LHgSyFTWVPSROONF+OvDfn+qa6w3 StTi2ICZSv8X3YDY9FbTI0dE7WRHWgE2BYcX341GH+haVVoQQ/9PgpIYxnLYckKncNFK TRcRrOwlPYmAvMfJ3xVc1t5YkySC2Dwkd+uSaJAwSfyGNa5W8ZqPmw0tq9BAG63HWJHz n6UA== X-Gm-Message-State: APjAAAUbjakFenMzoAEE6yoB3Zx1nvCAryyXp6dcP6EUQ8Ad3WNu/j6B zqQEdAl4sWjVfYaWAHogOx3y5GA4avFpnKdMZuUtxg== X-Google-Smtp-Source: APXvYqx1vpRz3pmHxbpngLl1M5pLRPzW3r16kIBPUPYtDZCkR2TU20kHHZa8XiC9fq7eihFlz1S+NEKNcd4sLhN9dPs= X-Received: by 2002:a5d:840d:: with SMTP id i13mr22543305ion.186.1554921129801; Wed, 10 Apr 2019 11:32:09 -0700 (PDT) MIME-Version: 1.0 References: <20190410084000.19660-1-jordan.l.justen@intel.com> <91c89fc9-409e-947b-7ac8-bf8a77b70db4@redhat.com> In-Reply-To: <91c89fc9-409e-947b-7ac8-bf8a77b70db4@redhat.com> From: "Ard Biesheuvel" Date: Wed, 10 Apr 2019 11:31:59 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 0/6] Fix PEI Core issue during TemporaryRamMigration To: Laszlo Ersek Cc: edk2-devel-groups-io , Jordan Justen , Liu Yu , Ray Ni , Andrew Fish , Leif Lindholm , Michael D Kinney Content-Type: text/plain; charset="UTF-8" On Wed, 10 Apr 2019 at 11:28, Laszlo Ersek wrote: > > On 04/10/19 18:41, Ard Biesheuvel wrote: > > On Wed, 10 Apr 2019 at 01:41, Jordan Justen wrote: > >> > >> https://github.com/jljusten/edk2.git temp-ram-support-v2 > >> > >> https://github.com/jljusten/edk2/commits/temp-ram-support-v2 > >> > >> v2: > >> * Add AARCH64 and ARM assembly > > > > Hi Jordan, > > > > I'm not sure I'm following the reasoning behind this. Does this fix an > > issue we currently have on ARM systems? > > IIUC, the PEI Core can only be updated to use the "safe path" (= the > assembly path) on IA32/X64 if that path (= the assembly path) *exists* > regardless of architecture. > > This is anyway my understanding of the last commit message in the series. > > I can't evaluate whether the problem statement, in the first commit > message in the series, would ever turn into an actual issue on > ARM/AARCH64, dependent on toolchain. On IA32/X64, we've seen examples > (although none of those have bit me personally), and AIUI the issue > could theoretically apply to all arches (again, dependent on toolchain). > > (Apologies if I've only increased the confusion with this -- but at > least it could help me improve my own understanding.) > > > And how did you build and/or test OVMF for ARM? > > Hmmm, I'm unsure where this question / implication comes from. AIUI, the > new ARM/AARCH64 assembly is automatically put to use if you run the PEI > Core -- as part of a firmware platform that uses temp RAM migration -- > on ARM/AARCH64. > OK, seems like I'm the one creating confusion here. These are MdeModulePkg patches not OvmfPkg patches, and I noticed some other patches by Jordan adding ARM/AARCH64 build support to OVMF. I will put the assembly patches on my to-review list, but it may take me a couple of days to get to them.