From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
"Kostya Porotchkin" <kostap@marvell.com>,
"Tomasz Michalec" <tm@semihalf.com>
Subject: Re: [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework
Date: Tue, 20 Nov 2018 10:57:49 +0100 [thread overview]
Message-ID: <CAKv+Gu94d3-cT11fzK1yoX2OxVQxKjhpyNfA3Qh87=kBb8N3-A@mail.gmail.com> (raw)
In-Reply-To: <1542610420-9258-1-git-send-email-mw@semihalf.com>
On Mon, 19 Nov 2018 at 07:54, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Hi,
>
> The sixth version of the patchset applies minor correction in the
> last patch and also simplifies the BoardDesc library callbacks.
> There is no unnecessary allocation now.
>
> Patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream-r20181119
>
> Generic driver patches with fixes and extended SdMmcOverride protocol:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-override-upstream-r20181109
>
> I'm looking forward to the comments and remarks.
>
> Best regards,
> Marcin
>
> Changelog:
> v5->v6:
> * 3,4,5
> - pass the pointer to the static table directly instead of
> the copy allocation
>
> * 6/8
> - remove freeing SdMmc board description structure in
> NonDiscoverableDevicesDxe, as from now on the static
> table will be used
>
> * 8/8
> - change SdMmcOverride protocol comment to '#PRODUCES'
> - s/Controler/Controller/
> - remove freeing board description structure
>
> v4->v5:
> * 1,2,6/8
> - add Ard's RB
>
> * 2,3,4,5
> - change parameters to OUT
> - assign count only after allocation is successful
>
> * 7/8 & 8/8
> - split driver rework patches into two steps
>
> v3->v4:
> * 1/7:
> - add Ard's RB
>
> * 2/7:
> - use local enum definition for SlotType in order not to include MdeModulePkg
> private header
>
> * 7/7:
> - rework capability handling, without using the structure defined in the
> MdeModulePkg header
>
> v2->v3
> * 1/7:
> - rename NotifyPhase parameter to PhaseData
>
> * 7/7:
> - rename NotifyPhase parameter to PhaseData
> - update UHS_MODE_SEL only for HS200/HS400
> in XenonSdMmcHcUhsSignaling
> - use local macros for standard SDHC registers in order not to
> include private MdeModulePkg header
>
> v1 -> v2
> * 1/7 and 7/7 - adjust to modified SdMmcOverride
> NotifyPhase and Capability routines
>
>
> Marcin Wojtas (2):
> Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride
> Marvell/Drivers: XenonDxe: Remove SdMmcPciHcDxe files
>
> Tomasz Michalec (6):
> Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information
> SolidRun/Armada80x0McBin: Introduce board description library
> Marvell/Armada70x0Db: Introduce board description library
> Marvell/Armada80x0Db: Introduce board description library
> Marvell/Drivers: MvBoardDesc: Extend information for SdMmc
> Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe
>
For the series
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as ce4f7528ed71..1360ddbc30e2
Thanks for
> 32 files changed, 1691 insertions(+), 7384 deletions(-)
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +-
> Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 3 +
> Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 +
> Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 3 +
> Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 3 +-
> Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.inf | 34 +
> Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf | 34 +
> Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf | 34 +
> Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 +
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/{SdMmcPciHcDxe.inf => XenonDxe.inf} | 33 +-
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h | 791 --------
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h | 550 ------
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.h | 151 ++
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.h | 53 +
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h | 131 +-
> Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 21 +-
> Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 60 +
> Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 60 +
> Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 60 +
> Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 24 +-
> Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c | 1 -
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/ComponentName.c | 211 ---
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c | 1164 ------------
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c | 1190 ------------
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c | 1320 --------------
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c | 1928 --------------------
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.c | 321 ++++
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 429 +++++
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 408 +++--
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c | 9 +-
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.uni | 23 -
> Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxeExtra.uni | 19 -
> 32 files changed, 1691 insertions(+), 7384 deletions(-)
> create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.inf
> create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf
> create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf
> rename Silicon/Marvell/Drivers/SdMmc/XenonDxe/{SdMmcPciHcDxe.inf => XenonDxe.inf} (65%)
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h
> create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.h
> create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.h
> create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c
> create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c
> create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/ComponentName.c
> delete mode 100755 Silicon/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c
> create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.c
> create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.uni
> delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxeExtra.uni
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-11-20 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 6:53 [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 1/8] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 2/8] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 3/8] SolidRun/Armada80x0McBin: Introduce board description library Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 4/8] Marvell/Armada70x0Db: " Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 5/8] Marvell/Armada80x0Db: " Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 6/8] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 7/8] Marvell/Drivers: XenonDxe: Remove SdMmcPciHcDxe files Marcin Wojtas
2018-11-19 6:53 ` [platforms: PATCH v6 8/8] Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe Marcin Wojtas
2018-11-20 9:57 ` Ard Biesheuvel [this message]
2018-11-20 10:30 ` [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu94d3-cT11fzK1yoX2OxVQxKjhpyNfA3Qh87=kBb8N3-A@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox