From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=ZOMwUfwh;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by groups.io with SMTP; Thu, 26 Sep 2019 05:17:23 -0700
Received: by mail-wm1-f68.google.com with SMTP id y21so2349509wmi.0
        for <devel@edk2.groups.io>; Thu, 26 Sep 2019 05:17:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=AYCDMLdiafOq192OxFkf/9BdOS8kTSaPPgTT8s2p0cU=;
        b=ZOMwUfwhWMYW/dB2zlXkmDJ5tS7xZoPb3TQaaoAG0mJfvJIsjdR3zleuNW74wZMiVm
         wvT5kgSR7EhN1xD61xGvb5mcgUcbAcq1eFpgKU1p5DA1NyBULad/vPRoqkHwz4QBlZ2U
         1K2ZhKnHF0YGDAhNL7dhlOu3d3sX7S+p6wrWzYeDGafH1zKZbl+vlSkBO9rA51Um8Zv5
         EvFXL9uuI+RTjgYYDmFIvUPW71jKKXY0SoFu0XC8DHBsmWksljud9RyHT29LLz/LCqAa
         658/hostCCLMN0e+GEczXKhL/b+frOsVUYjLvt/MA8/aBnCwvgP9N+v82gawpVuaptPV
         rr4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=AYCDMLdiafOq192OxFkf/9BdOS8kTSaPPgTT8s2p0cU=;
        b=eIWHBHJDJtos9ee445/K3VZwMZYSHQ+jK62SL9Qe6soY5m/Sd/3VXVwu0Cq2qXAKX6
         D5IFsl2+wapund5YItdhxkKPpbkee6Z49/n/HVytk43fKpc5YDDl3V/l1HF1bmc/Ln/c
         cJ2Poptrz3oEZiqVRpZ/osGj5ByhWl94+Kx46z9jxjG5RrCj1rMlbRzN0TKvI8OaCzTE
         OWXr+UPkp0UNv79Yn4RANV1xVZHzeXFREHWUd8NlMzef0wGsX4hF277rJ8Qn1pR00y3k
         gqdSk/4Sw1dnMnrvx9K+6UfUy2taUi65/5pnjzI47hJfIXUiiT9zwV07RQ+lfRHgJ8Pd
         otVg==
X-Gm-Message-State: APjAAAUGO0tdhDR2jSDYvgmPgUq62Q+Pn+KW8qbO+EJNGo0k9Qy44God
	z6mG6Zbjh8D/dcYThv1Lcis5wAHZyXfwm4RLCtisbl1H30WK6w==
X-Google-Smtp-Source: APXvYqwJqcoJewai+BVS3HCgmfsDogYzj2gEH4Y4cOvi7MCrHL3uduW1hH5ALgP2d0BMBAQXu8iYADlrUdsdsh+eC6Y=
X-Received: by 2002:a1c:3cc3:: with SMTP id j186mr2633809wma.119.1569500241640;
 Thu, 26 Sep 2019 05:17:21 -0700 (PDT)
MIME-Version: 1.0
References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-24-lersek@redhat.com>
In-Reply-To: <20190917194935.24322-24-lersek@redhat.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 26 Sep 2019 14:17:10 +0200
Message-ID: <CAKv+Gu94wpVaMQ7a7vJcb95WjFP=n6TB28JAUxx+mVvF_V6iQw@mail.gmail.com>
Subject: Re: [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Jordan Justen <jordan.l.justen@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 17 Sep 2019 at 21:50, Laszlo Ersek <lersek@redhat.com> wrote:
>
> The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*).
> Fix the call in the notification function of
> "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket".
>
> This is an actual bug. The reason it's never been triggered is likely that
> the "SNP.WaitForPacket" event is rarely waited for by applications -- edk2
> itself has zero instances of that, for example.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Notes:
>     build-tested only
>
>  OvmfPkg/VirtioNetDxe/Events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/VirtioNetDxe/Events.c b/OvmfPkg/VirtioNetDxe/Events.c
> index 620910774bc5..83e96e5e5d91 100644
> --- a/OvmfPkg/VirtioNetDxe/Events.c
> +++ b/OvmfPkg/VirtioNetDxe/Events.c
> @@ -58,7 +58,7 @@ VirtioNetIsPacketAvailable (
>    MemoryFence ();
>
>    if (Dev->RxLastUsed != RxCurUsed) {
> -    gBS->SignalEvent (&Dev->Snp.WaitForPacket);
> +    gBS->SignalEvent (Dev->Snp.WaitForPacket);
>    }
>  }
>
> --
> 2.19.1.3.g30247aa5d201
>
>