From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::132; helo=mail-it1-x132.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x132.google.com (mail-it1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7859D21959CB2 for ; Sat, 13 Oct 2018 09:52:09 -0700 (PDT) Received: by mail-it1-x132.google.com with SMTP id i76-v6so22270502ita.3 for ; Sat, 13 Oct 2018 09:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g+hLsHJtnycNp0mtxVifn60afY3fZN3wIksO7a24Q5w=; b=ftKSOOdNKhroyM28nJOAr9u7XSyrg69XOHjZKHTRVIdVvKahtyaP7/83yk0tDVqJ6U B2OMeoZ5rVnWGw4zz4NCft2fDuM2WcKsRJ62PUoGGYsn1kftYQLWRUS1IBX+5S+vDH9i C+8Cv9toUpDN0gfIPSwNRXTc8CVHS88vNfL+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g+hLsHJtnycNp0mtxVifn60afY3fZN3wIksO7a24Q5w=; b=tpzHSg18XM9l0mxi7gt1hYo2c77qEWVpCfVoChBhIVNIbgFybq2qvDmPUggcKl9zt5 sxbcQT2YIGfTNKXFbXWiRV44BAgOhe2K/x3kTbsHkaF2q9y3jYKrDe3qLNUJyKxYPyQH RwVybNo+3ibUxtfH16fdqJZBL7QlFGxEfN5mDMBoamls74T5vl6fLIvFP/Qx97yKFYfk W8Dk3XwIwr+FY1Uxnr3I9wbD+w6hUqEx7p858Dt/+z+PhLEKx0jcXZ/uVp0oUUK+N3/J fIC018lCWTkj+1J3VFByycaawnK3u4Y+RHdWIlpNY+LAXSMY83f0QE7g/GbZZp14nuqv D8kw== X-Gm-Message-State: ABuFfoiCgxiNXHOVzR4TI3RvxMPtjw+KiwVFnKGQT2/kSAt1+PIZu5MH 7Qs3wJWQBazDjBlN9F8qJH2tOBeXAI1e18pN70pbPg== X-Google-Smtp-Source: ACcGV60//DeM6+dDOg2omKtYCRFH0jyh/vQfGr/BW6oHAlmlNvFdDZru5rUNO20BmqdWJ2fCnII/VW0nbj92Vc+y+Ng= X-Received: by 2002:a24:4ac5:: with SMTP id k188-v6mr8940139itb.158.1539449528497; Sat, 13 Oct 2018 09:52:08 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Sat, 13 Oct 2018 09:52:07 -0700 (PDT) In-Reply-To: <1539448768-12816-1-git-send-email-yonghong.zhu@intel.com> References: <1539448768-12816-1-git-send-email-yonghong.zhu@intel.com> From: Ard Biesheuvel Date: Sat, 13 Oct 2018 18:52:07 +0200 Message-ID: To: Yonghong Zhu , Andrew Fish Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 16:52:09 -0000 Content-Type: text/plain; charset="UTF-8" On 13 October 2018 at 18:39, Yonghong Zhu wrote: > Remove the logic that the Python3 version must larger than 3.6. > We verified Python3 migration patches on version 3.6 and 3.7. > for other version we not verified it. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu I will note that this does not solve Andrew's problem, but nonetheless: Reviewed-by: Ard Biesheuvel Tested-by: Ard Biesheuvel > --- > BaseTools/toolsetup.bat | 7 ------- > edksetup.sh | 4 ++-- > 2 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat > index 0d4028d..d585431 100755 > --- a/BaseTools/toolsetup.bat > +++ b/BaseTools/toolsetup.bat > @@ -314,17 +314,10 @@ set PYTHON3=py -3 > echo. > echo !!! ERROR !!! %PYTHON3% not install. > echo. > goto end > ) > - FOR /F "TOKENS=1,2" %%i IN ('%PYTHON3% --version') DO set VERSION=%%j > - if /I "%VERSION%" LSS "3.6" ( > - echo. > - echo !!! ERROR !!! python version should greater than or equal to version 3.6. > - echo. > - goto end > - ) > > :check_freezer_path > @REM We have Python, now test for FreezePython application > if not defined PYTHON_FREEZER_PATH ( > echo. > diff --git a/edksetup.sh b/edksetup.sh > index d4e577e..84b3e63 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -129,13 +129,13 @@ function SetupPython3() > if [ "$ret" -eq 1 ]; then > origin_version=$python_version > export PYTHON3=$python > fi > done > - if [ -z "$origin_version" ] || [ `echo "$origin_version < 3.6" |bc` -eq 1 ]; then > + if [ -z "$origin_version" ]; then > echo > - echo ERROR!!!, python version should greater than or equal to version 3.6. > + echo ERROR!!!, Please install a Python 3 Tool. > echo > return 1 > fi > > > -- > 2.6.1.windows.1 >