Re: [PATCH edk2-platforms] Platform/Socionext/DeveloperBox: add SMBIOS tables

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 15 March 2018 at 19:34, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Mar 15, 2018 at 06:43:11PM +0000, Ard Biesheuvel wrote:
>> On 15 March 2018 at 18:37, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> > On Sat, Mar 03, 2018 at 11:29:23AM +0000, Ard Biesheuvel wrote:
>> >> This adds SMBIOS tables to the DeveloperBox platform describing the
>> >> BIOS, system, enclosure, CPUs, caches, PCIe slots and system memory,
>> >> which almost amounts to the mandatory minimum as given by the SMBIOS
>> >> spec. Only the type 17 structures currently lack detailed information
>> >> about the DIMMs: the SPDs are on a I2C bus that is only accessible by
>> >> the SCP, and it currently does not share this information.
>> >>
>> >> Contributed-under: TianoCore Contribution Agreement 1.1
>> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> >
>> > So, this looks great, but you appear to have generated this patch
>> > against a working branch (DO_X86EMU, OsInstallerMenuDxe), so it won't
>> > apply for me automatically.
>>
>> Ehm, yes.
>>
>> I can respin it if you like? Or you can grab it here
>>
>> https://git.linaro.org/leg/noupstream/edk2-platforms.git/
>
> Nah, wasn't hard to resolve manually.
>
> So once you've done that and fixed the issue you spotted and I didn't:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed as ca11ac71980cdb4c1bd3b4c2c6549b90fc47b4cc

Thanks