From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::232; helo=mail-io0-x232.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6A251223FCF46 for ; Thu, 15 Mar 2018 13:54:34 -0700 (PDT) Received: by mail-io0-x232.google.com with SMTP id g14so1300688iob.13 for ; Thu, 15 Mar 2018 14:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IkUFWHgOBqg+WTFqlZEvtp5hvlFJiQeNl8OvIvb+pCQ=; b=Lh32PACHRT5agI/5sC44wQ5WPS7a0IHM25UNLHBYkwQGp+NRskdg+QyQFc0hEyUFfW nC0gHRjA8M7vLJxw1sKqNuDuQf4b3RysoP41Oe3CxcmSHDnS6ByGHv/xCKPKGkLlKNbZ ebQtL6B7Vp2YGAvxyXvegZl3Zj2St2gdIBe20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IkUFWHgOBqg+WTFqlZEvtp5hvlFJiQeNl8OvIvb+pCQ=; b=F2hTQn+iYbWiShLJWzK4dLX9ELEYEDVj9ROQfPkk4EdzqYpH+r/QJcMLdaLF51fWiR ffAOC0dmFG7wcK4MBunLMoYoYOmgt9whWHUC1R2tzHbRSznl3lvmLuHFAmNjtjuev0J7 BvpK+pnW7/QViYxzJVdkwwjPk2aCmTzJRVaTubwv1AKPkrrIXqkSu6VorlWSqu7Gdkqw mfudkigyKERp62w9eOr/ZlU1RrB8iA/8ByJj0MUTQJmLWzgSCl0jnDHaacVx8GOlAOIV l8l0vS+E1xq8Tzva2Lf2hj617hi6rHyJaFMOiDjHs12ypzyOOu6Ul7xWdVr7pCBWSnLh qx4g== X-Gm-Message-State: AElRT7G+MdLJjSR//4Oiifr10fA+gtfyx05qRNA7dAV/0tcJKVlROnIH czRep4+kWpYjcYBhzCaxc1f9eBNKmQx8H0WH8NPaJg== X-Google-Smtp-Source: AG47ELvrSBUPe+Yft3275W+SafgFDhOB3P3RGAwt02PVkAOvXg9HoqXuohvVWrLz0WVDSkBkGqUErjEvEVFjKToNbJ0= X-Received: by 10.107.14.16 with SMTP id 16mr5947491ioo.170.1521147656710; Thu, 15 Mar 2018 14:00:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Thu, 15 Mar 2018 14:00:55 -0700 (PDT) In-Reply-To: <20180315193427.l4kfz6ks7eob5xxq@bivouac.eciton.net> References: <20180303112923.13521-1-ard.biesheuvel@linaro.org> <20180315183725.h4vxgrf5ziqiwmyr@bivouac.eciton.net> <20180315193427.l4kfz6ks7eob5xxq@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 15 Mar 2018 21:00:55 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Platform/Socionext/DeveloperBox: add SMBIOS tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 20:54:34 -0000 Content-Type: text/plain; charset="UTF-8" On 15 March 2018 at 19:34, Leif Lindholm wrote: > On Thu, Mar 15, 2018 at 06:43:11PM +0000, Ard Biesheuvel wrote: >> On 15 March 2018 at 18:37, Leif Lindholm wrote: >> > On Sat, Mar 03, 2018 at 11:29:23AM +0000, Ard Biesheuvel wrote: >> >> This adds SMBIOS tables to the DeveloperBox platform describing the >> >> BIOS, system, enclosure, CPUs, caches, PCIe slots and system memory, >> >> which almost amounts to the mandatory minimum as given by the SMBIOS >> >> spec. Only the type 17 structures currently lack detailed information >> >> about the DIMMs: the SPDs are on a I2C bus that is only accessible by >> >> the SCP, and it currently does not share this information. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel >> > >> > So, this looks great, but you appear to have generated this patch >> > against a working branch (DO_X86EMU, OsInstallerMenuDxe), so it won't >> > apply for me automatically. >> >> Ehm, yes. >> >> I can respin it if you like? Or you can grab it here >> >> https://git.linaro.org/leg/noupstream/edk2-platforms.git/ > > Nah, wasn't hard to resolve manually. > > So once you've done that and fixed the issue you spotted and I didn't: > Reviewed-by: Leif Lindholm > Pushed as ca11ac71980cdb4c1bd3b4c2c6549b90fc47b4cc Thanks