From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH] OvmfPkg/OvmfXen: fix build by providing QemuLoadImageLib resolution
Date: Fri, 6 Mar 2020 08:23:03 +0100 [thread overview]
Message-ID: <CAKv+Gu96hsrRmJpcFrAOEtreWrGU_hiQmC1E=TijoQ4FVTFUmQ@mail.gmail.com> (raw)
In-Reply-To: <6fb9c2b1-893c-f23e-f968-374815196c8a@redhat.com>
On Fri, 6 Mar 2020 at 00:45, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 03/05/20 22:26, Ard Biesheuvel wrote:
> > Commit 859b55443a4253ba ("OvmfPkg/PlatformBootManagerLib: switch to
> > QemuLoadImageLib") replaced a dependency on LoadLinuxLib with one on
> > QemuLoadImageLib in the PlatformBootManagerLib implementation that is
> > shared between all OVMF builds, without taking into account that even
> > the Xen targeted builds incorporate this code, which is only used to
> > load kernels passed via the QEMU command line.
> >
> > Since this is dead code on Xen, we can satisfy the dependency using
> > the generic version of QemuLoadImageLib, which does not rely on
> > LoadLinuxLib, which we can therefore drop from OvmfXen.dsc.
> >
> > Fixes: 859b55443a4253bad8bb618d04a51b2ded67f24b
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > OvmfPkg/OvmfXen.dsc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > index d476694b18d5..85fe39f7896c 100644
> > --- a/OvmfPkg/OvmfXen.dsc
> > +++ b/OvmfPkg/OvmfXen.dsc
> > @@ -151,7 +151,7 @@ [LibraryClasses]
> > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> > SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf
> > QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf
> > - LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf
> > + QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf
> > MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/BaseMemEncryptSevLib.inf
> > LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf
> > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
Pushed as 1f3b1eb30822..80681884319d
prev parent reply other threads:[~2020-03-06 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 21:26 [PATCH] OvmfPkg/OvmfXen: fix build by providing QemuLoadImageLib resolution Ard Biesheuvel
2020-03-05 23:45 ` Laszlo Ersek
2020-03-06 7:23 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu96hsrRmJpcFrAOEtreWrGU_hiQmC1E=TijoQ4FVTFUmQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox