From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=FFo4PCBO;
 spf=pass (domain: linaro.org, ip: 209.85.166.182, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f182.google.com (mail-it1-f182.google.com [209.85.166.182])
 by groups.io with SMTP; Tue, 23 Apr 2019 09:53:00 -0700
Received: by mail-it1-f182.google.com with SMTP id w15so1340196itc.0
        for <devel@edk2.groups.io>; Tue, 23 Apr 2019 09:53:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=w2mgUhx+if5e1M4YNKU0L3VZGcKXodLexDBghVat3Jw=;
        b=FFo4PCBOIaLdjmKTqeM58N0F0cHSlh0bC+OlW9Y7XA5KCxP2pG5Iss7Cilfpcf9qzU
         P/ix+f5xTc8IbNrif8ygh2Np/8UjUfFiVjrHqlAgWrWcloKww+gd+iAoZUO9gOg8qSXp
         Q07bR3+Gom+0KS2Dv+FpC0loeGgnHGPNCqVP7ffM8wOFuHaF016RXkSBxpaSbSy3/tsZ
         CaniO0Ju3aKGWCqD/9yKBhopl2maUm7bohNaxWYDNLYH8UOgew6DOXevCNCO8EUaSBjv
         ZAMLVRHM8dBCXgjfyAgdpEsbRk0/PjpJ+yyphrPfFCSJi4+NcPKGXVFEJv/XoOPaFaIQ
         LLYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=w2mgUhx+if5e1M4YNKU0L3VZGcKXodLexDBghVat3Jw=;
        b=hGIoNEHxm7AQiOkv4ALBMX7oQxIymAC5u782S5zhdTdcNCs+B9WK5lJVYwkI5sGDlg
         rFbrFKknnOhX8MLij6a31Ne+uvuiRHcMOZvUIbYkCaIy691fl74LQDezyWAkCON6LkIt
         HFK1gwTIVUzt5ZQmC4jRlXgL/hlYP1Fb2E8mPttYlsJfbtNZtkAggpj3LcJsZHzblUMo
         yndw5Z+8zpIf8hAl/LeBlvdlIzAA5oIHP0+bJuoAIwTVZnjJNIAHzzok5c9xx3VkQBrM
         hdFQxYmh4cL6owDCt7UxMQgf5l7vUKkJW/XHT+ITSjUF6sEGjqubyWAqBj9wgDXk/94q
         MLoA==
X-Gm-Message-State: APjAAAVw8Z26TDAYCvVuJcoGUaEsEVmIguYXNfvt8n3OuC44gexpYSyf
	anl74y2eIn9LCJD4wuG2M/LywKjQyHr0pa+X1kKlQjySGEgzYQ==
X-Google-Smtp-Source: APXvYqw5G6SNxZzR6kIEXPdRVGr7vU9VBJqZ6ySe5kcVzbDBOsvHxQ4Z+WJ8GeBEMiT1pyS2wBpqjAOKOZS5qYA9nks=
X-Received: by 2002:a24:1312:: with SMTP id 18mr2555480itz.121.1556038378762;
 Tue, 23 Apr 2019 09:52:58 -0700 (PDT)
MIME-Version: 1.0
References: <20190420103454.5148-1-ard.biesheuvel@linaro.org>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C8C0A54@SHSMSX104.ccr.corp.intel.com>
 <CAKv+Gu9uxXJMGMX0FG3Hx1Z-dukw2EtWYsJAh4iYcY5PLvj69A@mail.gmail.com>
 <E92EE9817A31E24EB0585FDF735412F5B9C9CB90@ORSMSX113.amr.corp.intel.com>
 <CAKv+Gu8C6EhxAMmr2a9M=2KMX5jPtzdsuq5yidqZ--5pjzBWJw@mail.gmail.com> <E92EE9817A31E24EB0585FDF735412F5B9C9CBD7@ORSMSX113.amr.corp.intel.com>
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C9CBD7@ORSMSX113.amr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 23 Apr 2019 18:52:47 +0200
Message-ID: <CAKv+Gu96t5_8uwgxwxBogiKTQbkBMoooLCDiOjQqozkODdW0wg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: avoid ESRT accesses at runtime
To: edk2-devel-groups-io <devel@edk2.groups.io>, "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>, "Wang, Jian J" <jian.j.wang@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 23 Apr 2019 at 01:02, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Ard,
>
> I agree. Only consumer is only the DxeCapsuleLibFmp
> itself.
>
> I see I had a typo on the second option.  The
> statement to add after the copy and ASSERT()
> would be:
>
>   mEsrtTable->FwResourceCountMax = FwResourceCount;
>

I have added the following

    //
    // Set FwResourceCountMax to a sane value.
    //
    mEsrtTable->FwResourceCountMax = mEsrtTable->FwResourceCount;

and committed as 2c0d39ac4704b76b7efb67b0aee23c2e78045cbc

Thanks all