From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1668221197374 for ; Mon, 14 Jan 2019 05:47:06 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id k7so17609442iob.6 for ; Mon, 14 Jan 2019 05:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HFf6BzR6XpJtjRBue87x2J7tCx7Zu7UBxaEe9wdXf5Q=; b=YhSaseMiDXLs9e7HcAl8qAR5uDLY267GrI2aPen8/mDO0Ag+3syeS7TfhywGb4dDXO 3WRyC+4c1YSUWfnY2ZIEo/OJcRY0bM7StSbd4V0YX72f/EVKbVCkpHab7LzMZRBg4Hs0 LW6tWbuEWsWGywm0ScLS3A8hlxH3xzOk0gy8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HFf6BzR6XpJtjRBue87x2J7tCx7Zu7UBxaEe9wdXf5Q=; b=HxV9YRgk3a8tTudT6o+1UJian45uM3dDEd+2OB6ZH709rO5S80efYlCBwkjldfvkYz eUqbFkiR+RqqbX9du9iN/e9y60fwC268oDm0+OJU+XehBV7FKxlaFdPZBJlsADC1Z7Rj fSJ0zEm4FOPNAvHX/yW1ymOGFvvznL9qanAg1EVo01WfOdNu1CTbvXvZOan9F2nPhAPY 94tYGVRPtczfA5HUFsBmfv/WoW2zMHzepLlCG/MgzTUVKwXecFh2v3H9onw/7ohc2c6R Wqp+jHfjWCKskGr6M88L5dbT4UJ0psYPjHU/7NEiExahB2l7beFiFYDFFElIfNuvESbF 4FKQ== X-Gm-Message-State: AJcUukdUTW7oQ0PF/TR1eiEET9qjssbVtaU+YIV44LFLxZ3HgErrmsgR mUChrv5BsdVg0woDv8x2kMSPmpMrDOPrWNH1rCckQw== X-Google-Smtp-Source: ALg8bN48Syi2j7FRmlxcWK2Cj51qDobl3mgMaE4s7IERbdUuz08xcujCpZ4g9+pT5qH4vKIYoahcMYd8WUeX4TnTUD8= X-Received: by 2002:a5e:c206:: with SMTP id v6mr16997189iop.60.1547473624350; Mon, 14 Jan 2019 05:47:04 -0800 (PST) MIME-Version: 1.0 References: <20190107065541.1854-1-ard.biesheuvel@linaro.org> <20190114114138.ttqlr5mfzh465pic@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B156E@SHSMSX152.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B1638@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B1638@SHSMSX152.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 14 Jan 2019 14:46:52 +0100 Message-ID: To: "Gao, Liming" Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 13:47:06 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 14 Jan 2019 at 14:38, Gao, Liming wrote: > > I see IA32 and X64 arch both have this option. I have no idea on AArch64. > I think we should just add it for all LTO toolchains in the GCC family. These are fixed size data structures so LTO is entirely pointless here. > > -----Original Message----- > > From: Philippe Mathieu-Daud=C3=A9 [mailto:philmd@redhat.com] > > Sent: Monday, January 14, 2019 9:36 PM > > To: Gao, Liming ; Leif Lindholm ; Ard Biesheuvel > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH] BaseTools/tools_def ARM GCC5: disable LTO f= or ASLC invocations > > > > On 1/14/19 2:18 PM, Gao, Liming wrote: > > > Ard: > > > Could you consider the suggestion from https://lists.01.org/piperma= il/edk2-devel/2019-January/034698.html? > > > > There might be a special case for Aarch64, but I'm not seeing it. > > > > > > > > Thanks > > > Liming > > >> -----Original Message----- > > >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > >> Sent: Monday, January 14, 2019 7:42 PM > > >> To: Ard Biesheuvel > > >> Cc: edk2-devel@lists.01.org; Gao, Liming ; Fen= g, Bob C > > >> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for A= SLC invocations > > >> > > >> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote: > > >>> GCC for 32-bit ARM chokes on .aslc files when running with LTO > > >>> enabled. Since LTO has no benefit whatsoever here, just disable > > >>> it. > > >>> > > >>> Contributed-under: TianoCore Contribution Agreement 1.1 > > >>> Signed-off-by: Ard Biesheuvel > > >> > > >> Looks sensible. > > >> Reviewed-by: Leif Lindholm > > >> > > >>> --- > > >>> BaseTools/Conf/tools_def.template | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/too= ls_def.template > > >>> index f7eb87af14c2..e68cfd9a4997 100755 > > >>> --- a/BaseTools/Conf/tools_def.template > > >>> +++ b/BaseTools/Conf/tools_def.template > > >>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS =3D DEF(GCC5= _X64_DLINK_FLAGS) -flto -Os > > >>> *_GCC5_ARM_RC_PATH =3D ENV(GCC5_ARM_PREFIX)objcopy > > >>> > > >>> *_GCC5_ARM_ARCHCC_FLAGS =3D -mthumb > > >>> -*_GCC5_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > > >>> +*_GCC5_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) -fno-lto > > >>> *_GCC5_ARM_ASLDLINK_FLAGS =3D DEF(GCC5_ARM_ASLDLINK_FLAGS) > > >>> *_GCC5_ARM_ASM_FLAGS =3D DEF(GCC5_ARM_ASM_FLAGS) > > >>> *_GCC5_ARM_DLINK2_FLAGS =3D DEF(GCC5_ARM_DLINK2_FLAGS) > > >>> -- > > >>> 2.20.1 > > >>> > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > >