From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A61521184AA7 for ; Mon, 26 Nov 2018 08:53:13 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id m15so28792250itl.4 for ; Mon, 26 Nov 2018 08:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zQBTYWt8ed9KdDvMN7IljMN4Qy2PeYVjdKDW6xDHzjQ=; b=JwKh/2YCIneyL8/JFZUm3pegKVx71ZbpC/1mwAXe69CGRqzwDTCYEmx2EPKMfOZMsa x7xBGl4Fx6zxNUY0lnaxROqHaXX9OdnLd1eSoaYor1d+yEHflRX1iCjRF9C2e+g8TCCg +bGAbe/TWgMPBsrKOEy2ivnqTLfe7V8t6pmak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zQBTYWt8ed9KdDvMN7IljMN4Qy2PeYVjdKDW6xDHzjQ=; b=doYR+rw+2qgXLa9ojTNU21TrZmxW3Cjb//Tcd0fz+DV4qjsC/pXwEkRzQe5EtJ2LUx hBb5D9l65oiuUHg8037FMB3+xLxv/X1zDLOrlpddODuBifw/fJ/ppISGXbPrYQYafsJ+ xiolOa2d7K2hE85EVl4aFyzo9RUY9x74BSDEHhw2DyPfUUN05paUN4r88Mohl/5PIBs7 /RA1al5LzqCl/eLyqS1BWxzmT8bxULtfbR85jc1iG0TFhzXqBP0pmiucw1COXWrO91Bi 504FHBD0kj6XB5O4v7zHcuHqkeoiftxqlTOUy5QSv2kayDqSPlZIwL2+sAKKnhzaMXEj eGIQ== X-Gm-Message-State: AGRZ1gLdOL04D6X7LFsr0BhPUafT6l65Wa5rjUBeIkeFMTnMwVm7dbok t0DvRIazY6L5dFrhVWh0p5fgZqw5VV0M4eIIiptsHg== X-Google-Smtp-Source: AJdET5ceI16Mbaufvx3f0y/icGbxaRa8jVmnIBPgzKXW0G8GmVPpGir3pISGDbgEXAa+fK3NIu2r2aSrYGUvyQjZsNY= X-Received: by 2002:a02:8449:: with SMTP id l9-v6mr25139874jah.130.1543251193182; Mon, 26 Nov 2018 08:53:13 -0800 (PST) MIME-Version: 1.0 References: <20181123084406.27192-1-ard.biesheuvel@linaro.org> <20181126150645.lqtpo62uy257i25y@bivouac.eciton.net> In-Reply-To: <20181126150645.lqtpo62uy257i25y@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 26 Nov 2018 17:53:01 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Thomas Panakamattam Abraham , Nariman Poushin , Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 16:53:14 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 26 Nov 2018 at 16:06, Leif Lindholm wrote: > > On Fri, Nov 23, 2018 at 09:44:03AM +0100, Ard Biesheuvel wrote: > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > > only a single implementation exists, which now resides in edk2-platforms. > > > > This implementation has some issues in how it deals with Device Paths, > > so let's fix those, but first move over the library interface declaration > > and get rid of the parts that are no longer used. This will permit dropping > > it from ArmPkg in EDK2. > > For the series: > Reviewed-by: Leif Lindholm > Thanks. This series (and the Platform/Comcast patch) pushed as 397bbafdbff3..f98fb46d3a3d > > Changes since v1: > > - add Laszlo's ack to #1 > > - update #2 to remove everything we no longer need from BdsLib > > - drop #3 which was bogus > > - update #4 to ensure that we only duplicate the device path when we > > are about to return EFI_SUCCESS > > > > Ard Biesheuvel (3): > > Platform/ARM: import ARM platform specific BdsLib header > > Platform/ARM/BdsLib: drop unused functions > > Platform/ARM/BdsLib: maintain alignment for DevicePaths > > > > Platform/ARM/ARM.dec | 3 + > > .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- > > Platform/ARM/Include/Library/BdsLib.h | 26 ++ > > Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ---------------- > > Platform/ARM/Library/BdsLib/BdsFilePath.c | 95 +----- > > Platform/ARM/Library/BdsLib/BdsHelper.c | 122 -------- > > Platform/ARM/Library/BdsLib/BdsInternal.h | 16 +- > > Platform/ARM/Library/BdsLib/BdsLib.inf | 4 +- > > Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ------------------ > > 9 files changed, 52 insertions(+), 741 deletions(-) > > create mode 100644 Platform/ARM/Include/Library/BdsLib.h > > delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c > > delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c > > > > -- > > 2.17.1 > >