From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: chenc2 <chen.a.chen@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Michael D Kinney <michael.d.kinney@intel.com>,
Eric Dong <eric.dong@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH 20/37] MdeModulePkg: Removing ipf which is no longer supported from edk2.
Date: Wed, 13 Jun 2018 14:40:22 +0200 [thread overview]
Message-ID: <CAKv+Gu97v67jOWAmG-H4PvtSqVaW+Cb4vr27m9bX6BhXZjj_Jw@mail.gmail.com> (raw)
In-Reply-To: <20180613034437.8260-1-chen.a.chen@intel.com>
On 13 June 2018 at 05:44, chenc2 <chen.a.chen@intel.com> wrote:
> Removing rules for Ipf sources file:
> * Remove the source file which path with "ipf" and also listed in
> [Sources.IPF] section of INF file.
> * Remove the source file which listed in [Components.IPF] section
> of DSC file and not listed in any other [Components] section.
> * Remove the embedded Ipf code for MDE_CPU_IPF.
>
> Removing rules for Inf file:
> * Remove IPF from VALID_ARCHITECTURES comments.
> * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section.
> * Remove the INF which only listed in [Components.IPF] section in DSC.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> * Remove any IPF sepcific sections.
>
> Removing rules for Dec file:
> * Remove [Includes.IPF] section from Dec.
>
> Removing rules for Dsc file:
> * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC.
> * Remove any IPF specific sections.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: chenc2 <chen.a.chen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
Hello Chen,
Thanks for doing this work. I suppose this means we can finally get
rid of the 12 (!) copies of the following code throughout the code
base:
//
// NOTE: Some versions of Linux ELILO for Itanium have an incorrect
magic value
// in the PE/COFF Header. If the MachineType is Itanium(IA64) and the
// Magic value in the OptionalHeader is
EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC
// then override the returned value to EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC
//
if (Hdr.Pe32->FileHeader.Machine == IMAGE_FILE_MACHINE_IA64 &&
Hdr.Pe32->OptionalHeader.Magic == EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC) {
return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC;
}
Thanks,
Ard.
> ---
> .../BootManagerMenuApp/BootManagerMenuApp.inf | 2 +-
> MdeModulePkg/Application/HelloWorld/HelloWorld.inf | 2 +-
> .../MemoryProfileInfo/MemoryProfileInfo.inf | 2 +-
> MdeModulePkg/Application/UiApp/UiApp.inf | 2 +-
> .../Application/VariableInfo/VariableInfo.inf | 2 +-
> .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 2 +-
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cBusDxe.inf | 2 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.inf | 2 +-
> MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf | 2 +-
> MdeModulePkg/Bus/Isa/IsaBusDxe/IsaBusDxe.inf | 2 +-
> .../Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf | 2 +-
> MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +-
> MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf | 2 +-
> MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf | 2 +-
> MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf | 2 +-
> .../IncompatiblePciDeviceSupportDxe.inf | 2 +-
> .../Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf | 4 +-
> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 2 +-
> .../Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf | 2 +-
> .../Pci/SataControllerDxe/SataControllerDxe.inf | 2 +-
> .../Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 2 +-
> .../Bus/Pci/SdMmcPciHcPei/SdMmcPciHcPei.inf | 4 +-
> MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf | 4 +-
> MdeModulePkg/Bus/Pci/UfsPciHcPei/UfsPciHcPei.inf | 4 +-
> MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf | 2 +-
> MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf | 2 +-
> MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf | 2 +-
> MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf | 2 +-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf | 2 +-
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 2 +-
> .../Bus/Sd/EmmcBlockIoPei/EmmcBlockIoPei.inf | 2 +-
> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf | 2 +-
> MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.inf | 2 +-
> MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf | 2 +-
> .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.inf | 2 +-
> .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf | 2 +-
> MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf | 2 +-
> MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf | 2 +-
> .../Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf | 2 +-
> .../UsbMouseAbsolutePointerDxe.inf | 2 +-
> MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf | 2 +-
> MdeModulePkg/Core/Dxe/DxeMain.inf | 2 +-
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 5 +-
> MdeModulePkg/Core/DxeIplPeim/Ipf/DxeLoadFunc.c | 85 --
> MdeModulePkg/Core/Pei/PeiMain.inf | 2 +-
> MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf | 4 +-
> MdeModulePkg/Include/Guid/VariableFormat.h | 5 -
> .../BasePlatformHookLibNull.inf | 2 +-
> .../BaseResetSystemLibNull.inf | 2 +-
> MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 2 +-
> MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 2 +-
> .../BootMaintenanceManagerUiLib.inf | 2 +-
> .../Library/BootManagerUiLib/BootManagerUiLib.inf | 2 +-
> .../CpuExceptionHandlerLibNull.inf | 2 +-
> .../CustomizedDisplayLib/CustomizedDisplayLib.inf | 4 +-
> .../DebugAgentLibNull/DebugAgentLibNull.inf | 2 +-
> .../DeviceManagerUiLib/DeviceManagerUiLib.inf | 2 +-
> .../DisplayUpdateProgressLibGraphics.inf | 2 +-
> .../DisplayUpdateProgressLibText.inf | 2 +-
> .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 2 +-
> .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 2 +-
> .../DxeCapsuleLibNull/DxeCapsuleLibNull.inf | 2 +-
> .../DxeCoreMemoryAllocationLib.inf | 2 +-
> .../DxeCoreMemoryAllocationProfileLib.inf | 2 +-
> .../DxeCorePerformanceLib.inf | 2 +-
> .../DxeCrc32GuidedSectionExtractLib.inf | 4 +-
> .../DxeDebugPrintErrorLevelLib.inf | 4 +-
> MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf | 4 +-
> .../DxeFileExplorerProtocol.inf | 4 +-
> MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf | 6 +-
> MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf | 4 +-
> MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf | 6 +-
> .../DxePerformanceLib/DxePerformanceLib.inf | 4 +-
> .../DxePrintLibPrint2Protocol.inf | 2 +-
> .../DxeReportStatusCodeLib.inf | 4 +-
> .../DxeResetSystemLib/DxeResetSystemLib.inf | 2 +-
> .../DxeSecurityManagementLib.inf | 4 +-
> MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf | 4 +-
> MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf | 4 +-
> .../Library/FileExplorerLib/FileExplorerLib.inf | 4 +-
> .../FmpAuthenticationLibNull.inf | 2 +-
> .../LzmaCustomDecompressLib.inf | 2 +-
> .../OemHookStatusCodeLibNull.inf | 4 +-
> .../PciHostBridgeLibNull/PciHostBridgeLibNull.inf | 2 +-
> .../PeiCrc32GuidedSectionExtractLib.inf | 2 +-
> .../PeiDxeDebugLibReportStatusCode.inf | 4 +-
> .../PeiPerformanceLib/PeiPerformanceLib.inf | 2 +-
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 2 +-
> .../PeiReportStatusCodeLib.inf | 2 +-
> .../PeiResetSystemLib/PeiResetSystemLib.inf | 2 +-
> MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf | 2 +-
> .../PiDxeS3BootScriptLib/DxeS3BootScriptLib.inf | 4 +-
> .../PlatformHookLibSerialPortPpi.inf | 4 +-
> .../PlatformVarCleanupLib.inf | 2 +-
> .../RuntimeDxeReportStatusCodeLib.inf | 4 +-
> .../TpmMeasurementLibNull.inf | 4 +-
> .../UefiBootManagerLib/UefiBootManagerLib.inf | 2 +-
> MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf | 4 +-
> .../UefiHiiServicesLib/UefiHiiServicesLib.inf | 4 +-
> .../UefiMemoryAllocationProfileLib.inf | 6 +-
> MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf | 2 +-
> MdeModulePkg/Logo/Logo.inf | 2 +-
> MdeModulePkg/MdeModulePkg.dsc | 28 +-
> .../Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
> .../Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf | 2 +-
> .../BootGraphicsResourceTableDxe.inf | 2 +-
> .../FirmwarePerformanceDxe.inf | 2 +-
> .../FirmwarePerformancePei.inf | 2 +-
> .../Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 4 +-
> .../Acpi/SmmS3SaveState/SmmS3SaveState.inf | 2 +-
> MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 2 +-
> .../BootManagerPolicyDxe/BootManagerPolicyDxe.inf | 2 +-
> MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 2 +-
> .../CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 4 +-
> .../Console/ConPlatformDxe/ConPlatformDxe.inf | 4 +-
> .../Console/ConSplitterDxe/ConSplitterDxe.inf | 2 +-
> .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 +-
> .../Universal/Console/TerminalDxe/TerminalDxe.inf | 2 +-
> .../Universal/DebugPortDxe/DebugPortDxe.inf | 2 +-
> .../Universal/DebugSupportDxe/DebugSupportDxe.inf | 10 +-
> .../Universal/DebugSupportDxe/Ipf/AsmFuncs.s | 1382 --------------------
> .../Universal/DebugSupportDxe/Ipf/Common.i | 29 -
> .../Universal/DebugSupportDxe/Ipf/Ds64Macros.i | 78 --
> .../Universal/DebugSupportDxe/Ipf/PlDebugSupport.c | 467 -------
> .../Universal/DebugSupportDxe/Ipf/PlDebugSupport.h | 324 -----
> .../Universal/DevicePathDxe/DevicePathDxe.inf | 2 +-
> .../Universal/Disk/CdExpressPei/CdExpressPei.inf | 2 +-
> .../Universal/Disk/DiskIoDxe/DiskIoDxe.inf | 2 +-
> .../Universal/Disk/PartitionDxe/PartitionDxe.inf | 2 +-
> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf | 2 +-
> .../UnicodeCollation/EnglishDxe/EnglishDxe.inf | 2 +-
> .../DisplayEngineDxe/DisplayEngineDxe.inf | 2 +-
> .../DriverHealthManagerDxe.inf | 2 +-
> .../Universal/DriverSampleDxe/DriverSampleDxe.inf | 2 +-
> MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 7 +-
> .../Universal/EbcDxe/EbcDebuggerConfig.inf | 2 +-
> MdeModulePkg/Universal/EbcDxe/EbcDxe.inf | 7 +-
> MdeModulePkg/Universal/EbcDxe/Ipf/EbcLowLevel.s | 206 ---
> MdeModulePkg/Universal/EbcDxe/Ipf/EbcSupport.c | 884 -------------
> MdeModulePkg/Universal/EbcDxe/Ipf/EbcSupport.h | 41 -
> MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 2 +-
> .../FaultTolerantWriteDxe.inf | 2 +-
> .../FaultTolerantWritePei.inf | 2 +-
> .../Universal/FileExplorerDxe/FileExplorerDxe.inf | 2 +-
> .../Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 2 +-
> .../HiiResourcesSampleDxe.inf | 2 +-
> .../LegacyRegion2Dxe/LegacyRegion2Dxe.inf | 2 +-
> .../Universal/LoadFileOnFv2/LoadFileOnFv2.inf | 2 +-
> .../GenericMemoryTestDxe/GenericMemoryTestDxe.inf | 2 +-
> .../NullMemoryTestDxe/NullMemoryTestDxe.inf | 2 +-
> MdeModulePkg/Universal/Metronome/Metronome.inf | 2 +-
> .../MonotonicCounterRuntimeDxe.inf | 2 +-
> MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf | 2 +-
> .../Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf | 2 +-
> MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf | 2 +-
> .../Universal/Network/IScsiDxe/IScsiDxe.inf | 4 +-
> MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf | 2 +-
> MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf | 2 +-
> .../Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf | 2 +-
> MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf | 2 +-
> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 2 +-
> MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf | 2 +-
> .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 2 +-
> .../Network/VlanConfigDxe/VlanConfigDxe.inf | 2 +-
> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf | 2 +-
> MdeModulePkg/Universal/PCD/Pei/Pcd.inf | 2 +-
> .../PcatSingleSegmentPciCfg2Pei.inf | 2 +-
> .../PlatformDriOverrideDxe.inf | 2 +-
> MdeModulePkg/Universal/PrintDxe/PrintDxe.inf | 2 +-
> .../PropertiesTableAttributesDxe.inf | 2 +-
> .../RegularExpressionDxe/RegularExpressionDxe.inf | 2 -
> .../Pei/ReportStatusCodeRouterPei.inf | 2 +-
> .../ReportStatusCodeRouterRuntimeDxe.inf | 2 +-
> .../SectionExtractionPei/SectionExtractionPei.inf | 2 +-
> .../Universal/SecurityStubDxe/SecurityStubDxe.inf | 2 +-
> .../Universal/SetupBrowserDxe/SetupBrowserDxe.inf | 2 +-
> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf | 2 +-
> .../SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf | 2 +-
> .../StatusCodeHandler/Pei/StatusCodeHandlerPei.inf | 2 +-
> .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf | 2 +-
> .../Universal/TimestampDxe/TimestampDxe.inf | 2 +-
> .../Universal/Variable/Pei/VariablePei.inf | 2 +-
> .../Universal/WatchdogTimerDxe/WatchdogTimer.inf | 4 +-
> 186 files changed, 213 insertions(+), 3759 deletions(-)
> delete mode 100644 MdeModulePkg/Core/DxeIplPeim/Ipf/DxeLoadFunc.c
> delete mode 100644 MdeModulePkg/Universal/DebugSupportDxe/Ipf/AsmFuncs.s
> delete mode 100644 MdeModulePkg/Universal/DebugSupportDxe/Ipf/Common.i
> delete mode 100644 MdeModulePkg/Universal/DebugSupportDxe/Ipf/Ds64Macros.i
> delete mode 100644 MdeModulePkg/Universal/DebugSupportDxe/Ipf/PlDebugSupport.c
> delete mode 100644 MdeModulePkg/Universal/DebugSupportDxe/Ipf/PlDebugSupport.h
> delete mode 100644 MdeModulePkg/Universal/EbcDxe/Ipf/EbcLowLevel.s
> delete mode 100644 MdeModulePkg/Universal/EbcDxe/Ipf/EbcSupport.c
> delete mode 100644 MdeModulePkg/Universal/EbcDxe/Ipf/EbcSupport.h
>
next prev parent reply other threads:[~2018-06-13 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 3:44 [PATCH 20/37] MdeModulePkg: Removing ipf which is no longer supported from edk2 chenc2
2018-06-13 12:40 ` Ard Biesheuvel [this message]
2018-06-14 0:59 ` Zeng, Star
2018-06-14 4:06 ` Gao, Liming
2018-06-14 0:55 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu97v67jOWAmG-H4PvtSqVaW+Cb4vr27m9bX6BhXZjj_Jw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox