Re: [PATCH] ArmVirtPkg: switch to generic ResetSystemRuntimeDxe

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 3 July 2017 at 18:44, Laszlo Ersek <lersek@redhat.com> wrote:
> On 07/03/17 15:53, Ard Biesheuvel wrote:
>> For obscure reasons, ARM platforms use a different implementation of
>> the ResetSystem() runtime service call than other platforms. So let's
>> switch all ArmVirtPkg platforms to the generic version instead.
>>
>> Given that all platforms use an implementation of EfiResetSystemLib [as
>> consumed by the ResetRuntimeDxe in EmbeddedPkg that we are replacing]
>> which is unlikely to be depended upon by out of tree platforms, let's
>> simply modify this library into an implementation of ResetSystemLib
>> instead [which is what the generic driver in MdeModulePkg consumes]
>>
>> This does mean we need to update all clients at the same time, which
>> is why all changes are part of the same patch.
>>
>> As before, warm reset and platform specific reset are mapped onto
>> cold reset (which is the only thing PSCI implements, at least the
>> version we depend on). The new library function EnterS3WithImmediateWake()
>> is left unimplemented, as permitted by the ResetSystemLib library class.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> Note: this a no-whitespace diff
>>
>>  ArmVirtPkg/ArmVirt.dsc.inc                                                 |   2 +-
>>  ArmVirtPkg/ArmVirtQemu.dsc                                                 |   2 +-
>>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc                                       |   2 +-
>>  ArmVirtPkg/ArmVirtQemuKernel.dsc                                           |   2 +-
>>  ArmVirtPkg/ArmVirtXen.dsc                                                  |   2 +-
>>  ArmVirtPkg/ArmVirtXen.fdf                                                  |   2 +-
>>  ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c   | 125 +++++++++++++-------
>>  ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.inf |   4 +-
>>  8 files changed, 89 insertions(+), 52 deletions(-)
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>

Thanks guys

Pushed as 7b1dc6c569a8