From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C9E6121CF3B64 for ; Mon, 3 Jul 2017 10:49:23 -0700 (PDT) Received: by mail-it0-x229.google.com with SMTP id m68so91173708ith.1 for ; Mon, 03 Jul 2017 10:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dnNNEDuUTGpiKQl7R9/vzm1hRXx3ZyyK24W3vcD2PkQ=; b=YcjK1AWrbYJOGIkTFqLm+4onNnuU/j9wsW1zxLDe6t8fm4eJqyNArsJ9iI72Q7c2G/ cZ4yn4lJuIFi2qrRcbNeRan3SrWvdo5QSAaJeBTRuQjYg5dIqpHOZMGCqqC6LIYLvXwS lI1kgyQLdxvnuSZ6rZnAIPrsNGJd/mkwNO7j0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dnNNEDuUTGpiKQl7R9/vzm1hRXx3ZyyK24W3vcD2PkQ=; b=jEgEmJC5xtVFmr41HD6vbpPNMSjOgEdzMKOY9teZwP1/ccGNgQ1H8HBX19Slu0KKBo aBRbB/1OCAw/reGLmmU2t9pVgj+usrkeNvsipuRCrlGpnzWaYZ3DjddD32I1ec/xz5Mn ylUcKWuNRg+rcKV5PFe+fE2B8n48ztOXTNg7w4wHSgled252ctuuTWeFjqdMyGpj5fTb n82WIGqbILprS7TfwO+G+lYf1ah5qyrKDR7r9oN4pYFJGnym8sbn0ReCtoP0jiPkbUZA IRqalwsBjDyK63xs7EIW5PhHKWck+VGTa3/IB14lUoqTOglCnD96xvGVzuagV3VM4RNh LQ6w== X-Gm-Message-State: AIVw113016641jaR5XTEUYMhyfY0FRm3eg0ZY/4xTAkwB75+t/L4cXCS PWLpmX4O9HogmmyarKwTitz9iyAHujPA2BauYg== X-Received: by 10.36.181.16 with SMTP id v16mr10217582ite.6.1499104260603; Mon, 03 Jul 2017 10:51:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.134.134 with HTTP; Mon, 3 Jul 2017 10:51:00 -0700 (PDT) In-Reply-To: References: <20170703135345.28703-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Mon, 3 Jul 2017 18:51:00 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH] ArmVirtPkg: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 17:49:24 -0000 Content-Type: text/plain; charset="UTF-8" On 3 July 2017 at 18:44, Laszlo Ersek wrote: > On 07/03/17 15:53, Ard Biesheuvel wrote: >> For obscure reasons, ARM platforms use a different implementation of >> the ResetSystem() runtime service call than other platforms. So let's >> switch all ArmVirtPkg platforms to the generic version instead. >> >> Given that all platforms use an implementation of EfiResetSystemLib [as >> consumed by the ResetRuntimeDxe in EmbeddedPkg that we are replacing] >> which is unlikely to be depended upon by out of tree platforms, let's >> simply modify this library into an implementation of ResetSystemLib >> instead [which is what the generic driver in MdeModulePkg consumes] >> >> This does mean we need to update all clients at the same time, which >> is why all changes are part of the same patch. >> >> As before, warm reset and platform specific reset are mapped onto >> cold reset (which is the only thing PSCI implements, at least the >> version we depend on). The new library function EnterS3WithImmediateWake() >> is left unimplemented, as permitted by the ResetSystemLib library class. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> Note: this a no-whitespace diff >> >> ArmVirtPkg/ArmVirt.dsc.inc | 2 +- >> ArmVirtPkg/ArmVirtQemu.dsc | 2 +- >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- >> ArmVirtPkg/ArmVirtXen.dsc | 2 +- >> ArmVirtPkg/ArmVirtXen.fdf | 2 +- >> ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.c | 125 +++++++++++++------- >> ArmVirtPkg/Library/ArmVirtPsciResetSystemLib/ArmVirtPsciResetSystemLib.inf | 4 +- >> 8 files changed, 89 insertions(+), 52 deletions(-) > > Reviewed-by: Laszlo Ersek > Thanks guys Pushed as 7b1dc6c569a8