Re: [PATCH] BaseTools/EfiRom: supply missing machine type lookup strings

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 8 September 2016 at 20:55, Laszlo Ersek <lersek@redhat.com> wrote:
> "EfiRom --dump" does not recognize the 0x8664 machine type:
>
>>   EFI ROM header contents
>>     EFI Signature          0x0EF1
>>     Compression Type       0x0001 (compressed)
>>     Machine type           0x8664 (unknown)
>>     Subsystem              0x000B (EFI boot service driver)
>>     EFI image offset       0x0050 (@0xF650)
>
> Add lookup strings for the remaining EFI_IMAGE_MACHINE_* numeric macros
> that can be found in
> "BaseTools/Source/C/Include/IndustryStandard/PeImage.h".
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  BaseTools/Source/C/EfiRom/EfiRom.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/BaseTools/Source/C/EfiRom/EfiRom.h b/BaseTools/Source/C/EfiRom/EfiRom.h
> index 1214700826de..461963b4a701 100644
> --- a/BaseTools/Source/C/EfiRom/EfiRom.h
> +++ b/BaseTools/Source/C/EfiRom/EfiRom.h
> @@ -117,6 +117,9 @@ static STRING_LOOKUP  mMachineTypes[] = {
>    { EFI_IMAGE_MACHINE_IA32, "IA32" },
>    { EFI_IMAGE_MACHINE_IA64, "IA64" },
>    { EFI_IMAGE_MACHINE_EBC, "EBC" },
> +  { EFI_IMAGE_MACHINE_X64, "X64" },
> +  { EFI_IMAGE_MACHINE_ARMT, "ARMT" },

Just 'ARM', please? PE/COFF has multiple machine types for ARM, but
EFI only uses this one for ARM (0x1c2)

With that change,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks,
Ard.