From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4CD591A1E69 for ; Thu, 8 Sep 2016 13:39:31 -0700 (PDT) Received: by mail-it0-x236.google.com with SMTP id c198so101605352ith.1 for ; Thu, 08 Sep 2016 13:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qod1Iggg9NTnBohyczD4o4WXjXapGCPoHxNfw4xMrPQ=; b=HGsPE7dgI9jvyL4qMaAuBFcGr0yqtHSF99Q+43n1VcKl0oZeUY7ZUHj34ZWetfSL3Z 7JHB0wUKwlYHyPbW1bhS0OB605877F2QdspxtnIz1/Igfr51759UxZlXJWsTPcxde7y9 2FI3JBPm43o+wP7VgMGenEfswS7VQWFsSn3gY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qod1Iggg9NTnBohyczD4o4WXjXapGCPoHxNfw4xMrPQ=; b=dMC3dFI3khJ8cR4H0BvziVUn3uK51DvZCQLWPnhsYNieycEm4OqYvbXi0h2CSk6LtI sgxGb4Ul4P96kpioFKUPP0gAIgKnXDiGeuOoYZQdRQVV7G/9JcjFWI1PRYRflqUin1il NvEdkNmUZLpX45bJg8udDYXf5wum2+0ST/iGk9c2ZDNW5zl0dTKmJO8wiRbglGxNmcK9 dMgOYmvBZt4wMRZSUAg1KsIDADWSJWIfVJdOAdkZhXYH4Wb5XTV3GQGhQyeCAcry/Qua AEJ1SSSr/ZM0fdohgT1hXejKXXa6TJB/UqjawNBdC1zt9H+CqMAdP8WMxg+LtNh6NTKB 1NxA== X-Gm-Message-State: AE9vXwNxxoKFLX2+DoB7mH6mSdn/8DHwdimRFI6UQVquyEtoqaxKZb1DP+ZaGvsTpCY1Bl56HnXz/a50CIHRhETJ X-Received: by 10.157.13.13 with SMTP id 13mr1951342oti.193.1473367170588; Thu, 08 Sep 2016 13:39:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 8 Sep 2016 13:39:30 -0700 (PDT) In-Reply-To: <20160908195536.4452-1-lersek@redhat.com> References: <20160908195536.4452-1-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 8 Sep 2016 21:39:30 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Liming Gao Subject: Re: [PATCH] BaseTools/EfiRom: supply missing machine type lookup strings X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 20:39:31 -0000 Content-Type: text/plain; charset=UTF-8 On 8 September 2016 at 20:55, Laszlo Ersek wrote: > "EfiRom --dump" does not recognize the 0x8664 machine type: > >> EFI ROM header contents >> EFI Signature 0x0EF1 >> Compression Type 0x0001 (compressed) >> Machine type 0x8664 (unknown) >> Subsystem 0x000B (EFI boot service driver) >> EFI image offset 0x0050 (@0xF650) > > Add lookup strings for the remaining EFI_IMAGE_MACHINE_* numeric macros > that can be found in > "BaseTools/Source/C/Include/IndustryStandard/PeImage.h". > > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > BaseTools/Source/C/EfiRom/EfiRom.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/BaseTools/Source/C/EfiRom/EfiRom.h b/BaseTools/Source/C/EfiRom/EfiRom.h > index 1214700826de..461963b4a701 100644 > --- a/BaseTools/Source/C/EfiRom/EfiRom.h > +++ b/BaseTools/Source/C/EfiRom/EfiRom.h > @@ -117,6 +117,9 @@ static STRING_LOOKUP mMachineTypes[] = { > { EFI_IMAGE_MACHINE_IA32, "IA32" }, > { EFI_IMAGE_MACHINE_IA64, "IA64" }, > { EFI_IMAGE_MACHINE_EBC, "EBC" }, > + { EFI_IMAGE_MACHINE_X64, "X64" }, > + { EFI_IMAGE_MACHINE_ARMT, "ARMT" }, Just 'ARM', please? PE/COFF has multiple machine types for ARM, but EFI only uses this one for ARM (0x1c2) With that change, Reviewed-by: Ard Biesheuvel Thanks, Ard.