From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Jeff Brasen <jbrasen@nvidia.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400
Date: Sat, 8 Feb 2020 11:56:37 +0000 [thread overview]
Message-ID: <CAKv+Gu98c0WhexzK6=dPKfuKX57urdz8cNmVhdpbMj9eg2qfng@mail.gmail.com> (raw)
In-Reply-To: <62e4d256aa2ceaa2633293325a664069b854ae8b.1581110894.git.jbrasen@nvidia.com>
On Fri, 7 Feb 2020 at 21:32, Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> Increase length of path that can be read from system from 200 to 400 to
> allow for longer build paths.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
Thanks Jeff
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed to EDK2 master
> ---
> ArmPlatformPkg/Scripts/Ds5/firmware_volume.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> index 9c06835776..c6d1ca830a 100644
> --- a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> +++ b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> @@ -81,7 +81,7 @@ class EfiSectionTE:
> filename = self.base_te + debug_rva + 0xc
> else:
> filename = self.base_te + debug_rva + 0x10
> - filename = struct.unpack("200s", self.ec.getMemoryService().read(filename, 200, 32))[0]
> + filename = struct.unpack("400s", self.ec.getMemoryService().read(filename, 400, 32))[0]
> return filename[0:string.find(filename,'\0')]
>
> def get_debug_elfbase(self):
> @@ -119,7 +119,7 @@ class EfiSectionPE32:
> filename = self.base_pe32 + debug_rva + 0xc
> else:
> filename = self.base_pe32 + debug_rva + 0x10
> - filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> + filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
> return filename[0:string.find(filename,'\0')]
>
> def get_debug_elfbase(self):
> @@ -154,7 +154,7 @@ class EfiSectionPE64:
> filename = self.base_pe64 + debug_rva + 0xc
> else:
> filename = self.base_pe64 + debug_rva + 0x10
> - filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> + filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
> return filename[0:string.find(filename,'\0')]
>
> def get_debug_elfbase(self):
> --
> 2.17.1
>
prev parent reply other threads:[~2020-02-08 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 21:32 [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400 Jeff Brasen
2020-02-08 11:56 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu98c0WhexzK6=dPKfuKX57urdz8cNmVhdpbMj9eg2qfng@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox