From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66])
 by mx.groups.io with SMTP id smtpd.web12.3832.1581163009881809681
 for <devel@edk2.groups.io>;
 Sat, 08 Feb 2020 03:56:50 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=O/xhm0+E;
 spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f66.google.com with SMTP id w12so1948310wrt.2
        for <devel@edk2.groups.io>; Sat, 08 Feb 2020 03:56:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=0upDoDODGpfynSrbftO4g0jUDGtI3/et0LCGQIQOxAE=;
        b=O/xhm0+EUWXLqGKQ6+EQAy7iBtd8mv2wx7tjQ5gybUd6jmA+9N9wdXtfPoeMotpizr
         E2Q0LxppMBEDE3OljRPX52AdHr3YITE8/P5xw1b9fXMf6eXdOCJqUxspl+/Chr/2aIRw
         LpnSTHb3L/hBP0jEQa8lu1QknLCcBBIPGDM/+cqSkKfx1IIu7NTJwWiLcHlznBSxYZOf
         I+SoWHxs5r53fjIOb/BB65PvPT/CtQs3jc8KH4W+VILpcLuveIEKrB6a5ljloLEhhd/0
         RgZDLrrfoKS82onfmYSgy4wNKWTen7egHeNq+iGLxSR9QIlpRSSjs64uHSkm5Fk8GtwS
         DUqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=0upDoDODGpfynSrbftO4g0jUDGtI3/et0LCGQIQOxAE=;
        b=lUk15RqHM4AqaO9aZkPOt8l09KrL0WGtztG22Xf19brg4zT4L96KagtIqimqOn2//c
         +x+09NU5TrNs9gAWvbxB8aNYTCtd9OIouQ2MZle4jkwZxZr7qMfCd9RTJfbXNO98DcwP
         UdQnsM/lgCOUWKXzE/bVgE5n4uD9Qrb8iPPfojGYN72uaf4S1dMvxiarLzgeYgxJ47IM
         N004k+r6IoX/KFQNwWggrEJPna01p5SsLeCoCSjfQUWAC+AcUekzBPVa/7g69Co5BRTc
         f0+QFjxQ89mCEO7g5Ei4zHYyAmldhS7dyRli4cS6X5uvLZbxGeFjuNurtZ96yBhigtjN
         vgLA==
X-Gm-Message-State: APjAAAXVusswjMw3pMZCDry9erWF40ELY//5q0q41NuBEhhVK0b6ayZS
	Z2niTjqA6//CfY4u2rQ5vITp81YPyIxaGPSrANKtyg==
X-Google-Smtp-Source: APXvYqyMvfrUGIqwLGLhjyt859zc224JI/Ii/1QWsFeGoEBTMvcTf8Zca1nZXDIQ+gt7mIUJoqL9x3ffYhiufg8K5V4=
X-Received: by 2002:a5d:65cf:: with SMTP id e15mr5085920wrw.126.1581163008295;
 Sat, 08 Feb 2020 03:56:48 -0800 (PST)
MIME-Version: 1.0
References: <62e4d256aa2ceaa2633293325a664069b854ae8b.1581110894.git.jbrasen@nvidia.com>
In-Reply-To: <62e4d256aa2ceaa2633293325a664069b854ae8b.1581110894.git.jbrasen@nvidia.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Sat, 8 Feb 2020 11:56:37 +0000
Message-ID: <CAKv+Gu98c0WhexzK6=dPKfuKX57urdz8cNmVhdpbMj9eg2qfng@mail.gmail.com>
Subject: Re: [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400
To: Jeff Brasen <jbrasen@nvidia.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 7 Feb 2020 at 21:32, Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> Increase length of path that can be read from system from 200 to 400 to
> allow for longer build paths.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>

Thanks Jeff

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed to EDK2 master


> ---
>  ArmPlatformPkg/Scripts/Ds5/firmware_volume.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> index 9c06835776..c6d1ca830a 100644
> --- a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> +++ b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> @@ -81,7 +81,7 @@ class EfiSectionTE:
>              filename = self.base_te + debug_rva + 0xc
>          else:
>              filename = self.base_te + debug_rva + 0x10
> -        filename = struct.unpack("200s", self.ec.getMemoryService().read(filename, 200, 32))[0]
> +        filename = struct.unpack("400s", self.ec.getMemoryService().read(filename, 400, 32))[0]
>          return filename[0:string.find(filename,'\0')]
>
>      def get_debug_elfbase(self):
> @@ -119,7 +119,7 @@ class EfiSectionPE32:
>              filename = self.base_pe32 + debug_rva + 0xc
>          else:
>              filename = self.base_pe32 + debug_rva + 0x10
> -        filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> +        filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
>          return filename[0:string.find(filename,'\0')]
>
>      def get_debug_elfbase(self):
> @@ -154,7 +154,7 @@ class EfiSectionPE64:
>              filename = self.base_pe64 + debug_rva + 0xc
>          else:
>              filename = self.base_pe64 + debug_rva + 0x10
> -        filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> +        filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
>          return filename[0:string.find(filename,'\0')]
>
>      def get_debug_elfbase(self):
> --
> 2.17.1
>