From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 545F32119683B for ; Thu, 7 Jun 2018 04:12:00 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id d185-v6so11349545ioe.0 for ; Thu, 07 Jun 2018 04:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fSJnhbeos5yRa6dXHhwo6EIb1oUoVmP9NPgD3e940dU=; b=IyyUX5P2oxgaEQZW32yJh4eHlI8oUSC9KiUZ/TFZ+3ye5IEAcF6i7uLJT0BR9OdDSE ICLT8xavpEQ/dsR1ZuzD+WUKTh1jsaACewV0G3He6B6nJY+3KOXaT0r7HwxfvroMBGpI E1sX5Zw7za0rzWGkB+bpepZLAb0Z6x3rFOqPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fSJnhbeos5yRa6dXHhwo6EIb1oUoVmP9NPgD3e940dU=; b=qRVSn3CRRD9/5M6O+2kWH6HtnHNIiETXRMCwGBCPl5oh98zlKCj+k36nWVoVL9WnMG Zyvrk6HAOz4wD45cWnHkgLqNND0vPrWJHEMbY4atEGWYAREVNYJCEl9b9A+ePryHGmFo Is3dr+khmVQqUiMsqjIN4Tr+rlSfo2+wPENeGOfkE6KDVjRCMLzAwae1UkhHVIvopB3Q Hdoet0A2F1JFh6u3YlhkKS0flwyjiLzTmfwjks22yb/TAmwfWAGWjeijnhTWoz9oqiQh ktN9D9J4EWSWgVc6huWo+uWsd1O+t+2CVWIzIoGrj4t62wCdFxhR6geDwGhjN4EMCZIy hDhg== X-Gm-Message-State: APt69E0VdHxcUzGDYFAh+FcDgj+w+OGXk8CmLC4HL/2CNdnZNJYwYslG WfRRooXmPPYpdaB1nSdLph9AB+8NkzsyHW1zKtFMyw== X-Google-Smtp-Source: ADUXVKLC0ulxZsz5uV2V7RdMHl/kVsxKq0GyqCjt+x3lHX80OBQ6eVK4hZaE6ESporm6iKG21112mk1r8PxSMxUQ7Zs= X-Received: by 2002:a6b:4014:: with SMTP id k20-v6mr1010130ioa.277.1528369919611; Thu, 07 Jun 2018 04:11:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Thu, 7 Jun 2018 04:11:59 -0700 (PDT) In-Reply-To: <20180417012044.GA123329@SZX1000114654> References: <1521594198-52523-1-git-send-email-heyi.guo@linaro.org> <20180328010531.GA69547@SZX1000114654> <20180329002050.GB97590@SZX1000114654> <20180331013747.GA106704@SZX1000114654> <20180413020553.GB119834@SZX1000114654> <20180416135709.GA122959@SZX1000114654> <20180417012044.GA123329@SZX1000114654> From: Ard Biesheuvel Date: Thu, 7 Jun 2018 13:11:59 +0200 Message-ID: To: Guo Heyi Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Michael D Kinney , Haojian Zhuang Subject: Re: [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 11:12:00 -0000 Content-Type: text/plain; charset="UTF-8" On 17 April 2018 at 03:20, Guo Heyi wrote: > Hi Ard, > > I tested mm -io on D05, for root bridge 4 with CPU IO address starting from > 0x8_abff0000, and it worked; both mm -io 0x8abff0000 and mm 0x8abff0000 provided > the same output. It seems there is no other limit for 64bit IO address after you > fixed the issue in EFI shell mm command. > OK, so I think this is fine after all, even if my uneasy feeling hasn't gone away :-) Could you please resend the latest rebased version of the patches? (and include the ATU fix as well) > On Mon, Apr 16, 2018 at 09:57:09PM +0800, Guo Heyi wrote: >> Thanks, I will test mm command and let you know the result. >> >> Regards, >> >> Heyi >> >> On Fri, Apr 13, 2018 at 09:19:53AM +0200, Ard Biesheuvel wrote: >> > On 13 April 2018 at 04:05, Guo Heyi wrote: >> > > Hi Ard, >> > > >> > > Any comments? >> > > >> > >> > Apologies for the delay. I have been travelling and am behind on email. >> > >> > > Anyway we can modify the code if you insist on using an intermediate CPU IO >> > > address space. >> > > >> > >> > I have not made up my mind yet, to be honest. I agree there is a >> > certain elegance to merging both translations, but I am concerned that >> > existing EDK2 code may deal poorly with I/O addresses that require >> > more than 32 bits to express. >> > >> > Did you try the mm command in the shell for instance? As you know, I >> > recently removed an artificial address range limit there, but I wonder >> > if it uses 64-bit variables for I/O ports.