From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::233; helo=mail-io0-x233.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D357224A9EAB for ; Fri, 30 Mar 2018 08:40:21 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id x77so5180052ioi.2 for ; Fri, 30 Mar 2018 08:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JRg1PY02m9t8HSRlJ6enQXjWDBX00DXb0NDN3miczBY=; b=SOD9sOWm9tcxKzv7grbjYMtCc+fxEw687J74FEm0zi+oLHzfWJzHqEHFf/Q/jLkBK8 oV/Bwr1H12NJgD/YPXLucq4HjlH6RHAKzJkf0XA814gHB27TB5nhIr8sy5L12UAoR13R 8wm9zrjTGA1PJFjIaASzziPHq2urkzngvTGPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JRg1PY02m9t8HSRlJ6enQXjWDBX00DXb0NDN3miczBY=; b=NiXv8XuWKtJQdjBeQRIVTyfQejeQdWJ2u6pOvaKlYEsbEkQJxB5m1AVleg/zZiRENh oMfiIimu+ogRN4yI61XRNOQrdYx1lbaMRu8iiBmweErGgSCbpsJuUF77aJ5KtWxGLs0F +pTgShKbzdxjqxXihA3SAA8r9FiHP702FViMQoZUkKdoi80rhHILWUKXQnHJOsE0w5Hh vxSu9fzzx7s+LhSS4a9wVagKFtsa+ZLcWjk3Bnvt7aVkCnvF1bY/uLtthH2BGzCV8PUt y51oOIUSKCCR9dNgkmMc8/BcRtfvT0/Y/biWzz01A10Gea8bRd8hn/1EdOjyCGyXoIRR zIag== X-Gm-Message-State: AElRT7Fl+wqp5o6PnvetG1v9gqmPnJ29EaxCyac2IYX2/RldOoLXfUby Gt7Q9XK1JBmrtp9qgK8iGpwYwhZCJAv6gh1KRan+Jw== X-Google-Smtp-Source: AG47ELt27EDcqBO7Jd8IunB54HEfrTgBnyPiIKUPBMZqMSOtX3m6ZEvgT3Mslc7h240jA//NJZZpUKc3tmM+Dryx3V4= X-Received: by 10.107.151.13 with SMTP id z13mr47559887iod.277.1522424421177; Fri, 30 Mar 2018 08:40:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 30 Mar 2018 08:40:20 -0700 (PDT) In-Reply-To: <20180329002050.GB97590@SZX1000114654> References: <1521594198-52523-1-git-send-email-heyi.guo@linaro.org> <20180328010531.GA69547@SZX1000114654> <20180329002050.GB97590@SZX1000114654> From: Ard Biesheuvel Date: Fri, 30 Mar 2018 17:40:20 +0200 Message-ID: To: Guo Heyi Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Michael D Kinney , Haojian Zhuang Subject: Re: [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 15:40:22 -0000 Content-Type: text/plain; charset="UTF-8" On 29 March 2018 at 02:20, Guo Heyi wrote: > On Wed, Mar 28, 2018 at 10:43:41AM +0100, Ard Biesheuvel wrote: >> On 28 March 2018 at 02:05, Guo Heyi wrote: >> > Hi Leif, Ard, >> > >> > Any comments for this series of patches? >> > >> >> Hello Heyi, >> >> Thanks for sending these patches. Leif is at the plugfest, but I will >> look at these before the end of the week. > > Forgot the plugfest as I am not attending :) Hello Heyi, I think the series looks mostly fine in general, but there are two things that I'd like you to change (as noted in my replies): - please split the PCI to CPU I/O translation from the CPU I/O to CPU MMIO translation - please fix the APPETURE spelling (in whichever way is most convenient for you: separate patch at the beginning, at the end, etc etc)