Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Sat, 20 Apr 2019 at 13:28, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Sat, 20 Apr 2019 at 00:38, rebecca via Groups.Io
> <rebecca=bluestop.org@groups.io> wrote:
> >
> > When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c
> > calls issetugid(). Add the declaration of this function to
> > CrtLibSupport.h to avoid the need to patch the openssl code on these
> > platforms.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
>
> This is slightly odd. The host architecture shouldn't really matter,
> and so if we end up calling different code in UEFI when built on *BSD,
> there is differently something wrong. Or am I missing something?
>

*definitely

> > ---
> >  CryptoPkg/Library/Include/CrtLibSupport.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
> > index a241fb96fb..b05c5d908c 100644
> > --- a/CryptoPkg/Library/Include/CrtLibSupport.h
> > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h
> > @@ -155,6 +155,7 @@ uid_t          getuid      (void);
> >  uid_t          geteuid     (void);
> >  gid_t          getgid      (void);
> >  gid_t          getegid     (void);
> > +int            issetugid   (void);
> >  void           qsort       (void *, size_t, size_t, int (*)(const void *, const void *));
> >  char           *getenv     (const char *);
> >  char           *secure_getenv (const char *);
> > --
> > 2.21.0
> >
> >
> > ------------
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#39338): https://edk2.groups.io/g/devel/message/39338
> > Mute This Topic: https://groups.io/mt/31250604/1761188
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub  [ard.biesheuvel@linaro.org]
> > ------------
> >