From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=vHNz6t9p; spf=pass (domain: linaro.org, ip: 209.85.166.195, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) by groups.io with SMTP; Sat, 20 Apr 2019 04:30:30 -0700 Received: by mail-it1-f195.google.com with SMTP id x132so11851459itf.2 for ; Sat, 20 Apr 2019 04:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FzLKvtXsIMMGy8apCGuqdlRUn0uKWGPaM6gTC5o3IMo=; b=vHNz6t9pKUY9ioarA4s/DyYJXqU6B15Bn99mZZBMNVrmAPk1x8WMkPWKKUWLIWJm1l vOxX6vma4574iYGrrbrrwedvcjjs15nmMQ6LnauGi1ZlEPeObqVPuyNq+W34PvVh4AvO 7lI+L4+82W2s+3xA4niS1+VUSQVarsIHzLwiFqw6bDXh3m+BA+QhuiwEUH2Rz2Qg8QOx TPDIGIzdXVRt4+9LeuLar1ZgZVh/mEj/StE+ThXY+4Rgz+eJcD+jLJuKsUJ8O1dgaWeS e11c9zf9uHsRHTGOrSf8BMhB7fXoKTGS8/Aa5TUkNps7/UvKkrinll43rziQf68KgQOv 90SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzLKvtXsIMMGy8apCGuqdlRUn0uKWGPaM6gTC5o3IMo=; b=BoVDIR+lNbugy5325roHAm9CSyz0mfzNsMzbpDa4hqCRycgsgIHQSOp/KZ1LmojUyg pnVMvEpztLguZwM1Mxp+aklWx6i2MZGc5hYkXD5UxMvVxDTDsCSb48fTTmOtj0MG9/JW Cz4JYxLtDUGzMIYcSHshsQPcwgDVmW23lx1upF/RtplXdS7cBH6Y35B7ZDqGcFXxRzXR flmtvGHpwI1RNlB7QQSOMHvAFvCkLOEit7HZutzpNp0kO7j/ti6y2gPY5Af2xlw/z3hz NUp836ckBMnhdU7EskyMnFcmogTSY22sXDyi9F9T2p9ISkh/w2ivIP5KzMCziFQ0bkdU jbgA== X-Gm-Message-State: APjAAAUVfirnPAZHSTk6qHa4x/CX7W7bloFLT1TKNjagBbsPQqrSlxFi X7wcTGq93kPDE0TsiD0bBeBQ9Mzcbipf5BQR2Hu/VwkPj78= X-Google-Smtp-Source: APXvYqxu6JAQV4hTDErJZr2o7Qj+1o7wyn0JlIPuR/2dp5zF2pgLFx+yq2tG92VA5CUdCx+Q7obyFh1GtwTurNQqMHg= X-Received: by 2002:a24:59c1:: with SMTP id p184mr6969377itb.158.1555759828896; Sat, 20 Apr 2019 04:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20190419223829.62336-1-rebecca@bluestop.org> In-Reply-To: From: "Ard Biesheuvel" Date: Sat, 20 Apr 2019 13:30:17 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD To: edk2-devel-groups-io , Rebecca Cran Cc: Ting Ye , Jian Wang Content-Type: text/plain; charset="UTF-8" On Sat, 20 Apr 2019 at 13:28, Ard Biesheuvel wrote: > > On Sat, 20 Apr 2019 at 00:38, rebecca via Groups.Io > wrote: > > > > When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c > > calls issetugid(). Add the declaration of this function to > > CrtLibSupport.h to avoid the need to patch the openssl code on these > > platforms. > > > > Signed-off-by: Rebecca Cran > > This is slightly odd. The host architecture shouldn't really matter, > and so if we end up calling different code in UEFI when built on *BSD, > there is differently something wrong. Or am I missing something? > *definitely > > --- > > CryptoPkg/Library/Include/CrtLibSupport.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h > > index a241fb96fb..b05c5d908c 100644 > > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > > @@ -155,6 +155,7 @@ uid_t getuid (void); > > uid_t geteuid (void); > > gid_t getgid (void); > > gid_t getegid (void); > > +int issetugid (void); > > void qsort (void *, size_t, size_t, int (*)(const void *, const void *)); > > char *getenv (const char *); > > char *secure_getenv (const char *); > > -- > > 2.21.0 > > > > > > ------------ > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#39338): https://edk2.groups.io/g/devel/message/39338 > > Mute This Topic: https://groups.io/mt/31250604/1761188 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ard.biesheuvel@linaro.org] > > ------------ > >