From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 769F81A1FCE for ; Thu, 22 Sep 2016 14:29:30 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id m186so99476277ioa.2 for ; Thu, 22 Sep 2016 14:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uyroY9ku+gM0mQqncz2iC2u8CuWU9/Txezc9kltTO+E=; b=F6KGiPhWj3KkfaF5gFrUD/H9q3nZ6ymUIhk+oHN8s/F7NT0g1fjZGiNCctT/6xwpCl iWV1xH3z1Pkh6spr1QqB4pZzLTIcDfYtC3oLnGgdXv7wfEXBbw7O4aaX4J42tNAPoYGJ mGsG9qA4kNyzBeppeCe9Pqgb6H0NgaJLzu74w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uyroY9ku+gM0mQqncz2iC2u8CuWU9/Txezc9kltTO+E=; b=QxGlmwt75uDM/U+35h6IYEJzD0nRh+uLA9V2JcFOddEkpZ2M07WCkvyPZ1x+do9qru 6FPO6Wb9vnxOtAh4+bD9inJRUKSfq5N4Ge1ihVPEC0QZvTkq+rX1FuKVzPldqD+RRr7L tJMWBGfOvDIfVSKwqUACmy7zdU7NB6E+RyIuQaHfpqT6x/OMAkW3aI+Lf0pM0sLKCzv6 RzoKSz+6luEc2S+fh3uBmyi8/WS4N701s+IezUSyVOzi55GIkoOnXi56qq3ZgUefknAU 9mHvTy4XtnER2yKWeyIkT5Xv/2/ocwtbyJVlMcwdbiYjs70xHdDLx66/PVlfGWTxI1Lg MoTQ== X-Gm-Message-State: AA6/9RlTEFaFoLtksIvYaQVb/5EX2n2jPgyXFpQYI5NSKSeuGqEOlBdFaOi+dpz/QGToeGg+lld+UBHiXQzs9Lsl X-Received: by 10.107.35.209 with SMTP id j200mr5149887ioj.26.1474579769702; Thu, 22 Sep 2016 14:29:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 22 Sep 2016 14:29:29 -0700 (PDT) In-Reply-To: <8E1C407F-A3A7-47D8-B26D-4F2AD389B006@apple.com> References: <88690c52-2185-13cb-2f61-eabedeb59b03@akeo.ie> <8E1C407F-A3A7-47D8-B26D-4F2AD389B006@apple.com> From: Ard Biesheuvel Date: Thu, 22 Sep 2016 22:29:29 +0100 Message-ID: To: Andrew Fish Cc: Pete Batard , "edk2-devel@lists.01.org" Subject: Re: [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 21:29:30 -0000 Content-Type: text/plain; charset=UTF-8 On 22 September 2016 at 22:24, Andrew Fish wrote: > [..] > Pete, > > Stupid question. Does adding EFIAPI fix this issue? So: > > VOID > EFIAPI > MultiParammNative( > UINT32, > UINT64, > UINT64, > UINT64, > UINT32, > UINT32, > UINT64 > ); > > I'm sitting next to Mike Kinney at the UEFI Forum Plug Fest and we were > wondering if the calling convention stuff was mucked up on C side. > Pete already confirmed that his analysis regarding X64 and AARCH64 was incorrect. The only architecture that is affected by this issue is ARM, and purely due to the fact that its calling convention leaves 'holes' in the register/stack slot assignment to ensure UINT64 values appear naturally aligned (i.e., the protoype above would not use r1, but pass the second argument in r2 and r3)