From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E8C31A1DFE for ; Sat, 30 Jul 2016 02:22:42 -0700 (PDT) Received: by mail-it0-x235.google.com with SMTP id j124so129754941ith.1 for ; Sat, 30 Jul 2016 02:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3h5uxK/TUeTQaNtNjMHB596aH4pwY9bevPEh0hIL1zE=; b=RqyHFvq7tXtnfOm3HgMMJK2uZ7KHwBrxzNLF1/LVD4vjSC+/AHysK5OPuXIDhGGZqn ZUfO+JtYg8VFg2QxScmoAQ+x0s95CT23OnM0f6v/X5iz/90bKBXTzplfYyuGnIyJh1mw 8J6yrjqBsR9Z6bz0jxRRTmYH9t/piL5wTirP8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3h5uxK/TUeTQaNtNjMHB596aH4pwY9bevPEh0hIL1zE=; b=cTQUKF3LS8tpZcQY0U8y31EKkgKsKpGHgHQAglg8EiKwkhECWq5fbDJso6257Buk4i TCB8aDE/GJ/r9UlnsedTteBrcPUwy6NvvlUgtcKhx1bQkfSCg2jYNY+K76XgXxNbYwR5 WMh0bXY5imOBU3oOJrvYrYu6ETN+gS1HpPei8FGYx8rKm3NpOLVPtnJopj2htgr5Tc5v DfET3Ojmcsh4ZDgjPpjUoZmyeBWn1iUN9ap9jhRp6+XBIheeErbQ1o0u8k6xKPqUZR4t p8tPm3a/WXIY0ZTi2bUMT+mPWXup3oQ8virauKsUDRF8b+7QgxIrUyjoPt+rVQ29VcLM A55w== X-Gm-Message-State: AEkooutXdYDuRf86bxQ7tRa1c1+4RHxHqW8TGDYiWWD6ZQ1Fza/NEG6ZUwHEaEPfVU/TSv2Bz05JWpelsGrFCCAJ X-Received: by 10.36.39.77 with SMTP id g74mr5024664ita.51.1469870561779; Sat, 30 Jul 2016 02:22:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Sat, 30 Jul 2016 02:22:41 -0700 (PDT) In-Reply-To: <146982438340.10571.937271449740290618@jljusten-ivb> References: <1469618017-6534-1-git-send-email-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A1155E24F5@shsmsx102.ccr.corp.intel.com> <146982438340.10571.937271449740290618@jljusten-ivb> From: Ard Biesheuvel Date: Sat, 30 Jul 2016 11:22:41 +0200 Message-ID: To: Jordan Justen Cc: "Gao, Liming" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "lersek@redhat.com" Subject: Re: [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jul 2016 09:22:42 -0000 Content-Type: text/plain; charset=UTF-8 On 29 July 2016 at 22:33, Jordan Justen wrote: > On 2016-07-28 23:09:15, Ard Biesheuvel wrote: >> On 29 July 2016 at 06:47, Gao, Liming wrote: >> > Ard: >> > Thanks for your update. I have some comments for them. >> > 1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them? I verify GCC49 in OVMFIa32X64 platform. It works. >> >> Yes, I tested all of them. >> > > I tested GCC44 (X64) on an old live-cd where GCC 4.4 was the supported > version. OVMF built and booted UEFI Linux. Therefore, I don't think we > are likely to have a major issue with GCC44-GCC49. > > I also tested GCC49 and GCC5 with X64 on a system with GCC 5.4. It > built and booted UEFI Linux. > OK, so you are not seeing the issue Liming reported when using the GCC49 toolchain tag with GCC 5.4? In that case, I am inclined to diagnose Liming's issue as a GCC 5.x regression that was fixed in 5.4. Adding the GOT handling to GenFw would still be possible, of course, but GOT based symbol references are sub-optimal so we should try to avoid them imo. If GCC 4.x does not emit any such references with protected visibility enabled, and nor does GCC 5.4, I think it it reasonable to require that GCC 5.3 users simply use the GCC5 profile (with LTO), and switch to either 4.9 or 5.4 if they want to use the GCC49 profile instead. > Can you add something like 'added GCC5 toolchain' into the subject for > patch 7? I really think that a patch that adds a new toolchain should > make it immediately obvious in the subject line. > Of course, that makes sense. > 3, 4 & 7 Reviewed-by: Jordan Justen > > The others, Acked-by: Jordan Justen > Thanks, Ard.