From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Wu, Hao A" <hao.a.wu@intel.com>
Cc: "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"vishalo@qti.qualcomm.com" <vishalo@qti.qualcomm.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s
Date: Tue, 20 Sep 2016 13:16:07 +0100 [thread overview]
Message-ID: <CAKv+Gu9=MgiXB9MSZWZ0Xrjjpqi4Y5HTFigQbbLzYU+_JQQUZg@mail.gmail.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A092F2B1E39@SHSMSX104.ccr.corp.intel.com>
On 20 September 2016 at 13:02, Wu, Hao A <hao.a.wu@intel.com> wrote:
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard
>> Biesheuvel
>> Sent: Tuesday, September 20, 2016 4:38 PM
>> To: Wu, Hao A
>> Cc: leif.lindholm@linaro.org; edk2-devel@lists.01.org;
>> vishalo@qti.qualcomm.com; Gao, Liming
>> Subject: Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing
>> ASSERT()s
>>
>> On 20 September 2016 at 03:00, Wu, Hao A <hao.a.wu@intel.com> wrote:
>> > Hi Ard,
>> >
>> > The NULL checks for the input Guids in APIs CopyGuid(), CompareGuid() and
>> > IsZeroGuid() are implicitly done within calls to BaseLib APIs
>> > ReadUnaligned64() and WriteUnaligned64().
>> >
>> > So I think the functions behavior matches with their comments. What do you
>> > think?
>> >
>>
>> I disagree. ReadUnaligned64 and WriteUnaligned64 could theoretically
>> be implemented by a version of BaseLib that does not contain such
>> ASSERT()s
>
> The comments for APIs ReadUnaligned64 and WriteUnaligned64 in BaseLib
> mention the ASSERT() for inputting a NULL buffer.
>
> I think instances of BaseLib should follow the comments.
>
I agree with this. But that does not justify omitting them here.
next prev parent reply other threads:[~2016-09-20 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:13 [PATCH v2 0/3] MdePkg/BaseMemoryLibOptDxe: generic and ARM/AARCH64 fixes Ard Biesheuvel
2016-09-19 8:13 ` [PATCH v2 1/3] MdePkg/BaseMemoryLibOptDxe ARM: fix arithmetic bugs in CompareMem() Ard Biesheuvel
2016-09-19 8:13 ` [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s Ard Biesheuvel
2016-09-20 2:00 ` Wu, Hao A
2016-09-20 8:38 ` Ard Biesheuvel
2016-09-20 12:02 ` Wu, Hao A
2016-09-20 12:16 ` Ard Biesheuvel [this message]
2016-09-20 12:40 ` Ard Biesheuvel
2016-09-21 1:27 ` Gao, Liming
2016-09-19 8:13 ` [PATCH v2 3/3] MdePkg/BaseMemoryLibOptDxe ARM|AARCH64: implement accelerated GUID functions Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9=MgiXB9MSZWZ0Xrjjpqi4Y5HTFigQbbLzYU+_JQQUZg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox