public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms 1/1] Silicon/SynQuacer/NetsecDxe: add missing GUID reference
@ 2020-02-26 13:05 Ard Biesheuvel
  2020-03-02 13:03 ` Leif Lindholm
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-02-26 13:05 UTC (permalink / raw)
  To: devel; +Cc: leif, Ard Biesheuvel

Add a GUID reference that the NETSEC driver depends on, but does not
declare, and therefore gets satisfied transitively by ArmLib. That
ArmLib reference will be dropped so fix NetSec first.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
index 0fb06ba80bf4..abc98183668a 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
+++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
@@ -50,6 +50,7 @@ [Guids]
   gNetsecNonDiscoverableDeviceGuid
 
 [Protocols]
+  gEfiCpuArchProtocolGuid                     ## CONSUMES
   gEdkiiNonDiscoverableDeviceProtocolGuid     ## TO_START
   gEfiDevicePathProtocolGuid                  ## BY_START
   gEfiSimpleNetworkProtocolGuid               ## BY_START
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/NetsecDxe: add missing GUID reference
  2020-02-26 13:05 [PATCH edk2-platforms 1/1] Silicon/SynQuacer/NetsecDxe: add missing GUID reference Ard Biesheuvel
@ 2020-03-02 13:03 ` Leif Lindholm
  2020-03-02 13:07   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-03-02 13:03 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: devel

On Wed, Feb 26, 2020 at 14:05:35 +0100, Ard Biesheuvel wrote:
> Add a GUID reference that the NETSEC driver depends on, but does not
> declare, and therefore gets satisfied transitively by ArmLib. That
> ArmLib reference will be dropped so fix NetSec first.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>


> ---
>  Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> index 0fb06ba80bf4..abc98183668a 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> @@ -50,6 +50,7 @@ [Guids]
>    gNetsecNonDiscoverableDeviceGuid
>  
>  [Protocols]
> +  gEfiCpuArchProtocolGuid                     ## CONSUMES
>    gEdkiiNonDiscoverableDeviceProtocolGuid     ## TO_START
>    gEfiDevicePathProtocolGuid                  ## BY_START
>    gEfiSimpleNetworkProtocolGuid               ## BY_START
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/NetsecDxe: add missing GUID reference
  2020-03-02 13:03 ` Leif Lindholm
@ 2020-03-02 13:07   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-03-02 13:07 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel-groups-io

On Mon, 2 Mar 2020 at 14:03, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Feb 26, 2020 at 14:05:35 +0100, Ard Biesheuvel wrote:
> > Add a GUID reference that the NETSEC driver depends on, but does not
> > declare, and therefore gets satisfied transitively by ArmLib. That
> > ArmLib reference will be dropped so fix NetSec first.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>

Thanks

Pushed as e168252531c7..f57b439e5610


>
> > ---
> >  Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> > index 0fb06ba80bf4..abc98183668a 100644
> > --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> > +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf
> > @@ -50,6 +50,7 @@ [Guids]
> >    gNetsecNonDiscoverableDeviceGuid
> >
> >  [Protocols]
> > +  gEfiCpuArchProtocolGuid                     ## CONSUMES
> >    gEdkiiNonDiscoverableDeviceProtocolGuid     ## TO_START
> >    gEfiDevicePathProtocolGuid                  ## BY_START
> >    gEfiSimpleNetworkProtocolGuid               ## BY_START
> > --
> > 2.17.1
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-02 13:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-26 13:05 [PATCH edk2-platforms 1/1] Silicon/SynQuacer/NetsecDxe: add missing GUID reference Ard Biesheuvel
2020-03-02 13:03 ` Leif Lindholm
2020-03-02 13:07   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox