From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Philippe Mathieu-Daude <philmd@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v2 02/78] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER
Date: Wed, 8 Jan 2020 13:41:14 +0100 [thread overview]
Message-ID: <CAKv+Gu9=iGznEG6Roh+40yeW838vaiOTuOYy_oqhYdtWhoJ_fQ@mail.gmail.com> (raw)
In-Reply-To: <20200103090812.10592-3-philmd@redhat.com>
On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude <philmd@redhat.com> wrote:
>
> Correctly write 'EFI_INVALID_PARAMETER' in documentation.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> .../VirtualKeyboardDxe/VirtualKeyboard.h | 22 +++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
> index 8757b678d161..29bc7a06fb16 100644
> --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
> @@ -206,9 +206,9 @@ VirtualKeyboardDriverBindingStop (
> This and the language specified by Language was
> returned in DriverName.
>
> - @retval EFI_INVALID_PAVIRTUALETER Language is NULL.
> + @retval EFI_INVALID_PARAMETER Language is NULL.
>
> - @retval EFI_INVALID_PAVIRTUALETER DriverName is NULL.
> + @retval EFI_INVALID_PARAMETER DriverName is NULL.
>
> @retval EFI_UNSUPPORTED The driver specified by This does not support
> the language specified by Language.
> @@ -274,14 +274,14 @@ VirtualKeyboardComponentNameGetDriverName (
> driver specified by This was returned in
> DriverName.
>
> - @retval EFI_INVALID_PAVIRTUALETER ControllerHandle is NULL.
> + @retval EFI_INVALID_PARAMETER ControllerHandle is NULL.
>
> - @retval EFI_INVALID_PAVIRTUALETER ChildHandle is not NULL and it is not a valid
> + @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a valid
> EFI_HANDLE.
>
> - @retval EFI_INVALID_PAVIRTUALETER Language is NULL.
> + @retval EFI_INVALID_PARAMETER Language is NULL.
>
> - @retval EFI_INVALID_PAVIRTUALETER ControllerName is NULL.
> + @retval EFI_INVALID_PARAMETER ControllerName is NULL.
>
> @retval EFI_UNSUPPORTED The driver specified by This is not currently
> managing the controller specified by
> @@ -351,7 +351,7 @@ VirtualKeyboardResetEx (
> @retval EFI_DEVICE_ERROR The device is not functioning correctly and could
> not have the setting adjusted.
> @retval EFI_UNSUPPORTED The device does not have the ability to set its state.
> - @retval EFI_INVALID_PAVIRTUALETER KeyToggleState is NULL.
> + @retval EFI_INVALID_PARAMETER KeyToggleState is NULL.
>
> **/
> EFI_STATUS
> @@ -374,7 +374,7 @@ VirtualKeyboardSetState (
>
> @retval EFI_SUCCESS The notification function was registered successfully.
> @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures.
> - @retval EFI_INVALID_PAVIRTUALETER KeyData or NotifyHandle is NULL.
> + @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL.
>
> **/
> EFI_STATUS
> @@ -393,7 +393,7 @@ VirtualKeyboardRegisterKeyNotify (
> @param NotificationHandle The handle of the notification function being unregistered.
>
> @retval EFI_SUCCESS The notification function was unregistered successfully.
> - @retval EFI_INVALID_PAVIRTUALETER The NotificationHandle is invalid.
> + @retval EFI_INVALID_PARAMETER The NotificationHandle is invalid.
>
> **/
> EFI_STATUS
> @@ -412,7 +412,7 @@ VirtualKeyboardUnregisterKeyNotify (
> @param ListHead The list head
>
> @retval EFI_SUCCESS Free the notify list successfully
> - @retval EFI_INVALID_PAVIRTUALETER ListHead is invalid.
> + @retval EFI_INVALID_PARAMETER ListHead is invalid.
>
> **/
> EFI_STATUS
> @@ -524,7 +524,7 @@ VirtualKeyboardReadKeyStroke (
> @retval EFI_NOT_READY There was no keystroke data availiable.
> @retval EFI_DEVICE_ERROR The keystroke information was not returned due to
> hardware errors.
> - @retval EFI_INVALID_PAVIRTUALETER KeyData is NULL.
> + @retval EFI_INVALID_PARAMETER KeyData is NULL.
>
> **/
> EFI_STATUS
> --
> 2.21.0
>
next prev parent reply other threads:[~2020-01-08 12:41 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 9:06 [PATCH v2 00/78] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
2020-01-03 9:06 ` [PATCH v2 01/78] CryptoPkg/OpensslLib: Fix few typos Philippe Mathieu-Daudé
2020-01-06 2:39 ` Wang, Jian J
2020-01-03 9:06 ` [PATCH v2 02/78] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
2020-01-08 12:41 ` Ard Biesheuvel [this message]
2020-01-03 9:06 ` [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos Philippe Mathieu-Daudé
2020-01-08 12:42 ` Ard Biesheuvel
2020-01-08 14:26 ` Philippe Mathieu-Daudé
2020-01-03 9:06 ` [PATCH v2 04/78] EmulatorPkg/Sec: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:06 ` [PATCH v2 05/78] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 06/78] EmulatorPkg/Win: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 07/78] FatPkg/EnhancedFatDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 08/78] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 09/78] MdeModulePkg/Application: Improve French translation Philippe Mathieu-Daudé
2020-02-07 0:49 ` Philippe Mathieu-Daudé
2020-02-07 0:53 ` [edk2-devel] " Wu, Hao A
2020-02-07 0:55 ` Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 10/78] MdeModulePkg/Application: Fix various typos Philippe Mathieu-Daudé
2020-02-07 0:26 ` [edk2-devel] " Wu, Hao A
2020-01-03 9:07 ` [PATCH v2 11/78] MdeModulePkg/Bus/Ata: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 12/78] MdeModulePkg/Bus/I2c: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 13/78] MdeModulePkg/Bus/Isa: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 14/78] MdeModulePkg/Bus/Scsi: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 15/78] MdeModulePkg/Bus/Sd: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 16/78] MdeModulePkg/Core/Pei: " Philippe Mathieu-Daudé
2020-02-07 0:26 ` Wu, Hao A
2020-01-03 9:07 ` [PATCH v2 17/78] MdeModulePkg/Core/PiSmmCore: " Philippe Mathieu-Daudé
2020-02-07 0:26 ` Wu, Hao A
2020-01-03 9:07 ` [PATCH v2 18/78] MdeModulePkg/UsbBusDxe: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 19/78] MdeModulePkg/UsbMass: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 20/78] MdeModulePkg/UsbMouse: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 21/78] MdeModulePkg/UsbBus: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 22/78] MdeModulePkg/Usb: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 23/78] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
2020-01-06 3:32 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 24/78] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
2020-01-06 3:35 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 25/78] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
2020-01-06 3:35 ` [edk2-devel] " Liming Gao
2020-01-03 9:07 ` [PATCH v2 26/78] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
2020-01-06 3:35 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 27/78] MdePkg/Ppi: " Philippe Mathieu-Daudé
2020-01-06 3:36 ` [edk2-devel] " Liming Gao
2020-01-03 9:07 ` [PATCH v2 28/78] MdePkg/Register: " Philippe Mathieu-Daudé
2020-01-06 3:38 ` Liming Gao
2020-01-03 9:07 ` [PATCH v2 29/78] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 30/78] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 31/78] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 32/78] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 33/78] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 34/78] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 35/78] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 36/78] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 37/78] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 38/78] NetworkPkg/HttpDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 39/78] NetworkPkg/Ip4Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 40/78] NetworkPkg/Ip6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 41/78] NetworkPkg/IScsiDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 42/78] NetworkPkg/Library: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 43/78] NetworkPkg/MnpDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 44/78] NetworkPkg/Mtftp4Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 45/78] NetworkPkg/Mtftp6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 46/78] NetworkPkg/SnpDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 47/78] NetworkPkg/TcpDxe/Sock: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 48/78] NetworkPkg/TcpDxe/Tcp: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 49/78] NetworkPkg/Tls: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 50/78] NetworkPkg/Udp4Dxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 51/78] NetworkPkg/Udp6Dxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 52/78] NetworkPkg/UefiPxeBcDxe: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 53/78] NetworkPkg/VlanConfigDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 54/78] OvmfPkg/Acpi: " Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 55/78] OvmfPkg/Csm: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:40 ` [edk2-devel] " Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 56/78] OvmfPkg/Csm/LegacyBios: Fix a typo Philippe Mathieu-Daudé
2020-01-03 13:40 ` [edk2-devel] " Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 57/78] OvmfPkg/Qemu: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:37 ` Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 58/78] OvmfPkg/Virtio: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 59/78] OvmfPkg/Xen: Fix a typo Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 60/78] OvmfPkg/Xen: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:42 ` [edk2-devel] " Laszlo Ersek
2020-01-06 10:36 ` Anthony PERARD
2020-01-06 16:06 ` Laszlo Ersek
2020-01-03 9:07 ` [PATCH v2 61/78] PcAtChipsetPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:07 ` [PATCH v2 62/78] SecurityPkg: " Philippe Mathieu-Daudé
2020-01-03 9:56 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:07 ` [PATCH v2 63/78] SecurityPkg/Hash2DxeCrypto: " Philippe Mathieu-Daudé
2020-01-03 9:55 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:07 ` [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:54 ` Yao, Jiewen
2020-01-03 9:07 ` [PATCH v2 65/78] SecurityPkg/Tcg: " Philippe Mathieu-Daudé
2020-01-03 9:56 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 66/78] SecurityPkg/VariableAuthenticated: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:56 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 67/78] ShellPkg/Application: Fix various typos Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 68/78] ShellPkg/DynamicCommand: " Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 69/78] SignedCapsulePkg: " Philippe Mathieu-Daudé
2020-01-03 9:56 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 70/78] SignedCapsulePkg/Universal: " Philippe Mathieu-Daudé
2020-01-03 12:13 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 71/78] SourceLevelDebugPkg/DebugAgent: " Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 72/78] SourceLevelDebugPkg/DebugCommunicationLib: " Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 73/78] SourceLevelDebugPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 9:08 ` [PATCH v2 74/78] StandaloneMmPkg: Fix a typo Philippe Mathieu-Daudé
2020-01-03 12:13 ` [edk2-devel] " Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 75/78] StandaloneMmPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 12:14 ` Yao, Jiewen
2020-01-03 9:08 ` [PATCH v2 76/78] UefiCpuPkg/CpuDxe: " Philippe Mathieu-Daudé
2020-01-07 8:28 ` [edk2-devel] " Dong, Eric
2020-01-03 9:08 ` [PATCH v2 77/78] UefiCpuPkg/PiSmm: Fix various typos Philippe Mathieu-Daudé
2020-01-07 8:27 ` [edk2-devel] " Dong, Eric
2020-01-03 9:08 ` [PATCH v2 78/78] UefiCpuPkg/Smm: " Philippe Mathieu-Daudé
2020-01-07 8:28 ` Dong, Eric
2020-01-03 10:59 ` [PATCH v2 00/78] Fix a bunch of typos (part 1) Cœur
2020-01-07 12:44 ` [edk2-devel] " Maciej Rabeda
2020-01-17 17:13 ` Philippe Mathieu-Daudé
2020-01-19 5:14 ` [edk2-devel] " Liming Gao
2020-01-20 8:35 ` Philippe Mathieu-Daudé
2020-01-17 17:15 ` Philippe Mathieu-Daudé
2020-02-06 23:46 ` Philippe Mathieu-Daudé
2020-02-10 15:22 ` [edk2-devel] " Maciej Rabeda
2020-02-10 23:51 ` 答复: " Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9=iGznEG6Roh+40yeW838vaiOTuOYy_oqhYdtWhoJ_fQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox