From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Gary Lin <glin@suse.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 01/33] ArmPkg: Fix typos in comments
Date: Wed, 19 Oct 2016 16:09:44 +0100 [thread overview]
Message-ID: <CAKv+Gu9A-PE_28KGcywD5GtoQCht=9eF_mk2+99y5MNq7_Q2dA@mail.gmail.com> (raw)
In-Reply-To: <20161019070138.16424-2-glin@suse.com>
On 19 October 2016 at 08:01, Gary Lin <glin@suse.com> wrote:
> - differnt -> different
> - Libary -> Library
> - intialized -> initialized
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S | 2 +-
> ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm | 2 +-
> ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S
> index 0f2e4b1..2151814 100644
> --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S
> +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S
> @@ -211,7 +211,7 @@ ASM_PFX(AsmCommonExceptionEntry):
> ldr R5, [SP, #0x58] @ PC is the LR pushed by srsfd
> @ Check to see if we have to adjust for Thumb entry
> sub r4, r0, #1 @ if (ExceptionType == 1 || ExceptionType ==2)) {
> - cmp r4, #1 @ // UND & SVC have differnt LR adjust for Thumb
> + cmp r4, #1 @ // UND & SVC have different LR adjust for Thumb
> bhi NoAdjustNeeded
>
> tst r1, #0x20 @ if ((CPSR & T)) == T) { // Thumb Mode on entry
> diff --git a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm
> index b879142..cf59447 100644
> --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm
> +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm
> @@ -206,7 +206,7 @@ AsmCommonExceptionEntry
> ldr R5, [SP, #0x58] ; PC is the LR pushed by srsfd
> ; Check to see if we have to adjust for Thumb entry
> sub r4, r0, #1 ; if (ExceptionType == 1 || ExceptionType ==2)) {
> - cmp r4, #1 ; // UND & SVC have differnt LR adjust for Thumb
> + cmp r4, #1 ; // UND & SVC have different LR adjust for Thumb
> bhi NoAdjustNeeded
>
> tst r1, #0x20 ; if ((CPSR & T)) == T) { // Thumb Mode on entry
> diff --git a/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c b/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c
> index fe5fd55..9c0cf0d 100644
> --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c
> +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c
> @@ -259,7 +259,7 @@ GetImageContext (
> function and pass it into InitializeDebugAgent(). InitializeDebugAgent() is
> responsible to invoke the passing-in function at the end of InitializeDebugAgent().
>
> - If the parameter Function is not NULL, Debug Agent Libary instance will invoke it by
> + If the parameter Function is not NULL, Debug Agent Library instance will invoke it by
> passing in the Context to be its parameter.
>
> If Function() is NULL, Debug Agent Library instance will return after setup debug
> @@ -289,7 +289,7 @@ InitializeDebugAgent (
> ASSERT (((UINTN)DebugAgentVectorTable & ARM_VECTOR_TABLE_ALIGNMENT) == 0);
> ArmWriteVBar ((UINTN)DebugAgentVectorTable);
>
> - // We use InitFlag to know if DebugAgent has been intialized from
> + // We use InitFlag to know if DebugAgent has been initialized from
> // Sec (DEBUG_AGENT_INIT_PREMEM_SEC) or PrePi (DEBUG_AGENT_INIT_POSTMEM_SEC)
> // modules
> if (InitFlag == DEBUG_AGENT_INIT_PREMEM_SEC) {
> --
> 2.10.1
>
next prev parent reply other threads:[~2016-10-19 15:09 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel [this message]
2016-10-19 15:15 ` Laszlo Ersek
2016-10-19 15:33 ` Leif Lindholm
2016-10-19 7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19 7:30 ` Gao, Liming
2016-10-19 7:36 ` Zhu, Yonghong
2016-10-19 7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26 3:00 ` Long, Qin
2016-10-19 7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19 7:46 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19 8:19 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37 ` Jordan Justen
2016-10-20 8:16 ` Laszlo Ersek
2016-10-19 7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19 7:08 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:12 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19 7:07 ` Yao, Jiewen
2016-10-19 7:11 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19 7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19 7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19 7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19 8:21 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19 7:21 ` Fu, Siyuan
2016-10-26 0:53 ` Fu, Siyuan
2016-10-19 7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:50 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19 7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27 1:29 ` Zhang, Chao B
2016-11-14 3:12 ` Zhang, Chao B
2016-11-14 4:03 ` Gary Lin
2016-11-14 6:24 ` Gao, Liming
2016-11-14 8:30 ` Gary Lin
2016-10-19 7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 20:29 ` Carsey, Jaben
2016-10-20 1:55 ` Gary Lin
2016-10-19 7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19 7:46 ` Wu, Hao A
2016-10-19 7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20 1:58 ` Fan, Jeff
2016-10-20 2:08 ` Gary Lin
2016-10-20 2:45 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24 1:33 ` Wei, David
2016-10-19 7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9A-PE_28KGcywD5GtoQCht=9eF_mk2+99y5MNq7_Q2dA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox