From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9B4001A1E56 for ; Wed, 19 Oct 2016 08:09:45 -0700 (PDT) Received: by mail-it0-x22d.google.com with SMTP id m138so30980520itm.0 for ; Wed, 19 Oct 2016 08:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NwDd0kPlGFZwcBg/XeyNI5+2hhWZJK1vn8JDB6Ew8gc=; b=SqfhHtWCspMvaCwf9ErJxflFxk68+d4u3xn9//5AyKFdbzpr5Q9ydeIJ/FtdusfeIk XEVBxhUqEyP/dsSMl+K3c5s3AjUtOxAp3+NnjvmmszDbJjExpkTYkQRP00mk8Z0yuIAW zNK6tK8dcO+jYKbIq5JwZXsJy1yOU/peA2Csw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NwDd0kPlGFZwcBg/XeyNI5+2hhWZJK1vn8JDB6Ew8gc=; b=fkva/cjR1SxVwD1CxEPJL/Hvvt7tkMi46cj4A35B7P5FdsniV9kfGAATj6um3MGuTc oOFXZMn9gAT+yLCLxWHVgTP227JEzlqpLnJ2KCpwJjjvBL7OGDbPRGH3DooINPmnWbC+ 0uXMfPY4yA/46wp28uw2F9a4r8e+31nKIl+crM5HTQK4bMl6+fcFra7M7DFqa6JzfxpG PB9H/rpAFOmunpmXvHdw08rnoL6suxrDj505jggtDRs/2IQDS/XmXpQOEQZtKg4WNxnY z8cHU5QHJxKhpnu2QgkFfFFilutZzlwLIlcqtn9GkP+EmFB1EUSmS/Y/dX/AfxsWfGEM UXUA== X-Gm-Message-State: AA6/9RkpHwGGT68P3gHq1mhvR662gz+QA2BOp6r5yGg5HaL+Z04W9eC9z3hOvBxX5yyPzz2OJAgVmBlaiBsMBfZR X-Received: by 10.36.5.65 with SMTP id 62mr6750424itl.63.1476889784865; Wed, 19 Oct 2016 08:09:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.5.139 with HTTP; Wed, 19 Oct 2016 08:09:44 -0700 (PDT) In-Reply-To: <20161019070138.16424-2-glin@suse.com> References: <20161019070138.16424-1-glin@suse.com> <20161019070138.16424-2-glin@suse.com> From: Ard Biesheuvel Date: Wed, 19 Oct 2016 16:09:44 +0100 Message-ID: To: Gary Lin Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH 01/33] ArmPkg: Fix typos in comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 15:09:45 -0000 Content-Type: text/plain; charset=UTF-8 On 19 October 2016 at 08:01, Gary Lin wrote: > - differnt -> different > - Libary -> Library > - intialized -> initialized > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin Reviewed-by: Ard Biesheuvel > --- > ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S | 2 +- > ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm | 2 +- > ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S > index 0f2e4b1..2151814 100644 > --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S > +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S > @@ -211,7 +211,7 @@ ASM_PFX(AsmCommonExceptionEntry): > ldr R5, [SP, #0x58] @ PC is the LR pushed by srsfd > @ Check to see if we have to adjust for Thumb entry > sub r4, r0, #1 @ if (ExceptionType == 1 || ExceptionType ==2)) { > - cmp r4, #1 @ // UND & SVC have differnt LR adjust for Thumb > + cmp r4, #1 @ // UND & SVC have different LR adjust for Thumb > bhi NoAdjustNeeded > > tst r1, #0x20 @ if ((CPSR & T)) == T) { // Thumb Mode on entry > diff --git a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm > index b879142..cf59447 100644 > --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm > +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm > @@ -206,7 +206,7 @@ AsmCommonExceptionEntry > ldr R5, [SP, #0x58] ; PC is the LR pushed by srsfd > ; Check to see if we have to adjust for Thumb entry > sub r4, r0, #1 ; if (ExceptionType == 1 || ExceptionType ==2)) { > - cmp r4, #1 ; // UND & SVC have differnt LR adjust for Thumb > + cmp r4, #1 ; // UND & SVC have different LR adjust for Thumb > bhi NoAdjustNeeded > > tst r1, #0x20 ; if ((CPSR & T)) == T) { // Thumb Mode on entry > diff --git a/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c b/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c > index fe5fd55..9c0cf0d 100644 > --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c > +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.c > @@ -259,7 +259,7 @@ GetImageContext ( > function and pass it into InitializeDebugAgent(). InitializeDebugAgent() is > responsible to invoke the passing-in function at the end of InitializeDebugAgent(). > > - If the parameter Function is not NULL, Debug Agent Libary instance will invoke it by > + If the parameter Function is not NULL, Debug Agent Library instance will invoke it by > passing in the Context to be its parameter. > > If Function() is NULL, Debug Agent Library instance will return after setup debug > @@ -289,7 +289,7 @@ InitializeDebugAgent ( > ASSERT (((UINTN)DebugAgentVectorTable & ARM_VECTOR_TABLE_ALIGNMENT) == 0); > ArmWriteVBar ((UINTN)DebugAgentVectorTable); > > - // We use InitFlag to know if DebugAgent has been intialized from > + // We use InitFlag to know if DebugAgent has been initialized from > // Sec (DEBUG_AGENT_INIT_PREMEM_SEC) or PrePi (DEBUG_AGENT_INIT_POSTMEM_SEC) > // modules > if (InitFlag == DEBUG_AGENT_INIT_PREMEM_SEC) { > -- > 2.10.1 >