public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency
@ 2017-08-30  9:30 Ard Biesheuvel
  2017-08-30  9:31 ` Ard Biesheuvel
  0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2017-08-30  9:30 UTC (permalink / raw)
  To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel

This driver does not support on DmaLib, so don't declare it as a
dependency.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
index 6719d0adcc87..0fc8bd88c6ce 100644
--- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
+++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
@@ -37,7 +37,6 @@ [LibraryClasses]
   ArmShellCmdRunAxfLib
   BaseMemoryLib
   DebugLib
-  DmaLib
   DxeServicesTableLib
   IoLib
   NonDiscoverableDeviceRegistrationLib
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency
  2017-08-30  9:30 [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency Ard Biesheuvel
@ 2017-08-30  9:31 ` Ard Biesheuvel
  2017-08-30  9:33   ` Leif Lindholm
  0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2017-08-30  9:31 UTC (permalink / raw)
  To: edk2-devel@lists.01.org, Leif Lindholm; +Cc: Ard Biesheuvel

On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> This driver does not support on DmaLib, so don't declare it as a
> dependency.
>

-EGRAMMAR

Will fix before submitting

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> index 6719d0adcc87..0fc8bd88c6ce 100644
> --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> @@ -37,7 +37,6 @@ [LibraryClasses]
>    ArmShellCmdRunAxfLib
>    BaseMemoryLib
>    DebugLib
> -  DmaLib
>    DxeServicesTableLib
>    IoLib
>    NonDiscoverableDeviceRegistrationLib
> --
> 2.11.0
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency
  2017-08-30  9:31 ` Ard Biesheuvel
@ 2017-08-30  9:33   ` Leif Lindholm
  2017-08-30  9:35     ` Ard Biesheuvel
  0 siblings, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2017-08-30  9:33 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org

On Wed, Aug 30, 2017 at 10:31:22AM +0100, Ard Biesheuvel wrote:
> On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > This driver does not support on DmaLib, so don't declare it as a
> > dependency.
> >
> 
> -EGRAMMAR
> 
> Will fix before submitting

With that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> > index 6719d0adcc87..0fc8bd88c6ce 100644
> > --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> > +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
> > @@ -37,7 +37,6 @@ [LibraryClasses]
> >    ArmShellCmdRunAxfLib
> >    BaseMemoryLib
> >    DebugLib
> > -  DmaLib
> >    DxeServicesTableLib
> >    IoLib
> >    NonDiscoverableDeviceRegistrationLib
> > --
> > 2.11.0
> >


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency
  2017-08-30  9:33   ` Leif Lindholm
@ 2017-08-30  9:35     ` Ard Biesheuvel
  0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2017-08-30  9:35 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel@lists.01.org

On 30 August 2017 at 10:33, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Aug 30, 2017 at 10:31:22AM +0100, Ard Biesheuvel wrote:
>> On 30 August 2017 at 10:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> > This driver does not support on DmaLib, so don't declare it as a
>> > dependency.
>> >
>>
>> -EGRAMMAR
>>
>> Will fix before submitting
>
> With that:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed as db6f08a0eae6

Thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-30  9:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-30  9:30 [PATCH] ArmPlatformPkg/ArmJunoDxe: remove bogus DmaLib dependency Ard Biesheuvel
2017-08-30  9:31 ` Ard Biesheuvel
2017-08-30  9:33   ` Leif Lindholm
2017-08-30  9:35     ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox