From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mqkS0KPE; spf=pass (domain: linaro.org, ip: 209.85.166.196, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) by groups.io with SMTP; Fri, 17 May 2019 08:24:50 -0700 Received: by mail-it1-f196.google.com with SMTP id q132so12546418itc.5 for ; Fri, 17 May 2019 08:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZWbnMduXtaBG6bMGBL4xJ7NVLbdbmakv0AxUUzE5vxA=; b=mqkS0KPEDdRU7M+eGHPgajdlTdpUJf0w9d4eFxnSkirpdordvtWF/MfqUMdD2dZ5Gv nZgURwerh/VgiOViHC4vHZJgat0YK+Arzq10X1Gkdd7+Vkt++tKfrFErjdTUfzRmYdz+ nw/2W5OII/MwW15mg6n+xTnZWhzZ2G01r88jm2C1N9FxwPgOtLBfOrmOF7cQGtXdmFlQ v4FjpXp/uqRPTLsDrb7Y6fzH2VtDjJ+iKGhpwjC1z5snxyj3LuFhS6gOs1QDPCrwEHgH MmnkAbOuciytmj5+NEVx2EBX8CS9AR4VcyGmfK4zUkbLhacxP2DD7j+5kJdiyEUrthwE UG6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZWbnMduXtaBG6bMGBL4xJ7NVLbdbmakv0AxUUzE5vxA=; b=PlxFKwt+TYM56h5j61s8TSqZc3KUjrfmpzUbFcXSCV5OpzJcLk5uvWYbIdLCnWKukP KOIjiag9Mo18JR1I5aOkd5Td/YalF75RCFxHyFcPodEY92iiwFbyCGXNXm6le7wLeFBT U+1bYjRxZUhDGOYfH8WuRsCtsP9+AbSnZ24eGL2nOybzNfAAIM+wIky5/E7aj+3//bHi +ZDqK5w8VqHMvsEqLvXFNmoEccfj40vniC+uwXp8P40Wkbl7GOw6ql+QIHGFDKJL45+Z +7oT5ZVN5jyRakTporWmvz4JLYsLFXImEwbZK28nYgNqJClmbkArWrrxr2TbhoOWCt7Q oAkA== X-Gm-Message-State: APjAAAXlTl8MtjI1bbuMyiBI/OfreyP1GU3Wmy0702GCMBd5mBb+pZ7P RONYdY9CkvXFXmzEcmrYh7wAFosssk8glQpXdv7CZodW7pNyUA== X-Google-Smtp-Source: APXvYqz9s81REIy8f0jYag82v+CFd92bZnCxhcVxz7bcBD+ZF0jvxG1G2ICaZGXmavm+GRqQ678qSDXWVNRsM4XfGtM= X-Received: by 2002:a24:910b:: with SMTP id i11mr16011409ite.76.1558106689207; Fri, 17 May 2019 08:24:49 -0700 (PDT) MIME-Version: 1.0 References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-5-hao.a.wu@intel.com> In-Reply-To: <20190514020831.7728-5-hao.a.wu@intel.com> From: "Ard Biesheuvel" Date: Fri, 17 May 2019 17:24:36 +0200 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg To: edk2-devel-groups-io , "Wu, Hao A" Cc: Leif Lindholm , Michael D Kinney Content-Type: text/plain; charset="UTF-8" On Tue, 14 May 2019 at 04:08, Wu, Hao A wrote: > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > This commit will update the DSC file to consume the ReportStatusCodeLib > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > one in IntelFrameworkModulePkg. > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > there is no functional impact for this commit. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Hao A Wu This platform does not have a status code router, so should we not simply switch to BaseReportStatusCodeLibNull.inf here? > --- > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > index 2d5d6f9977..8e8bb833ea 100644 > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -163,7 +163,7 @@ > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > @@ -173,19 +173,19 @@ > > > [LibraryClasses.common.DXE_DRIVER] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > [LibraryClasses.common.UEFI_DRIVER] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > @@ -193,7 +193,7 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > PeCoffLib|BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf > -- > 2.12.0.windows.1 > > > >