Re: [edk2][PATCH 1/1] ArmPlatformPkg/PrePi: fix IS_XIP

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Thu, 5 Mar 2020 at 08:56, Andrei Warkentin <awarkentin@vmware.com> wrote:
>
> This wasn't correctly testing for FD to be outside RAM,
> when RAM base immediately follows the FD.
>
> This is part of some cleanup for RPi4 in edk2-platform.
>
> Signed-off-by: Andrei Warkentin <awarkentin@vmware.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Andrei. I'll put this on the pile of ArmPkg/ArmPlatformPkg
fixes I intend to merge today or tomorrow.


> ---
>  ArmPlatformPkg/PrePi/PrePi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c
> index 2bb1449581..74284f1883 100644
> --- a/ArmPlatformPkg/PrePi/PrePi.c
> +++ b/ArmPlatformPkg/PrePi/PrePi.c
> @@ -22,7 +22,7 @@
>  #include "PrePi.h"
>
>  #define IS_XIP() (((UINT64)FixedPcdGet64 (PcdFdBaseAddress) > mSystemMemoryEnd) || \
> -                  ((FixedPcdGet64 (PcdFdBaseAddress) + FixedPcdGet32 (PcdFdSize)) < FixedPcdGet64 (PcdSystemMemoryBase)))
> +                  ((FixedPcdGet64 (PcdFdBaseAddress) + FixedPcdGet32 (PcdFdSize)) <= FixedPcdGet64 (PcdSystemMemoryBase)))
>
>  UINT64 mSystemMemoryEnd = FixedPcdGet64(PcdSystemMemoryBase) +
>                            FixedPcdGet64(PcdSystemMemorySize) - 1;
> --
> 2.17.1
>