From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 535BA2035B2C5 for ; Sat, 23 Dec 2017 06:12:18 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id o130so20041842itg.0 for ; Sat, 23 Dec 2017 06:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=76a2tpShC++Uq9sHRqkiVoackkeaQtSjMJWlodK+r8s=; b=ZixF80BzARbWrXIZewsrc4J0AW3TUixoUsNI/MaRcYUESnLDQJXsLhfsf8tfi4mUhV uLGcCBDytqhBCiDtJUFPho1Gr3QvPpvaJy+BPymTLSNTh8XIFRwc/Afd/eCB+UyP+JKG oeAn00mmzgqG7ig1sCyfTmdf1g3ED0NpXyBW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=76a2tpShC++Uq9sHRqkiVoackkeaQtSjMJWlodK+r8s=; b=P6cgOHOK3ZSsp7l8rBB4zSM6GQ/18mm4m5tFfySfXsRlFtN8tqpudE3/VZjul/DttU WCqUlWLLUZIIfT89KuoGGGJPpDWc5NFuYmOwY2E2bM/GYf2b7n4qlKU0kglwkNsRUKUy 8REL3YnLHCZV5DsRd6DkMEENHfGNBwlSCAH1PNtuXK3fSDoxM0GxlBBCw8v0TtYTfGCZ RdI78bhPvv0/UrhAUmuRS0nt2coCmIKlh9Lu9MhqnyOmssNZy+wTCCVVQnZoWq9gbml6 Jx0v4d+skyS2SjE25JU2CJLprvGmg02dHqDn623nLp3Ctu6g6lBMZ2EPufFkfRS8jvfg 4N9g== X-Gm-Message-State: AKGB3mJOf8bpc8epVEn3pvIZcM6RbMlmBGk6Wss8O/7qo+992zQCEmbQ wBH1nvxUz/hIAZ8ES25y3ntc92if9LKkaoIUkZK1Cg== X-Google-Smtp-Source: ACJfBot1n9Q/PrPSExbXLT7GgBwCqOtv/nk3ZpsVL6joGK2nnFK2McP7BPvOebPzW76GLV/aYUcYjiaLjnd2lwEelnY= X-Received: by 10.36.71.83 with SMTP id t80mr21190153itb.48.1514038628845; Sat, 23 Dec 2017 06:17:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 06:17:08 -0800 (PST) In-Reply-To: <20171222190821.12440-12-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> <20171222190821.12440-12-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 14:17:08 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH edk2-platforms v2 11/18] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 14:12:18 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: EvanLloyd > > Because of copy/paste effects, HdLcdArmVExpress.c contained a > table entry "LCD_BPP Bpp;" specifying the Bits per Pixel for each mode. > However, all modes are LCD_BITS_PER_PIXEL_24. > > This change removes the table entry and related use of the field. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 42 ++++++-------------- > 1 file changed, 13 insertions(+), 29 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index 533d7fa4777e8f22429e2ae63a828dcb5401b5c0..8496a0215bc78585b546f63312c9d7f1ad07adb6 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -32,7 +32,6 @@ typedef struct { > UINT32 Mode; > UINT32 HorizontalResolution; > UINT32 VerticalResolution; > - LCD_BPP Bpp; > UINT32 OscFreq; > > // These are used by HDLCD > @@ -48,37 +47,37 @@ typedef struct { > **/ > STATIC CONST LCD_RESOLUTION mResolutions[] = { > { // Mode 0 : VGA : 640 x 480 x 24 bpp > - VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > + VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, > VGA_OSC_FREQUENCY, > VGA_H_SYNC, VGA_H_BACK_PORCH, VGA_H_FRONT_PORCH, > VGA_V_SYNC, VGA_V_BACK_PORCH, VGA_V_FRONT_PORCH > }, > { // Mode 1 : SVGA : 800 x 600 x 24 bpp > - SVGA, SVGA_H_RES_PIXELS, SVGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > + SVGA, SVGA_H_RES_PIXELS, SVGA_V_RES_PIXELS, > SVGA_OSC_FREQUENCY, > SVGA_H_SYNC, SVGA_H_BACK_PORCH, SVGA_H_FRONT_PORCH, > SVGA_V_SYNC, SVGA_V_BACK_PORCH, SVGA_V_FRONT_PORCH > }, > { // Mode 2 : XGA : 1024 x 768 x 24 bpp > - XGA, XGA_H_RES_PIXELS, XGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > + XGA, XGA_H_RES_PIXELS, XGA_V_RES_PIXELS, > XGA_OSC_FREQUENCY, > XGA_H_SYNC, XGA_H_BACK_PORCH, XGA_H_FRONT_PORCH, > XGA_V_SYNC, XGA_V_BACK_PORCH, XGA_V_FRONT_PORCH > }, > { // Mode 3 : SXGA : 1280 x 1024 x 24 bpp > - SXGA, SXGA_H_RES_PIXELS, SXGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > + SXGA, SXGA_H_RES_PIXELS, SXGA_V_RES_PIXELS, > (SXGA_OSC_FREQUENCY/2), > SXGA_H_SYNC, SXGA_H_BACK_PORCH, SXGA_H_FRONT_PORCH, > SXGA_V_SYNC, SXGA_V_BACK_PORCH, SXGA_V_FRONT_PORCH > }, > { // Mode 4 : UXGA : 1600 x 1200 x 24 bpp > - UXGA, UXGA_H_RES_PIXELS, UXGA_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > + UXGA, UXGA_H_RES_PIXELS, UXGA_V_RES_PIXELS, > (UXGA_OSC_FREQUENCY/2), > UXGA_H_SYNC, UXGA_H_BACK_PORCH, UXGA_H_FRONT_PORCH, > UXGA_V_SYNC, UXGA_V_BACK_PORCH, UXGA_V_FRONT_PORCH > }, > { // Mode 5 : HD : 1920 x 1080 x 24 bpp > - HD, HD_H_RES_PIXELS, HD_V_RES_PIXELS, LCD_BITS_PER_PIXEL_24, > + HD, HD_H_RES_PIXELS, HD_V_RES_PIXELS, > (HD_OSC_FREQUENCY/2), > HD_H_SYNC, HD_H_BACK_PORCH, HD_H_FRONT_PORCH, > HD_V_SYNC, HD_V_BACK_PORCH, HD_V_FRONT_PORCH > @@ -292,27 +291,12 @@ LcdPlatformQueryMode ( > Info->VerticalResolution = mResolutions[ModeNumber].VerticalResolution; > Info->PixelsPerScanLine = mResolutions[ModeNumber].HorizontalResolution; > > - switch (mResolutions[ModeNumber].Bpp) { > - case LCD_BITS_PER_PIXEL_24: > - Info->PixelFormat = PixelRedGreenBlueReserved8BitPerColor; > - Info->PixelInformation.RedMask = LCD_24BPP_RED_MASK; > - Info->PixelInformation.GreenMask = LCD_24BPP_GREEN_MASK; > - Info->PixelInformation.BlueMask = LCD_24BPP_BLUE_MASK; > - Info->PixelInformation.ReservedMask = LCD_24BPP_RESERVED_MASK; > - break; > - > - case LCD_BITS_PER_PIXEL_16_555: > - case LCD_BITS_PER_PIXEL_16_565: > - case LCD_BITS_PER_PIXEL_12_444: > - case LCD_BITS_PER_PIXEL_8: > - case LCD_BITS_PER_PIXEL_4: > - case LCD_BITS_PER_PIXEL_2: > - case LCD_BITS_PER_PIXEL_1: > - default: > - // These are not supported > - ASSERT (FALSE); > - break; > - } > + /* Bits per Pixel is always LCD_BITS_PER_PIXEL_24 */ > + Info->PixelFormat = PixelRedGreenBlueReserved8BitPerColor; > + Info->PixelInformation.RedMask = LCD_24BPP_RED_MASK; > + Info->PixelInformation.GreenMask = LCD_24BPP_GREEN_MASK; > + Info->PixelInformation.BlueMask = LCD_24BPP_BLUE_MASK; > + Info->PixelInformation.ReservedMask = LCD_24BPP_RESERVED_MASK; > > return EFI_SUCCESS; > } > @@ -395,7 +379,7 @@ LcdPlatformGetBpp ( > return EFI_INVALID_PARAMETER; > } > > - *Bpp = mResolutions[ModeNumber].Bpp; > + *Bpp = LCD_BITS_PER_PIXEL_24; > > return EFI_SUCCESS; > } > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >