From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.51751.1585579728380349806 for ; Mon, 30 Mar 2020 07:48:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=VeUmi+/y; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id f6so15649811wmj.3 for ; Mon, 30 Mar 2020 07:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gDEjrLDzvTyGg4CWW8pnJsK15O1SGbmsnWSUvx2wzQs=; b=VeUmi+/yZNHyW8wuQCX8iFmnJvdUUSneS6bnhJgCoXsAzWCVITpUlvasmIHA7pYqRl i7oGclz+m6fYyVOLl3TMIrfLxMtPxydeYSkz0KGNOWtQ/L6suSgAJCoKOftCZVc9UOTU MUp+lR6KPrbsEZNfqvF8Tv6CEjbQDg4hZ5tS4Y+HbiMTvL1D3gJuesTsHBC5kSVfYn4d /WfaHekO2sts1LZ+/9PJzXsyZ4gKZ37fxmRtICyah0Bd8IBuWZeaselijn6VrOWIICkA HYGkAHpIv8ZSJbXSC4Ak5W4NCwYlqHm+n3RkOqrCzuV+1NjSDplJiBM93hfAjhplxjJ0 5ohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gDEjrLDzvTyGg4CWW8pnJsK15O1SGbmsnWSUvx2wzQs=; b=piz3tzygKfyHYOj07Ts5wLzpAoDyxeW/6EzZFLdClCK3OeRaSBA04bHigKInbpBSuR xb38cLMORrSl/BGH5oWm8scKW6IPQ/fLmN5OIOkio8rIZjyMg8ZPjkB9NCc9HEKv0e61 K1XdoM6xUnv+gtHJb0dCPk93U3RSyyd5wkPPfvm+xyFCpMDSy/HCUDujZDGtZV5QxIwq 2ljM3dq+OMCr8zeVdoT6ROS3Nbh4TNWJylW2ZjUueNDQIBVhJXeDKA5+HlGwQ4SqVt0/ fhCKfLeym7UuZ2AQVWxbmjhwj8PT/Bcwc6CnBooeVkLkEl1o4bOnTfmrmCceNPS3zGCq zPMw== X-Gm-Message-State: ANhLgQ0sl2xkiAw0lcAIKY7xoWWi9RxI0Aq7tNQJ+9t2KUhveP0h2tGp xNQ5P4cLASeZbSWHyfQhrUrag04loef5COXoZsvt6A== X-Google-Smtp-Source: ADFU+vsEgCEpRtHbjmD138TECc8EZ48VSjDdZXnMK+IL9w0s7Py1MYRbwSiMueJrPQAhXvrOdWsi9J+vteMdi319XQo= X-Received: by 2002:a7b:cb81:: with SMTP id m1mr13371194wmi.1.1585579726916; Mon, 30 Mar 2020 07:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20200327130117.11304-1-pete@akeo.ie> In-Reply-To: <20200327130117.11304-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Mon, 30 Mar 2020 16:48:35 +0200 Message-ID: Subject: Re: [edk2-platforms][PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3 To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Fri, 27 Mar 2020 at 14:01, Pete Batard wrote: > > ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing > 2 of the 3 reserved bytes that are defined at the end of the > GICC structure for 6.0. > > Add a new macro to initialise the new field. > > Signed-off-by: Pete Batard > --- > EmbeddedPkg/Include/Library/AcpiLib.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Library/AcpiLib.h > index 5c6e2075de79..57d7bd595584 100644 > --- a/EmbeddedPkg/Include/Library/AcpiLib.h > +++ b/EmbeddedPkg/Include/Library/AcpiLib.h > @@ -64,6 +64,14 @@ > {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE} \ > } > > +#define EFI_ACPI_6_3_GICC_STRUCTURE_INIT(GicId, AcpiCpuUid, Mpidr, Flags, PmuIrq, \ > + GicBase, GicVBase, GicHBase, GsivId, GicRBase, Efficiency, SpeOvflIrq) \ > + { \ > + EFI_ACPI_6_0_GIC, sizeof (EFI_ACPI_6_0_GIC_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ > + GicId, AcpiCpuUid, Flags, 0, PmuIrq, 0, GicBase, GicVBase, GicHBase, \ > + GsivId, GicRBase, Mpidr, Efficiency, EFI_ACPI_RESERVED_BYTE, SpeOvflIrq \ > + } > + > #define EFI_ACPI_6_0_GIC_MSI_FRAME_INIT(GicMsiFrameId, PhysicalBaseAddress, Flags, SPICount, SPIBase) \ > { \ > EFI_ACPI_6_0_GIC_MSI_FRAME, sizeof (EFI_ACPI_6_0_GIC_MSI_FRAME_STRUCTURE), EFI_ACPI_RESERVED_WORD, \ [with the sizeof() changed to refer to EFI_ACPI_6_3_GIC_STRUCTURE] Reviewed-by: Ard Biesheuvel Pushed to edk2/master