[PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix

[PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix

[Heyi Guo]

Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
branch: rp-1802-osi-v1

*** BLURB HERE ***

Heyi Guo (2):
  Hisilicon D0x: Fix network interface order issue
  Hisilicon D0x: Move SnpPlatform to edk2-platforms.

Jason Zhang (1):
  Hisilicon D03/D05: Move SasPlatform to edk2-platforms

 Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi     | Bin 3040 -> 0 bytes
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
 Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi     | Bin 3424 -> 0 bytes
 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
 10 files changed, 96 deletions(-)
 delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
 delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
 delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
 delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
 delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
 delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
 delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
 delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf

-- 
1.9.1

[PATCH edk2-non-osi v1 1/3] Hisilicon D03/D05: Move SasPlatform to edk2-platforms

[Heyi Guo]

From: Jason Zhang <zhangjinsong2@huawei.com>

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
Signed-off-by: Ming Huang <huangming23@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 3040 -> 0 bytes
 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf |  24 --------------------
 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 3424 -> 0 bytes
 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf |  24 --------------------
 4 files changed, 48 deletions(-)

diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
deleted file mode 100644
index 4255641..0000000
Binary files a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi and /dev/null differ
diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
deleted file mode 100644
index 0d747a1..0000000
--- a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
+++ /dev/null
@@ -1,24 +0,0 @@
-#/** @file
-#
-#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
-#    Copyright (c) 2017, Linaro Limited. All rights reserved.
-#
-#    This program and the accompanying materials
-#    are licensed and made available under the terms and conditions of the BSD License
-#    which accompanies this distribution. The full text of the license may be found at
-#    http://opensource.org/licenses/bsd-license.php
-#
-#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#**/
-
-[Defines]
-  INF_VERSION                    = 0x00010019
-  BASE_NAME                      = SasPlatform
-  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
-  MODULE_TYPE                    = DXE_DRIVER
-  VERSION_STRING                 = 1.0
-
-[Binaries.AARCH64]
-  PE32|SasPlatform.efi|*
diff --git a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
deleted file mode 100644
index d2685ab..0000000
Binary files a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi and /dev/null differ
diff --git a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
deleted file mode 100644
index 0d747a1..0000000
--- a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
+++ /dev/null
@@ -1,24 +0,0 @@
-#/** @file
-#
-#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
-#    Copyright (c) 2017, Linaro Limited. All rights reserved.
-#
-#    This program and the accompanying materials
-#    are licensed and made available under the terms and conditions of the BSD License
-#    which accompanies this distribution. The full text of the license may be found at
-#    http://opensource.org/licenses/bsd-license.php
-#
-#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#**/
-
-[Defines]
-  INF_VERSION                    = 0x00010019
-  BASE_NAME                      = SasPlatform
-  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
-  MODULE_TYPE                    = DXE_DRIVER
-  VERSION_STRING                 = 1.0
-
-[Binaries.AARCH64]
-  PE32|SasPlatform.efi|*
-- 
1.9.1

[PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

[Heyi Guo]

Update SnpPV660Dxe binary to fix network interface order issue.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
Signed-off-by: Ming Huang <huangming23@huawei.com>
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
index 8ce6a6d..fbdbba1 100644
Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
index bc7942a..54f5dba 100644
Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
-- 
1.9.1

[PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms.

[Heyi Guo]

---
 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
 4 files changed, 48 deletions(-)

diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
deleted file mode 100644
index 5e7d8bd..0000000
Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
deleted file mode 100644
index 10b2003..0000000
--- a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
+++ /dev/null
@@ -1,24 +0,0 @@
-#/** @file
-#
-#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
-#    Copyright (c) 2017, Linaro Limited. All rights reserved.
-#
-#    This program and the accompanying materials
-#    are licensed and made available under the terms and conditions of the BSD License
-#    which accompanies this distribution. The full text of the license may be found at
-#    http://opensource.org/licenses/bsd-license.php
-#
-#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#**/
-
-[Defines]
-  INF_VERSION                    = 0x00010019
-  BASE_NAME                      = SnpPlatform
-  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
-  MODULE_TYPE                    = DXE_DRIVER
-  VERSION_STRING                 = 1.0
-
-[Binaries.AARCH64]
-  PE32|SnpPlatform.efi|*
diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
deleted file mode 100644
index 42c26de..0000000
Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
deleted file mode 100644
index 10b2003..0000000
--- a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
+++ /dev/null
@@ -1,24 +0,0 @@
-#/** @file
-#
-#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
-#    Copyright (c) 2017, Linaro Limited. All rights reserved.
-#
-#    This program and the accompanying materials
-#    are licensed and made available under the terms and conditions of the BSD License
-#    which accompanies this distribution. The full text of the license may be found at
-#    http://opensource.org/licenses/bsd-license.php
-#
-#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#**/
-
-[Defines]
-  INF_VERSION                    = 0x00010019
-  BASE_NAME                      = SnpPlatform
-  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
-  MODULE_TYPE                    = DXE_DRIVER
-  VERSION_STRING                 = 1.0
-
-[Binaries.AARCH64]
-  PE32|SnpPlatform.efi|*
-- 
1.9.1

Re: [PATCH edk2-non-osi v1 1/3] Hisilicon D03/D05: Move SasPlatform to edk2-platforms

[Ard Biesheuvel]

On 18 January 2018 at 15:02, Heyi Guo <heyi.guo@linaro.org> wrote:
> From: Jason Zhang <zhangjinsong2@huawei.com>
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 3424 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf |  24 --------------------
>  4 files changed, 48 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
> deleted file mode 100644
> index 4255641..0000000
> Binary files a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> deleted file mode 100644
> index 0d747a1..0000000
> --- a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SasPlatform
> -  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SasPlatform.efi|*
> diff --git a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
> deleted file mode 100644
> index d2685ab..0000000
> Binary files a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
> deleted file mode 100644
> index 0d747a1..0000000
> --- a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SasPlatform
> -  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SasPlatform.efi|*
> --
> 1.9.1
>

Re: [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

[Ard Biesheuvel]

On 18 January 2018 at 15:02, Heyi Guo <heyi.guo@linaro.org> wrote:
> Update SnpPV660Dxe binary to fix network interface order issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
>  2 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index 8ce6a6d..fbdbba1 100644
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index bc7942a..54f5dba 100644
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> --
> 1.9.1
>

Re: [PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms.

[Ard Biesheuvel]

On 18 January 2018 at 15:02, Heyi Guo <heyi.guo@linaro.org> wrote:
> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  4 files changed, 48 deletions(-)
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
> deleted file mode 100644
> index 5e7d8bd..0000000
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> deleted file mode 100644
> index 10b2003..0000000
> --- a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SnpPlatform
> -  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SnpPlatform.efi|*
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
> deleted file mode 100644
> index 42c26de..0000000
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> deleted file mode 100644
> index 10b2003..0000000
> --- a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SnpPlatform
> -  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SnpPlatform.efi|*
> --
> 1.9.1
>

Re: [PATCH edk2-non-osi v1 0/3] Improve D0x platforms and bug fix

[Leif Lindholm]

On Thu, Jan 18, 2018 at 11:02:42PM +0800, Heyi Guo wrote:
> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rp-1802-osi-v1
> 
> *** BLURB HERE ***

I'm happy with the layout this set, but I would have preferred if
this cover-letter instead of "*** BLURB HERE ***" pointed out
explicitly the ordering requirements with regards to the
edk2-platforms set.

However, since we don't have any source code to help guide us in what
changes have been implemented, the individual commit messages for each
patch need to be more detailed - I will comment on those separately.

/
    Leif

> Heyi Guo (2):
>   Hisilicon D0x: Fix network interface order issue
>   Hisilicon D0x: Move SnpPlatform to edk2-platforms.
> 
> Jason Zhang (1):
>   Hisilicon D03/D05: Move SasPlatform to edk2-platforms
> 
>  Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi     | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi     | Bin 3424 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf     |  24 --------------------
>  10 files changed, 96 deletions(-)
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
>  delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
> 
> -- 
> 1.9.1
> 

Re: [PATCH edk2-non-osi v1 1/3] Hisilicon D03/D05: Move SasPlatform to edk2-platforms

[Leif Lindholm]

OK, so this one is pretty self-explanatory, but:
This patch does not move anything - it deletes it.
So the subject line should say this.

Then a line in the body can clarify that an open-source version coming
to edk2-platforms replaces this version.

/
    Leif

On Thu, Jan 18, 2018 at 11:02:43PM +0800, Heyi Guo wrote:
> From: Jason Zhang <zhangjinsong2@huawei.com>
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 3424 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf |  24 --------------------
>  4 files changed, 48 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi
> deleted file mode 100644
> index 4255641..0000000
> Binary files a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> deleted file mode 100644
> index 0d747a1..0000000
> --- a/Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SasPlatform
> -  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SasPlatform.efi|*
> diff --git a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi b/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi
> deleted file mode 100644
> index d2685ab..0000000
> Binary files a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf b/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
> deleted file mode 100644
> index 0d747a1..0000000
> --- a/Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SasPlatform
> -  FILE_GUID                      = 102D8FC9-20a4-42EB-aC14-1C98BA5b26A4
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SasPlatform.efi|*
> -- 
> 1.9.1
> 

Re: [PATCH edk2-non-osi v1 2/3] Hisilicon D0x: Fix network interface order issue

[Leif Lindholm]

On Thu, Jan 18, 2018 at 11:02:44PM +0800, Heyi Guo wrote:
> Update SnpPV660Dxe binary to fix network interface order issue.

What was the issue?
What was the behaviour seen before this update?
What is the behaviour seen after this update?

/
    Leif

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes
>  2 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index 8ce6a6d..fbdbba1 100644
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi
> index bc7942a..54f5dba 100644
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi and b/Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi differ
> -- 
> 1.9.1
> 

Re: [PATCH edk2-non-osi v1 3/3] Hisilicon D0x: Move SnpPlatform to edk2-platforms.

[Leif Lindholm]

Same comments as for 1/3:
"Move" statements belong in 0/3 - this one simply deletes.

This patch is also missing signed-off-bys and contributed-unders.

/
    Leif

On Thu, Jan 18, 2018 at 11:02:45PM +0800, Heyi Guo wrote:
> ---
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes
>  Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes
>  Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf |  24 --------------------
>  4 files changed, 48 deletions(-)
> 
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi
> deleted file mode 100644
> index 5e7d8bd..0000000
> Binary files a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> deleted file mode 100644
> index 10b2003..0000000
> --- a/Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SnpPlatform
> -  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SnpPlatform.efi|*
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi
> deleted file mode 100644
> index 42c26de..0000000
> Binary files a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi and /dev/null differ
> diff --git a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf b/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> deleted file mode 100644
> index 10b2003..0000000
> --- a/Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -#/** @file
> -#
> -#    Copyright (c) 2017, Hisilicon Limited. All rights reserved.
> -#    Copyright (c) 2017, Linaro Limited. All rights reserved.
> -#
> -#    This program and the accompanying materials
> -#    are licensed and made available under the terms and conditions of the BSD License
> -#    which accompanies this distribution. The full text of the license may be found at
> -#    http://opensource.org/licenses/bsd-license.php
> -#
> -#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010019
> -  BASE_NAME                      = SnpPlatform
> -  FILE_GUID                      = 102D8FC9-20A4-42EB-AC14-1C98BA5B17A8
> -  MODULE_TYPE                    = DXE_DRIVER
> -  VERSION_STRING                 = 1.0
> -
> -[Binaries.AARCH64]
> -  PE32|SnpPlatform.efi|*
> -- 
> 1.9.1
>