From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68])
 by mx.groups.io with SMTP id smtpd.web10.8304.1575880970164600351
 for <devel@edk2.groups.io>;
 Mon, 09 Dec 2019 00:42:50 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=jTK6ivtJ;
 spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f68.google.com with SMTP id a15so15132318wrf.9
        for <devel@edk2.groups.io>; Mon, 09 Dec 2019 00:42:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Mrw1UB+3mSAF3y1LpyYVuXxjhcVxNXCr131vH/kFCL8=;
        b=jTK6ivtJJgo862SC5Ygpbc0mNkO1e8hGcvV8BOGoyQnQSAwRbB503sjpNRKp28wtQA
         6DwDEOp5Yczbf/I5e3THFG7LKa0e5oE6u9ccb8X1iidvhca3sHRUcKGW8m2WslmJty2U
         H4WSQdvMzo56TNUWNXqstYqVyysYAy6+MpybeE7/TKdL9SS6A18p6VK68AEHI5ZQ0tt5
         IUq7Tlabh5W/VeGRkzT6/aqfEaYiyddtKDmry7eyJJZWEx13APK+AWwZcv5JzZbfKlWq
         ueRx6vTA9kDc9nJns0ChInhteU6QDsAvj9bW7gW4ZJM5vKvRKo+GcuPKPGMq8B+jcAKw
         al1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Mrw1UB+3mSAF3y1LpyYVuXxjhcVxNXCr131vH/kFCL8=;
        b=esQJB5W3H8yXVdNaAFpr1xCA6tiR8O+RDNF6KAiJpD38LJnBGMRs5lhMY0yPJGZ9aq
         TZPHTGue42HRH5ph76SbluGAIeV6Wj7jq26OrKgZG4/GtdZroeLJNdCc2+CNnYSp0B0q
         dg64jO/AqNml3EMJbVW0z+NbGJDIx11LMnKFQycjBKil1ETkv6/3DcOonIZ0gNa234G6
         +SsllZSNn82U6RwtjLkjj3BTWj8nA3oFvSK0YFhr3ILE44Em0fCDYuxap7zeB6F1+IwI
         GqW9knjHRYBJg/d1tsKZTmZGshLlXzQ/Y+wYGhu1/LZnIdjsiP+7WKHWr57BazMS3MOT
         qKEQ==
X-Gm-Message-State: APjAAAV3UVu0zayWX2969rT6C7+0T7AlUovIofxqWa37GVzoiKBdRopZ
	4GreNb6yJbPPd2co5Y64DvQ4VETnripm/eQyBVX6bQ==
X-Google-Smtp-Source: APXvYqwq67n4y+weGnol9zZSjEZgXo/uYM40LSZIxV5Fq03BtlWL5zfN4rRQPUI2YLs4skGqINKgbLcu8U9aseiJMJY=
X-Received: by 2002:a5d:43c7:: with SMTP id v7mr730631wrr.32.1575880968672;
 Mon, 09 Dec 2019 00:42:48 -0800 (PST)
MIME-Version: 1.0
References: <20191206143128.19371-1-ard.biesheuvel@linaro.org>
 <20191206143128.19371-3-ard.biesheuvel@linaro.org> <8d49cca6-b1b9-cddc-0590-4e4a84643e4f@redhat.com>
 <CAKv+Gu_vbyLf_Ykdeg7w275OP7ZHXK-yDKzxa3iOD=ocT0JpYA@mail.gmail.com> <734D49CCEBEEF84792F5B80ED585239D5C39604F@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C39604F@SHSMSX104.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 9 Dec 2019 08:42:47 +0000
Message-ID: <CAKv+Gu9DfdzT2vHFQvi4UibXHYN0ZoGnU5dJdnw-R-KpZO9MzQ@mail.gmail.com>
Subject: Re: [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####
To: "Ni, Ray" <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Leif Lindholm <leif.lindholm@linaro.org>, "Gao, Zhichao" <zhichao.gao@intel.com>, 
	"Ma, Maurice" <maurice.ma@intel.com>, "Dong, Guo" <guo.dong@intel.com>, 
	"You, Benjamin" <benjamin.you@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 9 Dec 2019 at 03:12, Ni, Ray <ray.ni@intel.com> wrote:
>
> > Exactly. This flow is identical to how option ROMs are processed if
> > they are discovered before EndOfDxe signalling completes (which is why
> > the Juno platform was broken without the call to
> > EfiBootManagerDispatchDeferredImages() in
> > PlatformBootManagerBeforeConsole())
> >
>
> Ard,
> I checked ArmPkg's PlatformBootManagerLib and found it doesn't
> call *DispatchDeferredImages() after signaling EndOfDxe.
>

It does. We just added this in 0f9395d7c5cc6ae2beaa2d87008fe158d04a8069

> The deferred image dispatch mechanism assumes the platform
> needs to call the *DispatchDeferredImages() after signaling EndOfDxe.
>

Indeed.

> I don't understand why the deferred image can be loaded with your patch.
> They are still deferred because the loading time is before EndOfDxe.
>

Yes, but because PlatformBootManagerBeforeConsole () does all of this,
the only way to get Driver#### to work for consoles on GOP drivers, we
need to move it before that call.