From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 976C881BA1 for ; Tue, 17 Jan 2017 01:33:54 -0800 (PST) Received: by mail-it0-x229.google.com with SMTP id 203so91171590ith.0 for ; Tue, 17 Jan 2017 01:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NGR28PwNXB69heX5hmTQPyOsxG+y50fXkE5w2ncR8Ag=; b=bS1F555ryMF8DzA8xoB1p8/ACX6FGOUAzS7ZpPSOFdWwyXPviklTs2b+TzCqcMabIC n1flbWXs8b04cOfM3JfqRk5dYp7ZH0L7bRjrw9UGtNEwVWIeLQuPjfvcyH8MFjLSeuiF b0OrlFpjEQr4RrlaRMxacxI27PgM31WZT7mSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NGR28PwNXB69heX5hmTQPyOsxG+y50fXkE5w2ncR8Ag=; b=fT5lBZF5NMOlTb5cFCE7oF9ig6xjGq3DFzqTIYC1H3wF/Cia7ZsqgTOInKBDDFIg0Q CzNSeSZDElTkm+CFxKdecn2HLQKaV6ruFWBaYrIteDniYZBi1S15uROF58ZYv4GI2tek CJvtuMkangyLEiP8qxTVt7R3Fqjd6tBnQEteDSjA+A5VZmuf0q1txTcX0nc8whtTcBNL g5FeM+tvI+aH8aPh6GnKKapsb/N/adzw+PfPOEvjSn08IB0Wr4J7MtCaNyq1lRagD0zj 3+9HwlCcUd4/+ctj2KFYbeOcV08+iiVQ0xoFwvr5bby/uJ7sxITrjLc90AHIzBUcGa4Z 14Iw== X-Gm-Message-State: AIkVDXLbwa6YK8W2LSeuGFl7uNpGCFK7eM3P8BCGS1VxjXWFfK+ynEW5KNRDeye0oG0TWVzKUtZIVwKwMAzGceOB X-Received: by 10.36.107.194 with SMTP id v185mr18405907itc.59.1484645634494; Tue, 17 Jan 2017 01:33:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.144.135 with HTTP; Tue, 17 Jan 2017 01:33:54 -0800 (PST) In-Reply-To: <1484636920-180432-8-git-send-email-star.zeng@intel.com> References: <1484636920-180432-1-git-send-email-star.zeng@intel.com> <1484636920-180432-8-git-send-email-star.zeng@intel.com> From: Ard Biesheuvel Date: Tue, 17 Jan 2017 09:33:54 +0000 Message-ID: To: Star Zeng Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Liming Gao , Michael Kinney Subject: Re: [PATCH 7/7] ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 09:33:54 -0000 Content-Type: text/plain; charset=UTF-8 On 17 January 2017 at 07:08, Star Zeng wrote: > Use EfiEventGroupSignal from UefiLib and remove > EmptyCallbackFunction. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng Reviewed-by: Ard Biesheuvel > --- > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 ++-------------------- > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 3 +- > .../PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 3 +- > 3 files changed, 6 insertions(+), 36 deletions(-) > > diff --git a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > index ceb4f076e2a6..885866854329 100644 > --- a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > +++ b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > @@ -1,6 +1,6 @@ > /** @file > > -Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.
> +Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.
> Copyright (c) 2014, ARM Ltd. All rights reserved.
> > This program and the accompanying materials > @@ -31,24 +31,6 @@ PlatformIntelBdsConstructor ( > return EFI_SUCCESS; > } > > -/** > - An empty function to pass error checking of CreateEventEx (). > - > - @param Event Event whose notification function is being invoked. > - @param Context Pointer to the notification function's context, > - which is implementation-dependent. > - > -**/ > -STATIC > -VOID > -EFIAPI > -EmptyCallbackFunction ( > - IN EFI_EVENT Event, > - IN VOID *Context > - ) > -{ > -} > - > // > // BDS Platform Functions > // > @@ -63,24 +45,10 @@ PlatformBdsInit ( > VOID > ) > { > - EFI_EVENT EndOfDxeEvent; > - EFI_STATUS Status; > - > // > // Signal EndOfDxe PI Event > // > - Status = gBS->CreateEventEx ( > - EVT_NOTIFY_SIGNAL, > - TPL_CALLBACK, > - EmptyCallbackFunction, > - NULL, > - &gEfiEndOfDxeEventGroupGuid, > - &EndOfDxeEvent > - ); > - if (!EFI_ERROR (Status)) { > - gBS->SignalEvent (EndOfDxeEvent); > - gBS->CloseEvent (EndOfDxeEvent); > - } > + EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); > } > > STATIC > diff --git a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.h b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > index da428288fb9f..1329c54a1c3a 100644 > --- a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > +++ b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > @@ -1,7 +1,7 @@ > /** @file > Head file for BDS Platform specific code > > -Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.
> +Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > which accompanies this distribution. The full text of the license may be found at > @@ -28,6 +28,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > #include > #include > #include > +#include > > #include > #include > diff --git a/ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf b/ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > index daa0d91a2f76..a27adacbc1c2 100644 > --- a/ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > +++ b/ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > @@ -2,7 +2,7 @@ > # Implementation for PlatformBdsLib library class interfaces. > # using ARM Platform framework. > # > -# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
> # Copyright (c) 2014, ARM Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -50,6 +50,7 @@ [LibraryClasses] > UefiBootServicesTableLib > PcdLib > GenericBdsLib > + UefiLib > > [Guids] > gEfiEndOfDxeEventGroupGuid > -- > 2.7.0.windows.1 >